Skip to content

Commit 1354b7c

Browse files
committed
address ambiguous namespace issue for VS2017 builds of the tools
also fix one more place where the compiler should not be set by Trilinos for downstream external projects
1 parent 9cb000e commit 1354b7c

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

tests/examples/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ ExternalProject_Add(custom_app_example
5656
SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/custom_app
5757
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/custom_app/build
5858
TMP_DIR ${CMAKE_CURRENT_BINARY_DIR}/utils_tmp
59-
CMAKE_CACHE_ARGS -DDICE_LIB_DIR:STRING=${DICE_OUTPUT_PREFIX}/lib -DDICE_HEADER_DIR:STRING=${DICE_HEADER_DIRS} -DDICE_TRILINOS_DIR:STRING=${DICE_TRILINOS_DIR} -DTIFF_DIR:STRING=${TIFF_DIR} -DJPEG_DIR:STRING=${JPEG_DIR} -DPNG_DIR:STRING=${PNG_DIR} -DDICE_ENABLE_MANYCORE:BOOL=${DICE_ENABLE_MANYCORE} -DOpenCV_DIR:STRING=${OpenCV_DIR} -DDICE_ENABLE_GLOBAL:BOOL=${DICE_ENABLE_GLOBAL} -DNetCDF_DIR:STRING=${NetCDF_DIR} -DHDF5_DIR:STRING=${HDF5_DIR} -DDICE_USE_DOUBLE:BOOL=${DICE_USE_DOUBLE}-DDICE_MPI:BOOL=${DICE_MPI} -DCMAKE_BUILD_TYPE:STRING=${CMAKE_BUILD_TYPE} -DCMAKE_EXE_LINKER_FLAGS:STRING=${CMAKE_EXE_LINKER_FLAGS} )
59+
CMAKE_CACHE_ARGS -DDICE_LIB_DIR:STRING=${DICE_OUTPUT_PREFIX}/lib -DDICE_HEADER_DIR:STRING=${DICE_HEADER_DIRS} -DDICE_TRILINOS_DIR:STRING=${DICE_TRILINOS_DIR} -DTIFF_DIR:STRING=${TIFF_DIR} -DJPEG_DIR:STRING=${JPEG_DIR} -DPNG_DIR:STRING=${PNG_DIR} -DDICE_ENABLE_MANYCORE:BOOL=${DICE_ENABLE_MANYCORE} -DOpenCV_DIR:STRING=${OpenCV_DIR} -DDICE_ENABLE_GLOBAL:BOOL=${DICE_ENABLE_GLOBAL} -DNetCDF_DIR:STRING=${NetCDF_DIR} -DHDF5_DIR:STRING=${HDF5_DIR} -DDICE_USE_DOUBLE:BOOL=${DICE_USE_DOUBLE}-DDICE_MPI:BOOL=${DICE_MPI} -DCMAKE_BUILD_TYPE:STRING=${CMAKE_BUILD_TYPE} -DCMAKE_CXX_COMPILER:STRING=${CMAKE_CXX_COMPILER} -DCMAKE_C_COMPILER:STRING=${CMAKE_C_COMPILER} -DCMAKE_EXE_LINKER_FLAGS:STRING=${CMAKE_EXE_LINKER_FLAGS} )
6060

6161
# force rebuild of custom_app example
6262
ExternalProject_Add_Step(custom_app_example forcebuild

tests/examples/custom_app/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ MESSAGE(" Trilinos_TPL_LIBRARIES = ${Trilinos_TPL_LIBRARIES}")
3434
MESSAGE(" Trilinos_TPL_LIBRARY_DIRS = ${Trilinos_TPL_LIBRARY_DIRS}")
3535
MESSAGE(" Trilinos_BUILD_SHARED_LIBS = ${Trilinos_BUILD_SHARED_LIBS}")
3636
MESSAGE("End of Trilinos details\n")
37-
SET(CMAKE_CXX_COMPILER ${Trilinos_CXX_COMPILER} )
38-
SET(CMAKE_C_COMPILER ${Trilinos_C_COMPILER} )
3937
SET(CMAKE_VERBOSE_MAKEFILE OFF)
4038
LIST(FIND Trilinos_TPL_LIST MPI MPI_List_ID)
4139
IF (MPI_List_ID GREATER -1)

tools/DICe_TrackingMovieMaker.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ int main(int argc, char *argv[]) {
269269
std::stringstream cine_ss;
270270
cine_ss << trimmed_cine_name << "_" << frame << ".cine";
271271
DEBUG_MSG("Loading cine image " << cine_ss.str());
272-
Mat mat_img = utils::read_image(cine_ss.str().c_str());
272+
Mat mat_img = DICe::utils::read_image(cine_ss.str().c_str());
273273
Mat out_img(mat_img.size(), CV_8UC3);
274274
cvtColor(mat_img, out_img, cv::COLOR_GRAY2RGB);
275275

0 commit comments

Comments
 (0)