initial delete space

Author: gobengo

database/src/space-repository.ts

@@ -61,6 +61,11 @@ export default class SpaceRepository implements IRepository<ISpace> {
       })
     }
   }
+  async deleteById(spaceId: string) {
+    await this.#database.deleteFrom('space')
+      .where('uuid', '=', spaceId)
+      .executeTakeFirstOrThrow()
+  }
   async put(space: Updateable<ISpace> & Pick<ISpace, 'uuid'>) {
     const rowForSpace = {
       controller: space.controller,

database/src/test/test-crud-space.test.ts

@@ -33,5 +33,16 @@ describe('CRUD Space', async () => {
       assert.equal(space.name, spaceToCreate.name)
       assert.equal(space.uuid, spaceToCreate.uuid)
     });
+
+    // get by id
+    const gotById1 = await new SpaceRepository(database).getById(space.uuid);
+    assert.ok(gotById1)
+
+    // delete space
+    await new SpaceRepository(database).deleteById(space.uuid);
+
+    // after delete, get by id -> SpaceNotFound
+    const gotById2 = new SpaceRepository(database).getById(space.uuid);
+    assert.rejects(gotById2, 'SpaceNotFound')
   });
 })

database/src/types.ts

@@ -29,6 +29,7 @@ export interface SpaceTable {
 export interface IRepository<T> {
   getById(id: string): Promise<Selectable<T> | null>
   create(item: Insertable<T>): Promise<void>
+  deleteById(id: string): Promise<boolean|void>
   toArray(): Promise<Selectable<T>[]>
 }
 

package-lock.json

@@ -29,7 +29,7 @@ export function GET(
 }
 
 /**
- * build a route to get a space by uuid from a space repository
+ * build a route to PUT/update a space by uuid from a space repository
  * @param spaces - the space repository to query
  * @returns - hono handler
  */
@@ -51,6 +51,25 @@ export function PUT(
   }
 }
 
+
+/**
+ * build a route to delete a space by uuid from a space repository
+ * @param spaces - the space repository to query
+ * @returns - hono handler
+ */
+export function DELETE(
+  spaces: Pick<SpaceRepository, 'deleteById'>,
+) {
+  // hono request handler
+  // use like
+  //   (new Hono).get('/spaces/:uuid', GET(spaces))
+  return async (c: Context<any, '/:uuid'>) => {
+    const uuid = c.req.param('uuid')
+    await spaces.deleteById(uuid)
+    return c.newResponse(null, 204)
+  }
+}
+
 class AuthorizationMissing extends Error { }
 class NotAuthorized extends Error {}
 

server/src/routes/space.$uuid.ts

@@ -6,6 +6,7 @@ import { GET as getSpacesIndex } from './routes/spaces._index.ts'
 import { POST as postSpacesIndex } from './routes/spaces._index.ts'
 import { GET as getSpaceByUuid } from './routes/space.$uuid.ts'
 import { PUT as putSpaceByUuid } from './routes/space.$uuid.ts'
+import { DELETE as deleteSpaceByUuid } from './routes/space.$uuid.ts'
 import { cors } from 'hono/cors'
 import { authorizeWithSpace } from './lib/authz-middleware.ts'
 import { SpaceResourceHono } from "./routes/space.$uuid.$name.ts"
@@ -69,6 +70,13 @@ export class ServerHono extends Hono {
         allowWhenSpaceNotFound: true,
       }),
       putSpaceByUuid(spaces))
+    // DELETE /space/:uuid
+    hono.delete('/space/:uuid',
+      authorizeWithSpace({
+        data,
+        space: async (c) => spaces.getById(c.req.param('uuid')),
+      }),
+      deleteSpaceByUuid(spaces))
 
     // resources in a space
     // * /space/:space/:name{.*}

server/src/server.ts

@@ -224,4 +224,43 @@ await describe('server', async t => {
       assert.equal(spaceFromGet.name, spaceWithName.name, `space name from GET MUST match space name from most recent PUT`)
     }
   })
+
+  await test('DELETE /space/:uuid', async t => {
+    const spaceUuid = crypto.randomUUID()
+
+    // first create the space
+    {
+      const responseToCreateSpace = await server.fetch(new Request(
+        new URL(`/space/${spaceUuid}`, 'http://example.example'),
+        {
+          method: 'PUT',
+          body: JSON.stringify({ name: `space ${spaceUuid}` }),
+          headers: {
+            'Content-Type': 'application/json',
+          },
+        }
+      ))
+      assert.ok(responseToCreateSpace.ok)
+    }
+
+    const request = new Request(new URL(`/space/${spaceUuid}`, 'http://example.example'), {
+      method: 'DELETE',
+      headers: {
+        'Content-Type': 'application/json',
+      },
+    })
+    const response = await server.fetch(request)
+    assert.equal(response.status, 204, 'response status to DELETE /spaces/ MUST be 204')
+
+    // now try to GET it and see if it was deleted
+    const responseToGetSpace = await server.fetch(new Request(new URL(`/space/${spaceUuid}`, 'http://example.example'), {
+      method: 'GET',
+      headers: {
+        'Accept': 'application/json',
+      },
+    }))
+    assert.equal(
+      responseToGetSpace.status, 404,
+      `response status to GET /space/:uuid MUST be 404 after DELETE`)
+  })
 })