Skip to content

Commit bf979fa

Browse files
authored
Merge pull request #252 from didi/dev_2.4.0
Dev 2.4.0
2 parents f9f3c4d + b3b8889 commit bf979fa

File tree

53 files changed

+807
-213
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+807
-213
lines changed

build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ cd $workspace
44

55
## constant
66
OUTPUT_DIR=./output
7-
KM_VERSION=2.3.1
7+
KM_VERSION=2.4.0
88
APP_NAME=kafka-manager
99
APP_DIR=${APP_NAME}-${KM_VERSION}
1010

kafka-manager-common/src/main/java/com/xiaojukeji/kafka/manager/common/bizenum/OperateEnum.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public static OperateEnum valueOf(Integer code) {
4646

4747
public static boolean validate(Integer code) {
4848
if (code == null) {
49-
return false;
49+
return true;
5050
}
5151
for (OperateEnum state : OperateEnum.values()) {
5252
if (state.getCode() == code) {

kafka-manager-common/src/main/java/com/xiaojukeji/kafka/manager/common/entity/dto/rd/OperateRecordDTO.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,6 @@ public String toString() {
8181
}
8282

8383
public boolean legal() {
84-
if (!ModuleEnum.validate(moduleId) ||
85-
(!ValidateUtils.isNull(operateId) && OperateEnum.validate(operateId))
86-
) {
87-
return false;
88-
}
89-
return true;
84+
return !ValidateUtils.isNull(moduleId) && ModuleEnum.validate(moduleId) && OperateEnum.validate(operateId);
9085
}
9186
}

kafka-manager-extends/kafka-manager-openapi/src/main/java/com/xiaojukeji/kafka/manager/openapi/common/vo/TopicStatisticMetricsVO.java renamed to kafka-manager-common/src/main/java/com/xiaojukeji/kafka/manager/common/entity/vo/normal/topic/TopicStatisticMetricsVO.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.xiaojukeji.kafka.manager.openapi.common.vo;
1+
package com.xiaojukeji.kafka.manager.common.entity.vo.normal.topic;
22

33
import io.swagger.annotations.ApiModel;
44
import io.swagger.annotations.ApiModelProperty;
@@ -14,7 +14,6 @@ public class TopicStatisticMetricsVO {
1414

1515
public TopicStatisticMetricsVO(Double peakBytesIn) {
1616
this.peakBytesIn = peakBytesIn;
17-
1817
}
1918

2019
public Double getPeakBytesIn() {

kafka-manager-console/src/component/flow-table/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ export class StatusGraghCom<T extends IFlowInfo> extends React.Component {
6868
public render() {
6969
const statusData = this.getData();
7070
const loading = this.getLoading();
71-
if (!statusData) return null;
7271
const data: any[] = [];
72+
if (!statusData) return <Table columns={flowColumns} dataSource={data} />;
7373
Object.keys(statusData).map((key) => {
7474
if (statusData[key]) {
7575
const v = key === 'byteIn' || key === 'byteOut' ? statusData[key].map(i => i && (i / 1024).toFixed(2)) :
@@ -85,7 +85,7 @@ export class StatusGraghCom<T extends IFlowInfo> extends React.Component {
8585
}
8686
});
8787
return (
88-
<Table columns={flowColumns} dataSource={data} pagination={false} loading={loading}/>
88+
<Table columns={flowColumns} dataSource={data} pagination={false} loading={loading} />
8989
);
9090
}
9191
}

kafka-manager-console/src/component/x-form/index.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.ant-input-number {
1+
.ant-input-number, .ant-form-item-children .ant-select {
22
width: 314px
33
}
44

kafka-manager-console/src/constants/left-menu.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ export const adminMenu = [{
5959
href: `/admin/bill`,
6060
i: 'k-icon-renwuliebiao',
6161
title: '用户账单',
62+
},{
63+
href: `/admin/operation-record`,
64+
i: 'k-icon-operationrecord',
65+
title: '操作记录',
6266
}] as ILeftMenu[];
6367

6468
export const expertMenu = [{

kafka-manager-console/src/container/admin/cluster-detail/cluster-topic.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export class ClusterTopic extends SearchAndFilterContainer {
172172
key: 'appName',
173173
// width: '10%',
174174
render: (val: string, record: IClusterTopics) => (
175-
<Tooltip placement="bottomLeft" title={record.appId} >
175+
<Tooltip placement="bottomLeft" title={val} >
176176
{val}
177177
</Tooltip>
178178
),

kafka-manager-console/src/container/admin/cluster-detail/exclusive-cluster.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,8 +314,7 @@ export class ExclusiveCluster extends SearchAndFilterContainer {
314314
>
315315
<div className="region-prompt">
316316
<span>
317-
由于该Region已被逻辑集群【 {this.state.logicalClusterName} 】使用
318-
请先解除Region与逻辑集群的关系
317+
该Region已被逻辑集群【 {this.state.logicalClusterName} 】使用,请先解除Region与逻辑集群的关系
319318
</span>
320319
</div>
321320
</Modal>

kafka-manager-console/src/container/admin/cluster-detail/index.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
.traffic-table {
1818
margin: 10px 0;
19-
min-height: 450px;
19+
min-height: 330px;
2020
.traffic-header {
2121
width: 100%;
2222
height: 44px;

0 commit comments

Comments
 (0)