Skip to content

Commit f234f74

Browse files
authored
Merge pull request #603 from didi/dev
合并开发分支
2 parents 597ea04 + e146796 commit f234f74

File tree

21 files changed

+154
-74
lines changed

21 files changed

+154
-74
lines changed

bin/startup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ error_exit ()
99
[ ! -e "$JAVA_HOME/bin/java" ] && unset JAVA_HOME
1010

1111
if [ -z "$JAVA_HOME" ]; then
12-
if $darwin; then
12+
if [ "Darwin" = "$(uname -s)" ]; then
1313

1414
if [ -x '/usr/libexec/java_home' ] ; then
1515
export JAVA_HOME=`/usr/libexec/java_home`

docs/install_guide/版本升级手册.md

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ thread-pool:
4040

4141
```
4242

43-
44-
**SQL变更**
43+
**SQL 变更**
4544

4645
```sql
4746
-- 多集群管理权限2022-09-06新增
@@ -80,12 +79,11 @@ ALTER TABLE `logi_security_oplog`
8079

8180
### 6.2.2、升级至 `v3.0.0-beta.1`版本
8281

83-
84-
**SQL变更**
82+
**SQL 变更**
8583

8684
1、在`ks_km_broker`表增加了一个监听信息字段。
87-
2、为`logi_security_oplog`表operation_methods字段设置默认值''。
88-
因此需要执行下面的sql对数据库表进行更新
85+
2、为`logi_security_oplog`表 operation_methods 字段设置默认值''。
86+
因此需要执行下面的 sql 对数据库表进行更新
8987

9088
```sql
9189
ALTER TABLE `ks_km_broker`
@@ -98,7 +96,6 @@ ALTER COLUMN `operation_methods` set default '';
9896

9997
---
10098

101-
10299
### 6.2.3、`2.x`版本 升级至 `v3.0.0-beta.0`版本
103100

104101
**升级步骤:**
@@ -123,14 +120,14 @@ ALTER COLUMN `operation_methods` set default '';
123120
UPDATE ks_km_topic
124121
INNER JOIN
125122
(SELECT
126-
topic.cluster_id AS cluster_id,
127-
topic.topic_name AS topic_name,
128-
topic.description AS description
123+
topic.cluster_id AS cluster_id,
124+
topic.topic_name AS topic_name,
125+
topic.description AS description
129126
FROM topic WHERE description != ''
130127
) AS t
131128

132-
ON ks_km_topic.cluster_phy_id = t.cluster_id
133-
AND ks_km_topic.topic_name = t.topic_name
134-
AND ks_km_topic.id > 0
135-
SET ks_km_topic.description = t.description;
129+
ON ks_km_topic.cluster_phy_id = t.cluster_id
130+
AND ks_km_topic.topic_name = t.topic_name
131+
AND ks_km_topic.id > 0
132+
SET ks_km_topic.description = t.description;
136133
```

docs/user_guide/用户使用手册.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
下面是用户第一次使用我们产品的典型体验路径:
1313

14-
![text](http://img-ys011.didistatic.com/static/dc2img/do1_YehqxqmsVaqU5gf3XphI)
14+
![text](http://img-ys011.didistatic.com/static/dc2img/do1_qgqPsAY46sZeBaPUCwXY)
1515

1616
## 5.3、常用功能
1717

km-biz/src/main/java/com/xiaojukeji/know/streaming/km/biz/group/impl/GroupManagerImpl.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import com.xiaojukeji.know.streaming.km.common.bean.vo.group.GroupTopicOverviewVO;
2020
import com.xiaojukeji.know.streaming.km.common.constant.MsgConstant;
2121
import com.xiaojukeji.know.streaming.km.common.enums.AggTypeEnum;
22-
import com.xiaojukeji.know.streaming.km.common.enums.GroupOffsetResetEnum;
22+
import com.xiaojukeji.know.streaming.km.common.enums.OffsetTypeEnum;
2323
import com.xiaojukeji.know.streaming.km.common.enums.group.GroupStateEnum;
2424
import com.xiaojukeji.know.streaming.km.common.exception.AdminOperateException;
2525
import com.xiaojukeji.know.streaming.km.common.exception.NotExistException;
@@ -199,12 +199,12 @@ private Result<Void> checkFieldLegal(GroupOffsetResetDTO dto) {
199199
return Result.buildFromRSAndMsg(ResultStatus.NOT_EXIST, MsgConstant.getTopicNotExist(dto.getClusterId(), dto.getTopicName()));
200200
}
201201

202-
if (GroupOffsetResetEnum.PRECISE_OFFSET.getResetType() == dto.getResetType()
202+
if (OffsetTypeEnum.PRECISE_OFFSET.getResetType() == dto.getResetType()
203203
&& ValidateUtils.isEmptyList(dto.getOffsetList())) {
204204
return Result.buildFromRSAndMsg(ResultStatus.PARAM_ILLEGAL, "参数错误,指定offset重置需传offset信息");
205205
}
206206

207-
if (GroupOffsetResetEnum.PRECISE_TIMESTAMP.getResetType() == dto.getResetType()
207+
if (OffsetTypeEnum.PRECISE_TIMESTAMP.getResetType() == dto.getResetType()
208208
&& ValidateUtils.isNull(dto.getTimestamp())) {
209209
return Result.buildFromRSAndMsg(ResultStatus.PARAM_ILLEGAL, "参数错误,指定时间重置需传时间信息");
210210
}
@@ -213,7 +213,7 @@ private Result<Void> checkFieldLegal(GroupOffsetResetDTO dto) {
213213
}
214214

215215
private Result<Map<TopicPartition, Long>> getPartitionOffset(GroupOffsetResetDTO dto) {
216-
if (GroupOffsetResetEnum.PRECISE_OFFSET.getResetType() == dto.getResetType()) {
216+
if (OffsetTypeEnum.PRECISE_OFFSET.getResetType() == dto.getResetType()) {
217217
return Result.buildSuc(dto.getOffsetList().stream().collect(Collectors.toMap(
218218
elem -> new TopicPartition(dto.getTopicName(), elem.getPartitionId()),
219219
PartitionOffsetDTO::getOffset,
@@ -222,9 +222,9 @@ private Result<Map<TopicPartition, Long>> getPartitionOffset(GroupOffsetResetDTO
222222
}
223223

224224
OffsetSpec offsetSpec = null;
225-
if (GroupOffsetResetEnum.PRECISE_TIMESTAMP.getResetType() == dto.getResetType()) {
225+
if (OffsetTypeEnum.PRECISE_TIMESTAMP.getResetType() == dto.getResetType()) {
226226
offsetSpec = OffsetSpec.forTimestamp(dto.getTimestamp());
227-
} else if (GroupOffsetResetEnum.EARLIEST.getResetType() == dto.getResetType()) {
227+
} else if (OffsetTypeEnum.EARLIEST.getResetType() == dto.getResetType()) {
228228
offsetSpec = OffsetSpec.earliest();
229229
} else {
230230
offsetSpec = OffsetSpec.latest();

km-biz/src/main/java/com/xiaojukeji/know/streaming/km/biz/topic/TopicStateManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.xiaojukeji.know.streaming.km.biz.topic;
22

3+
import com.xiaojukeji.know.streaming.km.common.bean.dto.pagination.PaginationSortDTO;
34
import com.xiaojukeji.know.streaming.km.common.bean.dto.topic.TopicRecordDTO;
45
import com.xiaojukeji.know.streaming.km.common.bean.entity.result.Result;
56
import com.xiaojukeji.know.streaming.km.common.bean.vo.topic.TopicBrokersPartitionsSummaryVO;

km-biz/src/main/java/com/xiaojukeji/know/streaming/km/biz/topic/impl/TopicStateManagerImpl.java

Lines changed: 40 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,26 @@
2222
import com.xiaojukeji.know.streaming.km.common.constant.Constant;
2323
import com.xiaojukeji.know.streaming.km.common.constant.KafkaConstant;
2424
import com.xiaojukeji.know.streaming.km.common.constant.MsgConstant;
25-
import com.xiaojukeji.know.streaming.km.common.converter.PartitionConverter;
2625
import com.xiaojukeji.know.streaming.km.common.converter.TopicVOConverter;
26+
import com.xiaojukeji.know.streaming.km.common.enums.OffsetTypeEnum;
27+
import com.xiaojukeji.know.streaming.km.common.enums.SortTypeEnum;
2728
import com.xiaojukeji.know.streaming.km.common.exception.AdminOperateException;
2829
import com.xiaojukeji.know.streaming.km.common.exception.NotExistException;
2930
import com.xiaojukeji.know.streaming.km.common.utils.ConvertUtil;
31+
import com.xiaojukeji.know.streaming.km.common.utils.PaginationUtil;
3032
import com.xiaojukeji.know.streaming.km.common.utils.ValidateUtils;
3133
import com.xiaojukeji.know.streaming.km.core.service.broker.BrokerService;
3234
import com.xiaojukeji.know.streaming.km.core.service.cluster.ClusterPhyService;
3335
import com.xiaojukeji.know.streaming.km.core.service.partition.PartitionMetricService;
34-
import com.xiaojukeji.know.streaming.km.core.service.topic.TopicConfigService;
3536
import com.xiaojukeji.know.streaming.km.core.service.partition.PartitionService;
37+
import com.xiaojukeji.know.streaming.km.core.service.topic.TopicConfigService;
3638
import com.xiaojukeji.know.streaming.km.core.service.topic.TopicMetricService;
3739
import com.xiaojukeji.know.streaming.km.core.service.topic.TopicService;
3840
import com.xiaojukeji.know.streaming.km.core.service.version.metrics.TopicMetricVersionItems;
41+
import org.apache.commons.lang3.ObjectUtils;
42+
import org.apache.commons.lang3.StringUtils;
3943
import org.apache.kafka.clients.admin.OffsetSpec;
40-
import org.apache.kafka.clients.consumer.ConsumerConfig;
41-
import org.apache.kafka.clients.consumer.ConsumerRecord;
42-
import org.apache.kafka.clients.consumer.ConsumerRecords;
43-
import org.apache.kafka.clients.consumer.KafkaConsumer;
44+
import org.apache.kafka.clients.consumer.*;
4445
import org.apache.kafka.common.TopicPartition;
4546
import org.apache.kafka.common.config.TopicConfig;
4647
import org.springframework.beans.factory.annotation.Autowired;
@@ -160,8 +161,31 @@ public Result<List<TopicRecordVO>> getTopicMessages(Long clusterPhyId, String to
160161
}
161162
maxMessage = Math.min(maxMessage, dto.getMaxRecords());
162163
kafkaConsumer.assign(partitionList);
164+
165+
Map<TopicPartition, OffsetAndTimestamp> partitionOffsetAndTimestampMap = new HashMap<>();
166+
// 获取指定时间每个分区的offset(按指定开始时间查询消息时)
167+
if (OffsetTypeEnum.PRECISE_TIMESTAMP.getResetType() == dto.getFilterOffsetReset()) {
168+
Map<TopicPartition, Long> timestampsToSearch = new HashMap<>();
169+
partitionList.forEach(topicPartition -> {
170+
timestampsToSearch.put(topicPartition, dto.getStartTimestampUnitMs());
171+
});
172+
partitionOffsetAndTimestampMap = kafkaConsumer.offsetsForTimes(timestampsToSearch);
173+
}
174+
163175
for (TopicPartition partition : partitionList) {
164-
kafkaConsumer.seek(partition, Math.max(beginOffsetsMapResult.getData().get(partition), endOffsetsMapResult.getData().get(partition) - dto.getMaxRecords()));
176+
if (OffsetTypeEnum.EARLIEST.getResetType() == dto.getFilterOffsetReset()) {
177+
// 重置到最旧
178+
kafkaConsumer.seek(partition, beginOffsetsMapResult.getData().get(partition));
179+
} else if (OffsetTypeEnum.PRECISE_TIMESTAMP.getResetType() == dto.getFilterOffsetReset()) {
180+
// 重置到指定时间
181+
kafkaConsumer.seek(partition, partitionOffsetAndTimestampMap.get(partition).offset());
182+
} else if (OffsetTypeEnum.PRECISE_OFFSET.getResetType() == dto.getFilterOffsetReset()) {
183+
// 重置到指定位置
184+
185+
} else {
186+
// 默认,重置到最新
187+
kafkaConsumer.seek(partition, Math.max(beginOffsetsMapResult.getData().get(partition), endOffsetsMapResult.getData().get(partition) - dto.getMaxRecords()));
188+
}
165189
}
166190

167191
// 这里需要减去 KafkaConstant.POLL_ONCE_TIMEOUT_UNIT_MS 是因为poll一次需要耗时,如果这里不减去,则可能会导致poll之后,超过要求的时间
@@ -185,6 +209,15 @@ public Result<List<TopicRecordVO>> getTopicMessages(Long clusterPhyId, String to
185209
}
186210
}
187211

212+
// 排序
213+
if (ObjectUtils.isNotEmpty(voList)) {
214+
// 默认按时间倒序排序
215+
if (StringUtils.isBlank(dto.getSortType())) {
216+
dto.setSortType(SortTypeEnum.DESC.getSortType());
217+
}
218+
PaginationUtil.pageBySort(voList, dto.getSortField(), dto.getSortType());
219+
}
220+
188221
return Result.buildSuc(voList.subList(0, Math.min(dto.getMaxRecords(), voList.size())));
189222
} catch (Exception e) {
190223
log.error("method=getTopicMessages||clusterPhyId={}||topicName={}||param={}||errMsg=exception", clusterPhyId, topicName, dto, e);

km-common/src/main/java/com/xiaojukeji/know/streaming/km/common/bean/dto/group/GroupOffsetResetDTO.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
44
import com.xiaojukeji.know.streaming.km.common.bean.dto.partition.PartitionOffsetDTO;
55
import com.xiaojukeji.know.streaming.km.common.bean.dto.topic.ClusterTopicDTO;
6+
import com.xiaojukeji.know.streaming.km.common.enums.OffsetTypeEnum;
67
import io.swagger.annotations.ApiModelProperty;
78
import lombok.Data;
89

@@ -23,7 +24,7 @@ public class GroupOffsetResetDTO extends ClusterTopicDTO {
2324
private String groupName;
2425

2526
/**
26-
* @see com.xiaojukeji.know.streaming.km.common.enums.GroupOffsetResetEnum
27+
* @see OffsetTypeEnum
2728
*/
2829
@NotNull(message = "resetType不允许为空")
2930
@ApiModelProperty(value = "重置方式", example = "1")

km-common/src/main/java/com/xiaojukeji/know/streaming/km/common/bean/dto/topic/TopicRecordDTO.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
package com.xiaojukeji.know.streaming.km.common.bean.dto.topic;
22

33
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
4-
import com.xiaojukeji.know.streaming.km.common.bean.dto.BaseDTO;
4+
import com.xiaojukeji.know.streaming.km.common.bean.dto.pagination.PaginationSortDTO;
5+
import com.xiaojukeji.know.streaming.km.common.enums.OffsetTypeEnum;
56
import io.swagger.annotations.ApiModel;
67
import io.swagger.annotations.ApiModelProperty;
78
import lombok.Data;
@@ -15,7 +16,7 @@
1516
@Data
1617
@JsonIgnoreProperties(ignoreUnknown = true)
1718
@ApiModel(description = "Topic记录")
18-
public class TopicRecordDTO extends BaseDTO {
19+
public class TopicRecordDTO extends PaginationSortDTO {
1920
@NotNull(message = "truncate不允许为空")
2021
@ApiModelProperty(value = "是否截断", example = "true")
2122
private Boolean truncate;
@@ -34,4 +35,13 @@ public class TopicRecordDTO extends BaseDTO {
3435

3536
@ApiModelProperty(value = "预览超时时间", example = "10000")
3637
private Long pullTimeoutUnitMs = 8000L;
38+
39+
/**
40+
* @see OffsetTypeEnum
41+
*/
42+
@ApiModelProperty(value = "offset", example = "")
43+
private Integer filterOffsetReset = 0;
44+
45+
@ApiModelProperty(value = "开始日期时间戳", example = "")
46+
private Long startTimestampUnitMs;
3747
}

km-common/src/main/java/com/xiaojukeji/know/streaming/km/common/constant/Constant.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,5 @@ private Constant() {}
6464
public static final Float COLLECT_METRICS_ERROR_COST_TIME = -1.0F;
6565

6666
public static final Integer DEFAULT_RETRY_TIME = 3;
67+
6768
}

km-common/src/main/java/com/xiaojukeji/know/streaming/km/common/enums/GroupOffsetResetEnum.java renamed to km-common/src/main/java/com/xiaojukeji/know/streaming/km/common/enums/OffsetTypeEnum.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,27 +3,27 @@
33
import lombok.Getter;
44

55
/**
6-
* 重置offset
6+
* offset类型
77
* @author zengqiao
88
* @date 19/4/8
99
*/
1010
@Getter
11-
public enum GroupOffsetResetEnum {
12-
LATEST(0, "重置到最新"),
11+
public enum OffsetTypeEnum {
12+
LATEST(0, "最新"),
1313

14-
EARLIEST(1, "重置到最旧"),
14+
EARLIEST(1, "最旧"),
1515

16-
PRECISE_TIMESTAMP(2, "按时间进行重置"),
16+
PRECISE_TIMESTAMP(2, "指定时间"),
1717

18-
PRECISE_OFFSET(3, "重置到指定位置"),
18+
PRECISE_OFFSET(3, "指定位置"),
1919

2020
;
2121

2222
private final int resetType;
2323

2424
private final String message;
2525

26-
GroupOffsetResetEnum(int resetType, String message) {
26+
OffsetTypeEnum(int resetType, String message) {
2727
this.resetType = resetType;
2828
this.message = message;
2929
}

0 commit comments

Comments
 (0)