Skip to content

Commit ecc4d4a

Browse files
authored
Merge pull request #2347 from didi/fix-portal-manager-usecallback
优化portal-manager 更新portal值的写法
2 parents 2b693c5 + 0bb5e6b commit ecc4d4a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/webpack-plugin/lib/runtime/components/react/mpx-portal/portal-manager.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const _PortalManager = forwardRef((props: PortalManagerProps, ref:ForwardedRef<u
1919
setState((prevState) => ({
2020
portals: [...prevState.portals, { key, children }]
2121
}))
22-
}, [state])
22+
}, [])
2323

2424
const update = useCallback((key: number, children: ReactNode) => {
2525
setState((prevState) => ({
@@ -30,7 +30,7 @@ const _PortalManager = forwardRef((props: PortalManagerProps, ref:ForwardedRef<u
3030
return item
3131
})
3232
}))
33-
}, [state])
33+
}, [])
3434

3535
const unmount = useCallback((key: number) => {
3636
setState((prevState) => ({

0 commit comments

Comments
 (0)