Skip to content

Commit f8941df

Browse files
authored
Merge pull request #2107 from didi/feat-rn-split-chunk-rnExternalRequests
rnExternalRequests收集分包 chunk name 信息
2 parents 094c644 + d028de2 commit f8941df

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

packages/webpack-plugin/lib/dependencies/RequireExternalDependency.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,11 @@ RequireExternalDependency.Template = class RequireExternalDependencyTemplate {
4747
relativePath = './' + relativePath
4848
}
4949

50-
compliation.__mpx__.externalRequests.add(relativePath)
50+
if (!compliation.__mpx__.externalRequestsMap.has(chunk.name)) {
51+
compliation.__mpx__.externalRequestsMap.set(chunk.name, new Set())
52+
}
53+
compliation.__mpx__.externalRequestsMap.get(chunk.name).add(relativePath)
54+
5155
source.replace(range[0], range[1] - 1, `require(${JSON.stringify(relativePath)})`)
5256
}
5357
}

packages/webpack-plugin/lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ class MpxWebpackPlugin {
729729
// 记录与asset相关联的ast,用于体积分析和esCheck,避免重复parse
730730
assetsASTsMap: new Map(),
731731
// 记录RequireExternalDependency相关资源路径
732-
externalRequests: new Set(),
732+
externalRequestsMap: new Map(),
733733
globalComponents: {},
734734
globalComponentsInfo: {},
735735
// todo es6 map读写性能高于object,之后会逐步替换

0 commit comments

Comments
 (0)