Skip to content

Commit 285cfc7

Browse files
diegomuradiegomura
authored
fix: tests linting issues (#3068)
1 parent 96c2464 commit 285cfc7

File tree

14 files changed

+82
-89
lines changed

14 files changed

+82
-89
lines changed

‎.eslintrc.json‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,7 @@
4444
"react/jsx-props-no-spreading": 0,
4545
"react/jsx-no-useless-fragment": 0,
4646
"react/prop-types": 0,
47-
"react/state-in-constructor": 0,
48-
"@vitest/valid-expect": 0,
49-
"@vitest/no-identical-title": 0,
50-
"@vitest/expect-expect": 0
47+
"react/state-in-constructor": 0
5148
},
5249
"overrides": [
5350
{

‎packages/layout/tests/image/resolveSource.test.js‎

Lines changed: 62 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -10,124 +10,136 @@ const SOURCE_BLOB = new Blob([SOURCE_BUFFER], { type: 'image/png' });
1010

1111
describe('image resolveSource', () => {
1212
describe('source', () => {
13-
it('resolves url', () => {
14-
expect(resolveSource(SOURCE_URL)).resolves.toEqual({ uri: SOURCE_URL });
13+
it('resolves url', async () => {
14+
await expect(resolveSource(SOURCE_URL)).resolves.toEqual({
15+
uri: SOURCE_URL,
16+
});
1517
});
1618

17-
it('resolves url object', () => {
18-
expect(resolveSource(SOURCE_URL_OBJECT)).resolves.toBe(SOURCE_URL_OBJECT);
19+
it('resolves url object', async () => {
20+
await expect(resolveSource(SOURCE_URL_OBJECT)).resolves.toBe(
21+
SOURCE_URL_OBJECT,
22+
);
1923
});
2024

21-
it('resolves buffer', () => {
22-
expect(resolveSource(SOURCE_BUFFER)).resolves.toBe(SOURCE_BUFFER);
25+
it('resolves buffer', async () => {
26+
await expect(resolveSource(SOURCE_BUFFER)).resolves.toBe(SOURCE_BUFFER);
2327
});
2428

25-
it('resolves data buffer', () => {
26-
expect(resolveSource(SOURCE_DATA_BUFFER)).resolves.toBe(
29+
it('resolves data buffer', async () => {
30+
await expect(resolveSource(SOURCE_DATA_BUFFER)).resolves.toBe(
2731
SOURCE_DATA_BUFFER,
2832
);
2933
});
3034

31-
it('resolves blob', () => {
32-
expect(resolveSource(SOURCE_BLOB)).resolves.toBe(SOURCE_BLOB);
35+
it('resolves blob', async () => {
36+
await expect(resolveSource(SOURCE_BLOB)).resolves.toBe(SOURCE_BLOB);
3337
});
3438
});
3539

3640
describe('async', () => {
37-
it('resolves url', () => {
38-
expect(resolveSource(Promise.resolve(SOURCE_URL))).resolves.toEqual({
39-
uri: SOURCE_URL,
40-
});
41+
it('resolves url', async () => {
42+
await expect(resolveSource(Promise.resolve(SOURCE_URL))).resolves.toEqual(
43+
{
44+
uri: SOURCE_URL,
45+
},
46+
);
4147
});
4248

43-
it('resolves url object', () => {
44-
expect(resolveSource(Promise.resolve(SOURCE_URL_OBJECT))).resolves.toBe(
45-
SOURCE_URL_OBJECT,
46-
);
49+
it('resolves url object', async () => {
50+
await expect(
51+
resolveSource(Promise.resolve(SOURCE_URL_OBJECT)),
52+
).resolves.toBe(SOURCE_URL_OBJECT);
4753
});
4854

49-
it('resolves buffer', () => {
50-
expect(resolveSource(Promise.resolve(SOURCE_BUFFER))).resolves.toBe(
55+
it('resolves buffer', async () => {
56+
await expect(resolveSource(Promise.resolve(SOURCE_BUFFER))).resolves.toBe(
5157
SOURCE_BUFFER,
5258
);
5359
});
5460

55-
it('resolves data buffer', () => {
56-
expect(resolveSource(Promise.resolve(SOURCE_DATA_BUFFER))).resolves.toBe(
57-
SOURCE_DATA_BUFFER,
58-
);
61+
it('resolves data buffer', async () => {
62+
await expect(
63+
resolveSource(Promise.resolve(SOURCE_DATA_BUFFER)),
64+
).resolves.toBe(SOURCE_DATA_BUFFER);
5965
});
6066

61-
it('resolves blob', () => {
62-
expect(resolveSource(Promise.resolve(SOURCE_BLOB))).resolves.toBe(
67+
it('resolves blob', async () => {
68+
await expect(resolveSource(Promise.resolve(SOURCE_BLOB))).resolves.toBe(
6369
SOURCE_BLOB,
6470
);
6571
});
6672
});
6773

6874
describe('factory', () => {
69-
it('resolves url', () => {
70-
expect(resolveSource(() => SOURCE_URL)).resolves.toEqual({
75+
it('resolves url', async () => {
76+
await expect(resolveSource(() => SOURCE_URL)).resolves.toEqual({
7177
uri: SOURCE_URL,
7278
});
7379
});
7480

75-
it('resolves url object', () => {
76-
expect(resolveSource(() => SOURCE_URL_OBJECT)).resolves.toBe(
81+
it('resolves url object', async () => {
82+
await expect(resolveSource(() => SOURCE_URL_OBJECT)).resolves.toBe(
7783
SOURCE_URL_OBJECT,
7884
);
7985
});
8086

81-
it('resolves buffer', () => {
82-
expect(resolveSource(() => SOURCE_BUFFER)).resolves.toBe(SOURCE_BUFFER);
87+
it('resolves buffer', async () => {
88+
await expect(resolveSource(() => SOURCE_BUFFER)).resolves.toBe(
89+
SOURCE_BUFFER,
90+
);
8391
});
8492

85-
it('resolves data buffer', () => {
86-
expect(resolveSource(() => SOURCE_DATA_BUFFER)).resolves.toBe(
93+
it('resolves data buffer', async () => {
94+
await expect(resolveSource(() => SOURCE_DATA_BUFFER)).resolves.toBe(
8795
SOURCE_DATA_BUFFER,
8896
);
8997
});
9098

91-
it('resolves undefined', () => {
92-
expect(resolveSource(() => undefined)).resolves.toBe(undefined);
99+
it('resolves undefined', async () => {
100+
await expect(resolveSource(() => undefined)).resolves.toBe(undefined);
93101
});
94102

95-
it('resolves blob', () => {
96-
expect(resolveSource(() => SOURCE_BLOB)).resolves.toBe(SOURCE_BLOB);
103+
it('resolves blob', async () => {
104+
await expect(resolveSource(() => SOURCE_BLOB)).resolves.toBe(SOURCE_BLOB);
97105
});
98106
});
99107

100108
describe('async factory', () => {
101-
it('resolves url', () => {
102-
expect(resolveSource(async () => SOURCE_URL)).resolves.toEqual({
109+
it('resolves url', async () => {
110+
await expect(resolveSource(async () => SOURCE_URL)).resolves.toEqual({
103111
uri: SOURCE_URL,
104112
});
105113
});
106114

107-
it('resolves url object', () => {
108-
expect(resolveSource(async () => SOURCE_URL_OBJECT)).resolves.toBe(
115+
it('resolves url object', async () => {
116+
await expect(resolveSource(async () => SOURCE_URL_OBJECT)).resolves.toBe(
109117
SOURCE_URL_OBJECT,
110118
);
111119
});
112120

113-
it('resolves buffer', () => {
114-
expect(resolveSource(async () => SOURCE_BUFFER)).resolves.toBe(
121+
it('resolves buffer', async () => {
122+
await expect(resolveSource(async () => SOURCE_BUFFER)).resolves.toBe(
115123
SOURCE_BUFFER,
116124
);
117125
});
118126

119-
it('resolves data buffer', () => {
120-
expect(resolveSource(async () => SOURCE_DATA_BUFFER)).resolves.toBe(
127+
it('resolves data buffer', async () => {
128+
await expect(resolveSource(async () => SOURCE_DATA_BUFFER)).resolves.toBe(
121129
SOURCE_DATA_BUFFER,
122130
);
123131
});
124132

125-
it('resolves undefined', () => {
126-
expect(resolveSource(async () => undefined)).resolves.toBe(undefined);
133+
it('resolves undefined', async () => {
134+
await expect(resolveSource(async () => undefined)).resolves.toBe(
135+
undefined,
136+
);
127137
});
128138

129-
it('resolves blob', () => {
130-
expect(resolveSource(async () => SOURCE_BLOB)).resolves.toBe(SOURCE_BLOB);
139+
it('resolves blob', async () => {
140+
await expect(resolveSource(async () => SOURCE_BLOB)).resolves.toBe(
141+
SOURCE_BLOB,
142+
);
131143
});
132144
});
133145
});

‎packages/layout/tests/steps/resolveInhritance.test.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* eslint-disable @vitest/expect-expect */
2+
13
import { describe, expect, test } from 'vitest';
24

35
import resolveInheritance from '../../src/steps/resolveInheritance';

‎packages/renderer/tests/components.test.jsx‎

Lines changed: 3 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const TestDocument = ({ title = 'Default' }) => (
1919
);
2020

2121
describe('BlobProvider', () => {
22-
it('works', async () => {
22+
it('calls render function', async () => {
2323
const renderFunction = vi.fn();
2424

2525
render(
@@ -37,38 +37,15 @@ describe('BlobProvider', () => {
3737
}),
3838
);
3939
});
40-
});
4140

42-
describe('BlobProvider', () => {
43-
it('works', async () => {
44-
const renderFunction = vi.fn();
45-
46-
render(
47-
<BlobProvider document={<TestDocument />}>{renderFunction}</BlobProvider>,
48-
);
49-
50-
await waitFor(() => expect(renderFunction).toBeCalledTimes(3));
51-
52-
expect(renderFunction).toHaveBeenCalledWith(
53-
expect.objectContaining({
54-
blob: expect.anything(),
55-
url: expect.anything(),
56-
error: null,
57-
loading: false,
58-
}),
59-
);
60-
});
61-
});
62-
63-
describe('BlobProvider', () => {
64-
it('works', async () => {
41+
it('renders iframe', async () => {
6542
const { container } = render(
6643
<PDFViewer>
6744
<TestDocument />
6845
</PDFViewer>,
6946
);
7047

71-
await waitFor(() => expect(container.querySelector('iframe')));
48+
await waitFor(() => expect(container.querySelector('iframe')).toBeTruthy());
7249
});
7350
});
7451

‎packages/renderer/tests/resume.test.jsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
/* eslint-disable @vitest/no-identical-title */
12
/* eslint-disable react/no-array-index-key */
3+
24
import { describe, expect, test } from 'vitest';
35

46
import {

‎packages/textkit/tests/indices/normalize.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('indices normalizeArray operator', () => {
2525
expect(normalizeArray(list)).toEqual([0, 3, 6]);
2626
});
2727

28-
test('should normalize consecutive numbers starting on zero', () => {
28+
test('should normalize ascending non-consecutive numbers starting on zero', () => {
2929
const list = [0, 3, 8];
3030

3131
expect(normalizeArray(list)).toEqual([0, 3, 8]);

‎packages/textkit/tests/layout/applyDefaultStyles.test.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* eslint-disable @vitest/expect-expect */
2+
13
import { describe, expect, test } from 'vitest';
24

35
import applyDefaultStyles from '../../src/layout/applyDefaultStyles';

‎packages/textkit/tests/layout/layoutParagraph.test.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { describe, test } from 'vitest';
1+
import { describe, expect, test } from 'vitest';
22

33
import layoutParagraph from '../../src/layout/layoutParagraph';
44

@@ -27,5 +27,6 @@ describe('layoutParagraph', () => {
2727
layouter(container, paragraph);
2828

2929
// expect no errors
30+
expect(true).toBe(true);
3031
});
3132
});

‎packages/textkit/tests/rect/bottomLeft.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('rect bottomLeft operator', () => {
1010
expect(coord).toHaveProperty('y', 0);
1111
});
1212

13-
test('should return zero point if no rect provided', () => {
13+
test('should return zero point if empty rect provided', () => {
1414
const coord = bottomLeft(empty());
1515
expect(coord).toHaveProperty('x', 0);
1616
expect(coord).toHaveProperty('y', 0);

‎packages/textkit/tests/rect/bottomRight.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('rect bottomRight operator', () => {
1010
expect(coord).toHaveProperty('y', 0);
1111
});
1212

13-
test('should return zero point if no rect provided', () => {
13+
test('should return zero point if empty rect provided', () => {
1414
const coord = bottomRight(empty());
1515
expect(coord).toHaveProperty('x', 0);
1616
expect(coord).toHaveProperty('y', 0);

0 commit comments

Comments
 (0)