Merge bitcoin/bitcoin#33484: doc: rpc: fix case typo in finalizepsbt help (final_scriptwitness)

fanquake · fanquake · commit d8fe258cd610 · 2025-09-28T18:12:44.000-04:00
ff05beb doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness) (Sebastian Falbesoner) Pull request description: The lower-case spelling matches the `decodepsbt` result field: https://github.com/bitcoin/bitcoin/blob/200150beba6601237036bc01ee10f6a0a2246c3d/src/rpc/rawtransaction.cpp#L871 https://github.com/bitcoin/bitcoin/blob/200150beba6601237036bc01ee10f6a0a2246c3d/src/rpc/rawtransaction.cpp#L1253 ACKs for top commit: l0rinc: ACK ff05beb rkrux: Ah crACK ff05beb Tree-SHA512: c0a0e29e95fed3fcee4df4f3fc87b32774d76bebadcda5aa010bc45142727536d6a71e4c0e70564db8bdb734e8647c80953793ac9ecd6c434345e972f8d9b7b0
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp
@@ -1608,7 +1608,7 @@ static RPCHelpMan finalizepsbt()
     return RPCHelpMan{"finalizepsbt",
                 "Finalize the inputs of a PSBT. If the transaction is fully signed, it will produce a\n"
                 "network serialized transaction which can be broadcast with sendrawtransaction. Otherwise a PSBT will be\n"
-                "created which has the final_scriptSig and final_scriptWitness fields filled for inputs that are complete.\n"
+                "created which has the final_scriptSig and final_scriptwitness fields filled for inputs that are complete.\n"
                 "Implements the Finalizer and Extractor roles.\n",
                 {
                     {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "A base64 string of a PSBT"},

Original file line number	Diff line number	Diff line change
`@@ -1608,7 +1608,7 @@ static RPCHelpMan finalizepsbt()`
`1608`	`1608`	`return RPCHelpMan{"finalizepsbt",`
`1609`	`1609`	`"Finalize the inputs of a PSBT. If the transaction is fully signed, it will produce a\n"`
`1610`	`1610`	`"network serialized transaction which can be broadcast with sendrawtransaction. Otherwise a PSBT will be\n"`
`1611`		`- "created which has the final_scriptSig and final_scriptWitness fields filled for inputs that are complete.\n"`
	`1611`	`+ "created which has the final_scriptSig and final_scriptwitness fields filled for inputs that are complete.\n"`
`1612`	`1612`	`"Implements the Finalizer and Extractor roles.\n",`
`1613`	`1613`	`{`
`1614`	`1614`	`{"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "A base64 string of a PSBT"},`