Replace use of ` in messages by quote_begin (and ' by quote_end)

This continues the work of #4875, but now using quote_begin/quote_end
stream modifiers.

Author: tautschnig

jbmc/regression/jbmc/classpath-invalid/test_jar_warning.desc

@@ -3,7 +3,7 @@ Test
 --classpath ./NotHere.jar
 ^EXIT=6$
 ^SIGNAL=0$
-Warning: failed to access JAR file `./NotHere.jar'
+Warning: failed to access JAR file './NotHere.jar'
 Error: Could not find or load main class Test
 --
 --

jbmc/regression/jbmc/classpath-invalid/test_path_warning.desc

@@ -3,7 +3,7 @@ Test
 --classpath `../../../../scripts/format_classpath.sh ./NotHere .`
 ^EXIT=0$
 ^SIGNAL=0$
-Warning: failed to access directory `./NotHere'
+Warning: failed to access directory './NotHere'
 --
 --
 Note: 'java' does not emit such a warning.

jbmc/src/java_bytecode/java_class_loader_base.cpp

@@ -34,7 +34,8 @@ void java_class_loader_baset::add_classpath_entry(
     }
     else
     {
-      log.warning() << "Warning: failed to access JAR file `" << path << "'"
+      log.warning() << "Warning: failed to access JAR file "
+                    << messaget::quote_begin << path << messaget::quote_end
                     << messaget::eom;
     }
   }
@@ -47,7 +48,8 @@ void java_class_loader_baset::add_classpath_entry(
     }
     else
     {
-      log.warning() << "Warning: failed to access directory `" << path << "'"
+      log.warning() << "Warning: failed to access directory "
+                    << messaget::quote_begin << path << messaget::quote_end
                     << messaget::eom;
     }
   }

regression/goto-cc-file-local/old-flag-name/test.desc

@@ -4,7 +4,7 @@ final-link assertion-check old-flag
 ^EXIT=0$
 ^SIGNAL=0$
 ^VERIFICATION SUCCESSFUL$
-^The `--export-function-local-symbols` flag is deprecated. Please use `--export-file-local-symbols` instead.$
+^The '--export-function-local-symbols' flag is deprecated. Please use '--export-file-local-symbols' instead.$
 --
 ^warning: ignoring
 ^\*\*\*\* WARNING: no body for function

src/ansi-c/c_typecheck_base.cpp

@@ -77,8 +77,9 @@ void c_typecheck_baset::typecheck_symbol(symbolt &symbol)
       // versions of Visual Studio insist to use this in their C library, and
       // GCC just warns as well.
       warning().source_location = symbol.value.find_source_location();
-      warning() << "'extern' symbol '" << new_name
-                << "' should not have an initializer" << eom;
+      warning() << quote_begin << "extern" << quote_end << " symbol "
+                << quote_begin << new_name << quote_end
+                << " should not have an initializer " << eom;
     }
   }
   else if(!is_function && symbol.value.id()==ID_code)

src/ansi-c/c_typecheck_code.cpp

@@ -558,7 +558,8 @@ void c_typecheck_baset::typecheck_switch_case(code_switch_caset &code)
     if(!case_is_allowed)
     {
       error().source_location = code.source_location();
-      error() << "did not expect `case' here" << eom;
+      error() << "did not expect " << quote_begin << "case" << quote_end
+              << " here" << eom;
       throw 0;
     }
 
@@ -575,7 +576,8 @@ void c_typecheck_baset::typecheck_gcc_switch_case_range(
   if(!case_is_allowed)
   {
     error().source_location = code.source_location();
-    error() << "did not expect `case' here" << eom;
+    error() << "did not expect " << quote_begin << "case" << quote_end
+            << " here" << eom;
     throw 0;
   }
 

src/ansi-c/c_typecheck_expr.cpp

@@ -812,8 +812,8 @@ void c_typecheck_baset::typecheck_expr_operands(exprt &expr)
       if(s_it == symbol_table.symbols.end())
       {
         error().source_location = expr.source_location();
-        error() << "failed to find bound symbol `" << identifier
-                << "' in symbol table" << eom;
+        error() << "failed to find bound symbol " << quote_begin << identifier
+                << quote_end << " in symbol table" << eom;
         throw 0;
       }
 

src/cpp/cpp_instantiate_template.cpp

@@ -486,8 +486,8 @@ const symbolt &cpp_typecheckt::instantiate_template(
     if(new_decl.member_spec().is_virtual())
     {
       error().source_location=new_decl.source_location();
-      error() << "invalid use of `virtual' in template declaration"
-              << eom;
+      error() << "invalid use of " << quote_begin << "virtual" << quote_end
+              << " in template declaration" << eom;
       throw 0;
     }
 

src/cpp/cpp_typecheck_expr.cpp

@@ -981,7 +981,8 @@ void cpp_typecheckt::typecheck_expr_this(exprt &expr)
   if(cpp_scopes.current_scope().class_identifier.empty())
   {
     error().source_location=expr.find_source_location();
-    error() << "`this' is not allowed here" << eom;
+    error() << quote_begin << "this" << quote_end << " is not allowed here"
+            << eom;
     throw 0;
   }
 

src/goto-cc/compile.cpp

@@ -662,10 +662,12 @@ compilet::compilet(cmdlinet &_cmdline, message_handlert &mh, bool Werror)
 
   if(cmdline.isset("export-function-local-symbols"))
   {
-    log.warning()
-      << "The `--export-function-local-symbols` flag is deprecated. "
-         "Please use `--export-file-local-symbols` instead."
-      << messaget::eom;
+    log.warning() << "The " << messaget::quote_begin
+                  << "--export-function-local-symbols" << messaget::quote_end
+                  << " flag is deprecated. "
+                     "Please use "
+                  << messaget::quote_begin << "--export-file-local-symbols"
+                  << messaget::quote_end << " instead." << messaget::eom;
   }
 }