Chit.isDisposed() now returns true before calling the runWhenDisposed callbacks. (#3)

Author: nedtwigg

CHANGES.md

@@ -1,6 +1,8 @@
 # DurianRx releases
 
 ## [Unreleased]
+### Fixed
+* `Chit.isDisposed()` now returns true before calling the `runWhenDisposed` callbacks.
 
 ## [3.0.1] - 2019-11-12
 * RxExecutor is now more consistent about failure - if the `onSuccess` throws an exception, it will always be passed to the `onFailure` handler as a `CompletionException`.

src/main/java/com/diffplug/common/rx/Chit.java

@@ -18,6 +18,7 @@
 
 import io.reactivex.disposables.Disposable;
 import java.util.ArrayList;
+import java.util.List;
 
 /**
  * Makes it possible to receive a notification when a resource is disposed.
@@ -34,9 +35,8 @@
 public interface Chit {
 	/**
 	 * Returns whether the resource is disposed. May be called from any thread,
-	 * and may suffer from glitches, but only of the kind where the resource is
-	 * actually disposed but this method incorrectly returns false due to a threading
-	 * glitch which will eventually be resolved.
+	 * and must return true as soon as `dispose()` is called, no matter which thread
+	 * `dispose()` was called from.
 	 */
 	boolean isDisposed();
 
@@ -73,11 +73,15 @@ public final class Settable implements Chit, Disposable {
 		private Settable() {}
 
 		@Override
-		public synchronized void dispose() {
-			if (runWhenDisposed != null) {
-				runWhenDisposed.forEach(Runnable::run);
+		public void dispose() {
+			List<Runnable> toDispose;
+			synchronized (this) {
+				toDispose = runWhenDisposed;
 				runWhenDisposed = null;
 			}
+			if (toDispose != null) {
+				toDispose.forEach(Runnable::run);
+			}
 		}
 
 		@Override