Skip to content

Commit 81a552f

Browse files
author
ntwigg
committed
Don't log URLs because we don't want to leak user data.
1 parent 7941617 commit 81a552f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

natives/mac-deep-link/DeepLinkBridge.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ JNIEXPORT void JNICALL JNI_OnUnload(JavaVM *vm, void *reserved) {
8787
}
8888

8989
static void deliverToJava(NSString *s) {
90-
NSLog(@"[DeepLink] deliverToJava called with URL: %@", s);
90+
NSLog(@"[DeepLink] deliverToJava called with URL");
9191
// These should never be null since we control registration timing
9292
if (!gHandlerClass || !gDeliverMID) {
9393
abortWithMessage(@"JNI handler not initialized - applicationStartBeforeSwt must be called first");
@@ -103,7 +103,7 @@ static void deliverToJava(NSString *s) {
103103
if (utf8) {
104104
jstring jstr = (*env)->NewStringUTF(env, utf8);
105105
if (jstr) {
106-
NSLog(@"[DeepLink] Calling Java deliverURL with: %@", s);
106+
NSLog(@"[DeepLink] Calling Java deliverURL");
107107
(*env)->CallStaticVoidMethod(env, gHandlerClass, gDeliverMID, jstr);
108108
if ((*env)->ExceptionCheck(env)) {
109109
NSLog(@"[DeepLink] Java exception occurred!");
@@ -137,7 +137,7 @@ + (instancetype)sharedHandler {
137137

138138
- (void)handleGetURL:(NSAppleEventDescriptor *)event withReply:(NSAppleEventDescriptor *)reply {
139139
NSString *urlString = [[event paramDescriptorForKeyword:keyDirectObject] stringValue];
140-
NSLog(@"[DeepLink] Apple Event received URL: %@", urlString);
140+
NSLog(@"[DeepLink] Apple Event received URL");
141141
if (urlString.length) {
142142
deliverToJava(urlString);
143143
}
@@ -200,7 +200,7 @@ - (void)application:(NSApplication *)app openURLs:(NSArray<NSURL *> *)urls {
200200
for (NSURL *u in urls) {
201201
if (!u) continue;
202202
NSString *s = u.absoluteString;
203-
NSLog(@"[DeepLink] DPDelegateProxy processing URL: %@", s);
203+
NSLog(@"[DeepLink] DPDelegateProxy processing URL");
204204
if (s.length) deliverToJava(s);
205205
}
206206
}

0 commit comments

Comments
 (0)