Bug 575983 - Stop disposing colors in swt

Cleanup examples.

Change-Id: Ied859cb9edafae8609b47a18aeff52ae3d9e4b09
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/185563
Tested-by: Platform Bot <[email protected]>
Reviewed-by: Alexander Kurtakov <[email protected]>

Author: akurtakov

examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %plugin.SWTStandaloneExampleSet.name
 Bundle-SymbolicName: org.eclipse.swt.examples; singleton:=true
-Bundle-Version: 3.107.0.qualifier
+Bundle-Version: 3.107.100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-11

examples/org.eclipse.swt.examples/pom.xml

@@ -19,6 +19,6 @@
   </parent>
   <groupId>org.eclipse.swt</groupId>
   <artifactId>org.eclipse.swt.examples</artifactId>
-  <version>3.107.0-SNAPSHOT</version>
+  <version>3.107.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 </project>

examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/CTabFolderTab.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2016 IBM Corporation and others.
+ * Copyright (c) 2000, 2021 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -393,23 +393,16 @@ public void showList(CTabFolderEvent event) {
 	@Override
 	void resetColorsAndFonts () {
 		super.resetColorsAndFonts ();
-		Color oldColor = selectionForegroundColor;
 		selectionForegroundColor = null;
 		setSelectionForeground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = selectionBackgroundColor;
 		selectionBackgroundColor = null;
 		setSelectionBackground ();
-		if (oldColor != null) oldColor.dispose();
 		Font oldFont = itemFont;
 		itemFont = null;
 		setItemFont ();
 		if (oldFont != null) oldFont.dispose();
-		oldColor = itemForegroundColor;
 		itemForegroundColor = null;
 		setItemForeground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = itemBackgroundColor;
 		itemBackgroundColor = null;
 		setItemBackground ();
 	}

examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/LinkTab.java

@@ -128,10 +128,8 @@ void setLinkForeground () {
 	@Override
 	void resetColorsAndFonts () {
 		super.resetColorsAndFonts ();
-		Color oldColor = linkForegroundColor;
 		linkForegroundColor = null;
 		setLinkForeground ();
-		if (oldColor != null) oldColor.dispose();
 	}
 
 	@Override

examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/Tab.java

@@ -1622,14 +1622,10 @@ void recreateExampleWidgets () {
 	 * and fonts to default settings as well.
 	 */
 	void resetColorsAndFonts () {
-		Color oldColor = foregroundColor;
 		foregroundColor = null;
 		setExampleWidgetForeground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = backgroundColor;
 		backgroundColor = null;
 		setExampleWidgetBackground ();
-		if (oldColor != null) oldColor.dispose();
 		Font oldFont = font;
 		font = null;
 		setExampleWidgetFont ();

examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TableTab.java

@@ -453,38 +453,26 @@ String getTabText () {
 	@Override
 	void resetColorsAndFonts () {
 		super.resetColorsAndFonts ();
-		Color oldColor = itemForegroundColor;
 		itemForegroundColor = null;
 		setItemForeground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = itemBackgroundColor;
 		itemBackgroundColor = null;
 		setItemBackground ();
-		if (oldColor != null) oldColor.dispose();
 		Font oldFont = font;
 		itemFont = null;
 		setItemFont ();
 		if (oldFont != null) oldFont.dispose();
-		oldColor = cellForegroundColor;
 		cellForegroundColor = null;
 		setCellForeground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = cellBackgroundColor;
 		cellBackgroundColor = null;
 		setCellBackground ();
-		if (oldColor != null) oldColor.dispose();
 		oldFont = font;
 		cellFont = null;
 		setCellFont ();
 		if (oldFont != null) oldFont.dispose();
-		oldColor = headerBackgroundColor;
 		headerBackgroundColor = null;
 		setHeaderBackground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = headerForegroundColor;
 		headerForegroundColor = null;
 		setHeaderForeground ();
-		if (oldColor != null) oldColor.dispose();
 	}
 
 	/**

examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java

@@ -579,38 +579,26 @@ void setColumnsResizable () {
 	@Override
 	void resetColorsAndFonts () {
 		super.resetColorsAndFonts ();
-		Color oldColor = itemForegroundColor;
 		itemForegroundColor = null;
 		setItemForeground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = itemBackgroundColor;
 		itemBackgroundColor = null;
 		setItemBackground ();
-		if (oldColor != null) oldColor.dispose();
 		Font oldFont = font;
 		itemFont = null;
 		setItemFont ();
 		if (oldFont != null) oldFont.dispose();
-		oldColor = cellForegroundColor;
 		cellForegroundColor = null;
 		setCellForeground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = cellBackgroundColor;
 		cellBackgroundColor = null;
 		setCellBackground ();
-		if (oldColor != null) oldColor.dispose();
 		oldFont = font;
 		cellFont = null;
 		setCellFont ();
 		if (oldFont != null) oldFont.dispose();
-		oldColor = headerBackgroundColor;
 		headerBackgroundColor = null;
 		setHeaderBackground ();
-		if (oldColor != null) oldColor.dispose();
-		oldColor = headerForegroundColor;
 		headerForegroundColor = null;
 		setHeaderForeground ();
-		if (oldColor != null) oldColor.dispose();
 
 	}
 

examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/texteditor/TextEditor.java

@@ -1215,15 +1215,10 @@ void releaseResources() {
 
 		if (textFont != null) textFont.dispose();
 		textFont = null;
-		if (textForeground != null) textForeground.dispose();
 		textForeground = null;
-		if (textBackground != null) textBackground.dispose();
 		textBackground = null;
-		if (strikeoutColor != null) strikeoutColor.dispose();
 		strikeoutColor = null;
-		if (underlineColor != null) underlineColor.dispose();
 		underlineColor = null;
-		if (borderColor != null) borderColor.dispose();
 		borderColor = null;
 
 		if (font != null) font.dispose();