Bug 576729 - Reduce NO-OPs for setImage

Removes hotspots in .setImage
Especially for the hot ToolItem.set* (Disabled, Hot)

Requires same (cached) image instances on repeated calls.

Change-Id: If8e470a6ed44608d4e0b4a342f62588acdecc1a2
Signed-off-by: Joerg Kubitz <[email protected]>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186087
Tested-by: Lars Vogel <[email protected]>
Tested-by: Platform Bot <[email protected]>
Reviewed-by: Lars Vogel <[email protected]>

Author: EcljpseB0T

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/MenuItem.java

@@ -704,6 +704,7 @@ public void setID (int id) {
 @Override
 public void setImage (Image image) {
 	checkWidget ();
+	if (this.image == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	super.setImage (image);
 	nsItem.setImage(image != null? image.handle : null);

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/ToolItem.java

@@ -1058,6 +1058,7 @@ public void setEnabled (boolean enabled) {
  */
 public void setDisabledImage (Image image) {
 	checkWidget();
+	if (this.disabledImage == image) return;
 	if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
 	if ((style & SWT.SEPARATOR) != 0) return;
 	disabledImage = image;
@@ -1093,6 +1094,7 @@ boolean setFocus () {
  */
 public void setHotImage (Image image) {
 	checkWidget();
+	if (this.hotImage == image) return;
 	if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
 	if ((style & SWT.SEPARATOR) != 0) return;
 	hotImage = image;
@@ -1102,6 +1104,7 @@ public void setHotImage (Image image) {
 @Override
 public void setImage (Image image) {
 	checkWidget();
+	if (this.image == image) return;
 	if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
 	if ((style & SWT.SEPARATOR) != 0) return;
 	super.setImage (image);

bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/widgets/Item.java

@@ -176,6 +176,7 @@ void releaseWidget () {
  */
 public void setImage (Image image) {
 	checkWidget ();
+	if (this.image == image) return;
 	if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
 	this.image = image;
 }

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/MenuItem.java

@@ -1043,6 +1043,7 @@ public void setImage (Image image) {
 	if (GTK.GTK4) return;
 
 	checkWidget();
+	if (this.image == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	disposeDefaultDisabledImage();
 	super.setImage (image);

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolItem.java

@@ -1106,6 +1106,7 @@ public void setControl (Control control) {
  */
 public void setDisabledImage (Image image) {
 	checkWidget();
+	if (this.disabledImage == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	disabledImage = image;
 	if (image != null) {
@@ -1223,6 +1224,7 @@ void setForegroundRGBA (long handle, GdkRGBA rgba) {
  */
 public void setHotImage (Image image) {
 	checkWidget();
+	if (this.hotImage == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	hotImage = image;
 	if (image != null) {
@@ -1240,6 +1242,7 @@ public void setHotImage (Image image) {
 @Override
 public void setImage (Image image) {
 	checkWidget();
+	if (this.image == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	super.setImage (image);
 	disposeDefault();

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/MenuItem.java

@@ -783,6 +783,7 @@ public void setID (int id) {
 @Override
 public void setImage (Image image) {
 	checkWidget ();
+	if (this.image == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	super.setImage (image);
 	MENUITEMINFO info = new MENUITEMINFO ();

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ToolItem.java

@@ -704,6 +704,7 @@ public void setEnabled (boolean enabled) {
  */
 public void setDisabledImage (Image image) {
 	checkWidget();
+	if (this.disabledImage == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
 	parent.layout(isImageSizeChanged(disabledImage, image));
@@ -730,6 +731,7 @@ public void setDisabledImage (Image image) {
  */
 public void setHotImage (Image image) {
 	checkWidget();
+	if (this.hotImage == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
 	parent.layout(isImageSizeChanged(hotImage, image));
@@ -740,6 +742,7 @@ public void setHotImage (Image image) {
 @Override
 public void setImage (Image image) {
 	checkWidget();
+	if (this.image == image) return;
 	if ((style & SWT.SEPARATOR) != 0) return;
 	if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
 	parent.layout(isImageSizeChanged(super.image, image));