Unregistering a textarea works too.

Author: ntwigg

browser-extension/src/datamodel/textarea-registry.ts

@@ -5,6 +5,14 @@ export class TextareaRegistry {
 
   register<T extends CommentContext>(textareaInfo: TextareaInfo<T>): void {
     this.textareas.set(textareaInfo.element, textareaInfo);
+    // TODO: register as a draft in progress with the global list
+  }
+
+  unregisterDueToModification(textarea: HTMLTextAreaElement): void {
+    if (this.textareas.has(textarea)) {
+      // TODO: register as abandoned or maybe submitted with the global list
+      this.textareas.delete(textarea);
+    }
   }
 
   get(textarea: HTMLTextAreaElement): TextareaInfo<any> | undefined {

browser-extension/src/entrypoints/content.ts

@@ -10,7 +10,7 @@ export default defineContentScript({
   main() {
     const textAreasOnPageLoad = document.querySelectorAll<HTMLTextAreaElement>(`textarea`)
     for (const textarea of textAreasOnPageLoad) {
-      initializeMaybeIsPageload(textarea, true)
+      initializeMaybeIsPageload(textarea)
     }
     const observer = new MutationObserver(handleMutations)
     observer.observe(document.body, {
@@ -25,25 +25,43 @@ export default defineContentScript({
 
 function handleMutations(mutations: MutationRecord[]): void {
   for (const mutation of mutations) {
+    // Handle added nodes
     for (const node of mutation.addedNodes) {
       if (node.nodeType === Node.ELEMENT_NODE) {
         const element = node as Element
         if (element.tagName === 'TEXTAREA') {
-          initializeMaybeIsPageload(element as HTMLTextAreaElement, false)
+          initializeMaybeIsPageload(element as HTMLTextAreaElement)
         }
         // Also check for textareas within added subtrees
         const textareas = element.querySelectorAll?.('textarea')
         if (textareas) {
           for (const textarea of textareas) {
-            initializeMaybeIsPageload(textarea, false)
+            initializeMaybeIsPageload(textarea)
+          }
+        }
+      }
+    }
+
+    // Handle removed nodes
+    for (const node of mutation.removedNodes) {
+      if (node.nodeType === Node.ELEMENT_NODE) {
+        const element = node as Element
+        if (element.tagName === 'TEXTAREA') {
+          textareaRegistry.unregisterDueToModification(element as HTMLTextAreaElement)
+        }
+        // Also check for textareas within removed subtrees
+        const textareas = element.querySelectorAll?.('textarea')
+        if (textareas) {
+          for (const textarea of textareas) {
+            textareaRegistry.unregisterDueToModification(textarea)
           }
         }
       }
     }
   }
 }
 
-function initializeMaybeIsPageload(textarea: HTMLTextAreaElement, isPageload: boolean) {
+function initializeMaybeIsPageload(textarea: HTMLTextAreaElement) {
   // Check if this textarea is already registered
   if (textareaRegistry.get(textarea)) {
     logger.debug('textarea already registered {}', textarea)