Fixup

Author: nedtwigg

browser-extension/tests/corpus-view.ts

@@ -27,7 +27,7 @@ import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import express from 'express'
 import type { Har } from 'har-format'
-import { CORPUS, type CorpusEntry } from './corpus/_corpus-index'
+import { CORPUS } from './corpus/_corpus-index'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const app = express()
@@ -41,7 +41,11 @@ const harCache = new Map<string, Har>()
 
 // Extract URL parts for location patching
 function getUrlParts(key: string) {
-  const originalUrl = CORPUS[key].url
+  const entry = CORPUS[key]
+  if (!entry) {
+    throw new Error(`Corpus entry not found: ${key}`)
+  }
+  const originalUrl = entry.url
   const url = new URL(originalUrl)
   return {
     host: url.host,
@@ -77,7 +81,9 @@ app.get('/', async (_req, res) => {
   try {
     const links = Object.entries(CORPUS)
       .map(([key, entry]) => {
-        const description = entry.description ? `<div style="color: #666; font-size: 0.9em; margin-top: 5px;">${entry.description}</div>` : ''
+        const description = entry.description
+          ? `<div style="color: #666; font-size: 0.9em; margin-top: 5px;">${entry.description}</div>`
+          : ''
         return `
         <li>
           <div style="margin-bottom: 10px;">
@@ -143,14 +149,16 @@ app.get('/', async (_req, res) => {
 // Serve the main page from corpus
 app.get('/corpus/:key/:mode(clean|gitcasso)', async (req, res) => {
   try {
-    const key = req.params.key
-    const mode = req.params.mode as 'clean' | 'gitcasso'
+    // biome-ignore lint/complexity/useLiteralKeys: type comes from path string
+    const key = req.params['key']
+    // biome-ignore lint/complexity/useLiteralKeys: type comes from path string
+    const mode = req.params['mode'] as 'clean' | 'gitcasso'
 
-    if (!(key in CORPUS)) {
+    if (!key || !(key in CORPUS)) {
       return res.status(400).send('Invalid key - not found in CORPUS')
     }
 
-    const entry = CORPUS[key]
+    const entry = CORPUS[key]!
 
     if (entry.type === 'har') {
       // Handle HAR corpus
@@ -216,11 +224,11 @@ app.get('/corpus/:key/:mode(clean|gitcasso)', async (req, res) => {
 app.get('/asset/:key/*', async (req, res) => {
   try {
     const key = req.params.key
-    if (!(key in CORPUS)) {
+    if (!key || !(key in CORPUS)) {
       return res.status(400).send('Invalid key - not found in CORPUS')
     }
 
-    const entry = CORPUS[key]
+    const entry = CORPUS[key]!
     if (entry.type !== 'har') {
       return res.status(400).send('Asset serving only available for HAR corpus')
     }
@@ -528,4 +536,4 @@ function injectGitcassoScript(key: string, html: string) {
     throw error('No closing body tag, nowhere to put the content script!')
   }
   return html.replace('</body>', `${contentScriptTag}</body>`)
-}
+}

browser-extension/tests/corpus/_corpus-index.ts

@@ -9,20 +9,20 @@ export interface CorpusEntry {
 export const CORPUS: Record<string, CorpusEntry> = {
   // HAR corpus (initial page loads)
   gh_issue: {
+    type: 'har',
     url: 'https://github.com/diffplug/selfie/issues/523',
-    type: 'har'
   },
   gh_new_issue: {
+    type: 'har',
     url: 'https://github.com/diffplug/selfie/issues/new',
-    type: 'har'
   },
   gh_new_pr: {
+    type: 'har',
     url: 'https://github.com/diffplug/selfie/compare/main...cavia-porcellus:selfie:main?expand=1',
-    type: 'har'
   },
   gh_pr: {
+    type: 'har',
     url: 'https://github.com/diffplug/selfie/pull/517',
-    type: 'har'
   },
   // HTML corpus (captured after user interactions via SingleFile)
   // Add new entries here as needed, e.g.:
@@ -31,4 +31,4 @@ export const CORPUS: Record<string, CorpusEntry> = {
   //   type: 'html',
   //   description: 'Issue page with comment textarea expanded and preview tab active'
   // }
-} as const
+} as const

browser-extension/tests/har-fixture-utils.ts

@@ -3,7 +3,7 @@ import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import type { Har as HarFile } from 'har-format'
 import { parseHTML } from 'linkedom'
-import { PAGES } from './har/_har-index'
+import { CORPUS } from './corpus/_corpus-index'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
@@ -32,9 +32,13 @@ export interface TestDOMContext {
 let currentDOMInstance: any = null
 let originalGlobals: Partial<TestDOMGlobals> = {}
 
-export async function loadHtmlFromHar(key: keyof typeof PAGES): Promise<string> {
-  const url = PAGES[key]
-  const harPath = path.join(__dirname, 'har', `${key}.har`)
+export async function loadHtmlFromHar(key: keyof typeof CORPUS): Promise<string> {
+  const entry = CORPUS[key]
+  if (!entry || entry.type !== 'har') {
+    throw new Error(`Invalid HAR corpus key: ${String(key)}`)
+  }
+  const url = entry.url
+  const harPath = path.join(__dirname, 'corpus', 'har', `${String(key)}.har`)
   const harContent = await fs.readFile(harPath, 'utf-8')
   const harData: HarFile = JSON.parse(harContent)
   const mainEntry = harData.log.entries.find((entry) => entry.request.url === url)
@@ -101,9 +105,13 @@ export function cleanupDOM(): void {
   }
 }
 
-export async function setupHarDOM(key: keyof typeof PAGES): Promise<TestDOMGlobals> {
+export async function setupHarDOM(key: keyof typeof CORPUS): Promise<TestDOMGlobals> {
   const html = await loadHtmlFromHar(key)
-  const url = PAGES[key]
+  const entry = CORPUS[key]
+  if (!entry || entry.type !== 'har') {
+    throw new Error(`Invalid HAR corpus key: ${String(key)}`)
+  }
+  const url = entry.url
   const domGlobals = createDOMFromHar(html, url)
   setupDOMFromHar(domGlobals)
   return domGlobals

browser-extension/tests/har-fixture.ts

@@ -30,7 +30,7 @@ vi.mock('overtype', () => {
 })
 
 import { describe as baseDescribe, test as baseTest, expect } from 'vitest'
-import type { PAGES } from './har/_har-index'
+import type { CORPUS } from './corpus/_corpus-index'
 import { cleanupDOM, setupHarDOM } from './har-fixture-utils'
 
 export const describe = baseDescribe
@@ -39,10 +39,10 @@ export const describe = baseDescribe
 export { expect }
 
 // Fluent interface for HAR-based tests
-export function usingHar(harKey: keyof typeof PAGES) {
+export function usingHar(harKey: keyof typeof CORPUS) {
   return {
     it: (name: string, fn: () => void | Promise<void>) => {
-      return baseTest(`${harKey}:${name}`, async () => {
+      return baseTest(`${String(harKey)}:${name}`, async () => {
         // Setup HAR DOM before test
         await setupHarDOM(harKey)