Pipe it into tests and prod.

Author: nedtwigg

browser-extension/src/entrypoints/content.ts

@@ -1,5 +1,5 @@
 import { CONFIG } from '../lib/config'
-import type { CommentEvent, CommentSpot } from '../lib/enhancer'
+import type { CommentEvent, CommentSpot, StrippedLocation } from '../lib/enhancer'
 import { logger } from '../lib/logger'
 import { EnhancerRegistry, TextareaRegistry } from '../lib/registries'
 
@@ -9,6 +9,13 @@ const enhancedTextareas = new TextareaRegistry()
 // Expose for debugging in har:view
 ;(window as any).gitcassoTextareaRegistry = enhancedTextareas
 
+function detectLocation(): StrippedLocation {
+  return {
+    domain: window.location.host,
+    pathname: window.location.pathname,
+  }
+}
+
 function sendEventToBackground(type: 'ENHANCED' | 'DESTROYED', spot: CommentSpot): void {
   const message: CommentEvent = {
     spot,
@@ -89,7 +96,7 @@ function enhanceMaybe(textarea: HTMLTextAreaElement) {
   injectStyles()
 
   try {
-    const enhancedTextarea = enhancers.tryToEnhance(textarea)
+    const enhancedTextarea = enhancers.tryToEnhance(textarea, detectLocation())
     if (enhancedTextarea) {
       logger.debug(
         'Identified textarea:',

browser-extension/src/lib/registries.ts

@@ -1,6 +1,6 @@
 import type { OverTypeInstance } from 'overtype'
 import OverType from 'overtype'
-import type { CommentEnhancer, CommentSpot } from './enhancer'
+import type { CommentEnhancer, CommentSpot, StrippedLocation } from './enhancer'
 import { CommentEnhancerMissing } from './enhancers/CommentEnhancerMissing'
 import { GitHubIssueAddCommentEnhancer } from './enhancers/github/githubIssueAddComment'
 import { GitHubIssueNewCommentEnhancer } from './enhancers/github/githubIssueNewComment'
@@ -59,10 +59,10 @@ export class EnhancerRegistry {
     return (this.byType.get(spot.type) || new CommentEnhancerMissing()) as CommentEnhancer<T>
   }
 
-  tryToEnhance(textarea: HTMLTextAreaElement): EnhancedTextarea | null {
+  tryToEnhance(textarea: HTMLTextAreaElement, location: StrippedLocation): EnhancedTextarea | null {
     for (const enhancer of this.enhancers) {
       try {
-        const spot = enhancer.tryToEnhance(textarea)
+        const spot = enhancer.tryToEnhance(textarea, location)
         if (spot) {
           // Prepare enhancer on first use
           if (!this.preparedEnhancers.has(enhancer)) {

browser-extension/tests/lib/enhancers/github.test.ts

@@ -3,14 +3,19 @@ import { describe, expect, usingHar } from '../../har-fixture'
 // must import fixture **first** for mocks, the `expect` keeps biome from changing sort-order
 expect
 
+import type { StrippedLocation } from '@/lib/enhancer'
 import { EnhancerRegistry } from '../../../src/lib/registries'
 
 const enhancers = new EnhancerRegistry()
-function enhancements(document: Document) {
+function enhancements(document: Document, window: Window) {
   const textareas = document.querySelectorAll('textarea')
+  const location: StrippedLocation = {
+    domain: window.location.host,
+    pathname: window.location.pathname,
+  }
   const spotsFound = []
   for (const textarea of textareas) {
-    const enhanced = enhancers.tryToEnhance(textarea)
+    const enhanced = enhancers.tryToEnhance(textarea, location)
     const forValue = `id=${textarea.id} name=${textarea.name} className=${textarea.className}`
     if (enhanced) {
       spotsFound.push({
@@ -31,7 +36,7 @@ function enhancements(document: Document) {
 
 describe('github', () => {
   usingHar('gh_pr').it('should create the correct spot object', async () => {
-    expect(enhancements(document)).toMatchInlineSnapshot(`
+    expect(enhancements(document, window)).toMatchInlineSnapshot(`
       [
         {
           "for": "id=feedback name=feedback className=form-control width-full mb-2",
@@ -66,7 +71,7 @@ describe('github', () => {
     `)
   })
   usingHar('gh_new_pr').it('should create the correct spot object', async () => {
-    expect(enhancements(document)).toMatchInlineSnapshot(`
+    expect(enhancements(document, window)).toMatchInlineSnapshot(`
       [
         {
           "for": "id=feedback name=feedback className=form-control width-full mb-2",
@@ -98,7 +103,7 @@ describe('github', () => {
     `)
   })
   usingHar('gh_issue').it('should create the correct spot object', async () => {
-    expect(enhancements(document)).toMatchInlineSnapshot(`
+    expect(enhancements(document, window)).toMatchInlineSnapshot(`
       [
         {
           "for": "id=feedback name=feedback className=form-control width-full mb-2",
@@ -108,7 +113,7 @@ describe('github', () => {
     `)
   })
   usingHar('gh_new_issue').it('should create the correct spot object', async () => {
-    expect(enhancements(document)).toMatchInlineSnapshot(`
+    expect(enhancements(document, window)).toMatchInlineSnapshot(`
       [
         {
           "for": "id=feedback name=feedback className=form-control width-full mb-2 overtype-input",