Fix all CI stuff.

Author: nedtwigg

browser-extension/tests/lib/enhancers/github.test.ts

@@ -1,27 +1,29 @@
-import { describe, expect, it, vi } from 'vitest'
-import { EnhancerRegistry } from '../../../src/lib/registries'
-import { PAGES } from '../../har-index'
 import fs from 'node:fs/promises'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { parseHTML } from 'linkedom'
+import { describe, expect, it, vi } from 'vitest'
+import { EnhancerRegistry } from '../../../src/lib/registries'
+import { PAGES } from '../../har-index'
 
 vi.stubGlobal('defineContentScript', vi.fn())
 
 vi.mock('../../../src/overtype/overtype', () => {
-  const mockConstructor = vi.fn().mockImplementation(() => [{
-    container: document.createElement('div'),
-    wrapper: document.createElement('div'),
-    textarea: document.createElement('textarea'),
-    preview: document.createElement('div'),
-    getValue: vi.fn(() => ''),
-    setValue: vi.fn(),
-    focus: vi.fn(),
-    destroy: vi.fn()
-  }])
-  mockConstructor.setCodeHighlighter = vi.fn()
+  const mockConstructor = vi.fn().mockImplementation(() => [
+    {
+      container: document.createElement('div'),
+      destroy: vi.fn(),
+      focus: vi.fn(),
+      getValue: vi.fn(() => ''),
+      preview: document.createElement('div'),
+      setValue: vi.fn(),
+      textarea: document.createElement('textarea'),
+      wrapper: document.createElement('div'),
+    },
+  ])
+  ;(mockConstructor as any).setCodeHighlighter = vi.fn()
   return {
-    default: mockConstructor
+    default: mockConstructor,
   }
 })
 
@@ -32,18 +34,19 @@ async function loadHtmlFromHar(key: string): Promise<string> {
   const harContent = await fs.readFile(harPath, 'utf-8')
   const harData = JSON.parse(harContent)
 
-  const mainEntry = harData.log.entries.find((entry: any) => 
-    entry.request.url.includes('github.com') && 
-    entry.response.content.mimeType?.includes('text/html') &&
-    entry.response.content.text
+  const mainEntry = harData.log.entries.find(
+    (entry: any) =>
+      entry.request.url.includes('github.com') &&
+      entry.response.content.mimeType?.includes('text/html') &&
+      entry.response.content.text,
   )
 
   if (!mainEntry) {
     throw new Error(`No HTML content found in HAR file: ${key}.har`)
   }
 
   let html = mainEntry.response.content.text
-  
+
   // Check if content is base64 encoded
   if (mainEntry.response.content.encoding === 'base64') {
     html = Buffer.from(html, 'base64').toString('utf-8')
@@ -55,28 +58,28 @@ async function loadHtmlFromHar(key: string): Promise<string> {
 describe('github', () => {
   it('should identify gh_pr textarea and create proper spot object', async () => {
     const html = await loadHtmlFromHar('gh_pr')
-    
+
     // Parse HTML with linkedom
     const dom = parseHTML(html)
-    
+
     // Replace global document with parsed one
     Object.assign(globalThis, {
       document: dom.document,
       window: {
         ...dom.window,
-        location: new URL(PAGES.gh_pr)
-      }
+        location: new URL(PAGES.gh_pr),
+      },
     })
-    
+
     const enhancers = new EnhancerRegistry()
     const textareas = document.querySelectorAll('textarea')
-    
+
     let enhanced: any = null
     for (const textarea of textareas) {
       enhanced = enhancers.tryToEnhance(textarea as HTMLTextAreaElement)
       if (enhanced) break
     }
-    
+
     expect(enhanced).toBeTruthy()
     expect(enhanced.spot).toMatchInlineSnapshot(`
       {

browser-extension/tests/setup.ts

@@ -15,36 +15,38 @@ const dom = parseHTML(`
 
 // Mock global DOM objects
 Object.assign(globalThis, {
-  window: dom.window,
-  document: dom.document,
   Document: dom.Document,
   DocumentFragment: dom.DocumentFragment,
-  HTMLElement: dom.HTMLElement,
-  HTMLTextAreaElement: dom.HTMLTextAreaElement,
+  document: dom.document,
+  Element: dom.Element,
   HTMLDivElement: dom.HTMLDivElement,
+  HTMLElement: dom.HTMLElement,
   HTMLMetaElement: dom.HTMLMetaElement,
-  Element: dom.Element,
+  HTMLTextAreaElement: dom.HTMLTextAreaElement,
+  location: dom.window.location,
   Node: dom.Node,
   Text: dom.Text,
-  location: dom.window.location
+  window: dom.window,
 })
 
 // Mock querySelector methods properly
 const originalQuerySelector = dom.document.querySelector.bind(dom.document)
 const originalQuerySelectorAll = dom.document.querySelectorAll.bind(dom.document)
 
-dom.document.querySelector = function(selector) {
+dom.document.querySelector = (selector: string) => {
   try {
     return originalQuerySelector(selector)
-  } catch (e) {
+  } catch (_e) {
     return null
   }
 }
 
-dom.document.querySelectorAll = function(selector) {
+dom.document.querySelectorAll = ((selector: string) => {
   try {
     return originalQuerySelectorAll(selector)
-  } catch (e) {
-    return []
+  } catch (_e) {
+    // Return an empty NodeList-like object instead of array
+    const emptyNodeList = document.createDocumentFragment().childNodes
+    return emptyNodeList as unknown as NodeListOf<Element>
   }
-}
+}) as typeof dom.document.querySelectorAll