PR new

Author: WebsByTodd

browser-extension/src/lib/enhancers/github/githubIssueNewComment.ts

@@ -4,27 +4,27 @@ import { logger } from '../../logger'
 import { modifyDOM } from '../modifyDOM'
 import { githubHighlighter } from './githubHighlighter'
 
-interface GitHubIssueAddCommentSpot extends CommentSpot {
+interface GitHubIssueNewCommentSpot extends CommentSpot {
   type: 'GH_ISSUE_NEW_COMMENT'
   domain: string
   slug: string // owner/repo
 }
 
-export class GitHubIssueNewCommentEnhancer implements CommentEnhancer<GitHubIssueAddCommentSpot> {
+export class GitHubIssueNewCommentEnhancer implements CommentEnhancer<GitHubIssueNewCommentSpot> {
   forSpotTypes(): string[] {
     return ['GH_ISSUE_NEW_COMMENT']
   }
 
-  tryToEnhance(_textarea: HTMLTextAreaElement): GitHubIssueAddCommentSpot | null {
+  tryToEnhance(_textarea: HTMLTextAreaElement): GitHubIssueNewCommentSpot | null {
     if (document.querySelector('meta[name="hostname"]')?.getAttribute('content') !== 'github.com') {
       return null
     }
 
     // Parse GitHub URL structure: /owner/repo/issues/123 or /owner/repo/pull/456
-    logger.info(`${this.constructor.name} examing url`, window.location.pathname)
+    logger.debug(`${this.constructor.name} examing url`, window.location.pathname)
 
     const match = window.location.pathname.match(/^\/([^/]+)\/([^/]+)(?:\/issues\/new)/)
-    logger.info(`${this.constructor.name} found match`, window.location.pathname)
+    logger.debug(`${this.constructor.name} found match`, window.location.pathname)
 
     if (!match) return null
     const [, owner, repo] = match
@@ -42,7 +42,7 @@ export class GitHubIssueNewCommentEnhancer implements CommentEnhancer<GitHubIssu
     OverType.setCodeHighlighter(githubHighlighter)
   }
 
-  enhance(textArea: HTMLTextAreaElement, _spot: GitHubIssueAddCommentSpot): OverTypeInstance {
+  enhance(textArea: HTMLTextAreaElement, _spot: GitHubIssueNewCommentSpot): OverTypeInstance {
     const overtypeContainer = modifyDOM(textArea)
     return new OverType(overtypeContainer, {
       autoResize: true,
@@ -52,16 +52,16 @@ export class GitHubIssueNewCommentEnhancer implements CommentEnhancer<GitHubIssu
     })[0]!
   }
 
-  tableTitle(spot: GitHubIssueAddCommentSpot): string {
+  tableTitle(spot: GitHubIssueNewCommentSpot): string {
     const { slug } = spot
     return `${slug} New Issue`
   }
 
-  tableIcon(_: GitHubIssueAddCommentSpot): string {
+  tableIcon(_: GitHubIssueNewCommentSpot): string {
     return '🔄' // PR icon TODO: icon urls in /public
   }
 
-  buildUrl(spot: GitHubIssueAddCommentSpot): string {
+  buildUrl(spot: GitHubIssueNewCommentSpot): string {
     return `https://${spot.domain}/${spot.slug}/issue/new`
   }
 }

browser-extension/src/lib/enhancers/github/githubIssuePRNewComment.ts renamed to browser-extension/src/lib/enhancers/github/githubPRNewComment.ts

@@ -4,36 +4,41 @@ import { logger } from '../../logger'
 import { modifyDOM } from '../modifyDOM'
 import { githubHighlighter } from './githubHighlighter'
 
-interface GitHubIssueAddCommentSpot extends CommentSpot {
-  type: 'GH_ISSUE_NEW_COMMENT'
+interface GitHubPRNewCommentSpot extends CommentSpot {
+  type: 'GH_PR_NEW_COMMENT'
   domain: string
-  slug: string // owner/repo
+  slug: string // owner/repo/base-branch/compare-branch
 }
 
-export class GitHubIssueNewCommentEnhancer implements CommentEnhancer<GitHubIssueAddCommentSpot> {
+export class GitHubPRNewCommentEnhancer implements CommentEnhancer<GitHubPRNewCommentSpot> {
   forSpotTypes(): string[] {
-    return ['GH_ISSUE_NEW_COMMENT']
+    return ['GH_PR_NEW_COMMENT']
   }
 
-  tryToEnhance(_textarea: HTMLTextAreaElement): GitHubIssueAddCommentSpot | null {
+  tryToEnhance(_textarea: HTMLTextAreaElement): GitHubPRNewCommentSpot | null {
     if (document.querySelector('meta[name="hostname"]')?.getAttribute('content') !== 'github.com') {
       return null
     }
 
-    // Parse GitHub URL structure: /owner/repo/issues/123 or /owner/repo/pull/456
+    // /owner/repo/compare/feature/more-enhancers?expand=1
+    // or /owner/repo/compare/feat/issue-static-and-dynamic...feature/more-enhancers?expand=1
     logger.info(`${this.constructor.name} examing url`, window.location.pathname)
 
-    const match = window.location.pathname.match(/^\/([^/]+)\/([^/]+)(?:\/issues\/new)/)
-    logger.info(`${this.constructor.name} found match`, window.location.pathname)
+    const match = window.location.pathname.match(
+      /^\/([^/]+)\/([^/]+)\/compare\/(?:([^.?]+)\.\.\.)?([^?]+)/,
+    )
+    logger.info(`${this.constructor.name} found match`, window.location.pathname, match)
 
     if (!match) return null
-    const [, owner, repo] = match
-    const slug = `${owner}/${repo}`
-    const unique_key = `github.com:${slug}:new`
+    const [, owner, repo, baseBranch, compareBranch] = match
+    const slug = baseBranch
+      ? `${owner}/${repo}/${baseBranch}...${compareBranch}`
+      : `${owner}/${repo}/${compareBranch}`
+    const unique_key = `github.com:${slug}`
     return {
       domain: 'github.com',
       slug,
-      type: 'GH_ISSUE_NEW_COMMENT',
+      type: 'GH_PR_NEW_COMMENT',
       unique_key,
     }
   }
@@ -42,26 +47,26 @@ export class GitHubIssueNewCommentEnhancer implements CommentEnhancer<GitHubIssu
     OverType.setCodeHighlighter(githubHighlighter)
   }
 
-  enhance(textArea: HTMLTextAreaElement, _spot: GitHubIssueAddCommentSpot): OverTypeInstance {
+  enhance(textArea: HTMLTextAreaElement, _spot: GitHubPRNewCommentSpot): OverTypeInstance {
     const overtypeContainer = modifyDOM(textArea)
     return new OverType(overtypeContainer, {
       autoResize: true,
-      minHeight: '400px',
+      minHeight: '250px',
       padding: 'var(--base-size-16)',
       placeholder: 'Type your description here...',
     })[0]!
   }
 
-  tableTitle(spot: GitHubIssueAddCommentSpot): string {
+  tableTitle(spot: GitHubPRNewCommentSpot): string {
     const { slug } = spot
     return `${slug} New Issue`
   }
 
-  tableIcon(_: GitHubIssueAddCommentSpot): string {
+  tableIcon(_: GitHubPRNewCommentSpot): string {
     return '🔄' // PR icon TODO: icon urls in /public
   }
 
-  buildUrl(spot: GitHubIssueAddCommentSpot): string {
+  buildUrl(spot: GitHubPRNewCommentSpot): string {
     return `https://${spot.domain}/${spot.slug}/issue/new`
   }
 }

browser-extension/src/lib/logger.ts

@@ -19,6 +19,10 @@ const LOG_LEVEL_PRIORITY: Record<LogLevel, number> = {
 
 // Helper function to check if a log level is enabled
 const shouldLog = (level: LogLevel): boolean => {
+  // Don't log anything in production mode
+  if (CONFIG.MODE === 'PROD') {
+    return false
+  }
   return LOG_LEVEL_PRIORITY[level] >= LOG_LEVEL_PRIORITY[CONFIG.LOG_LEVEL]
 }
 

browser-extension/src/lib/registries.ts

@@ -3,6 +3,7 @@ import type { CommentEnhancer, CommentSpot } from './enhancer'
 import { GitHubIssueAddCommentEnhancer } from './enhancers/github/githubIssueAddComment'
 import { GitHubIssueNewCommentEnhancer } from './enhancers/github/githubIssueNewComment'
 import { GitHubPRAddCommentEnhancer } from './enhancers/github/githubPRAddComment'
+import { GitHubPRNewCommentEnhancer } from './enhancers/github/githubPRNewComment'
 
 export interface EnhancedTextarea<T extends CommentSpot = CommentSpot> {
   textarea: HTMLTextAreaElement
@@ -19,8 +20,9 @@ export class EnhancerRegistry {
   constructor() {
     // Register all available handlers
     this.register(new GitHubIssueAddCommentEnhancer())
-    this.register(new GitHubPRAddCommentEnhancer())
     this.register(new GitHubIssueNewCommentEnhancer())
+    this.register(new GitHubPRAddCommentEnhancer())
+    this.register(new GitHubPRNewCommentEnhancer())
   }
 
   private register<T extends CommentSpot>(enhancer: CommentEnhancer<T>): void {