More renames.

Author: ntwigg

browser-extension/src/datamodel/enhancer.ts

@@ -11,16 +11,16 @@ export interface CommentSpot {
 }
 
 /** wraps the textareas of a given platform with Gitcasso's enhancements */
-export interface CommentEnhancer<T extends CommentSpot = CommentSpot> {
+export interface CommentEnhancer<Spot extends CommentSpot = CommentSpot> {
   /** guarantees to only return a type within this list */
   forCommentTypes(): string[]
   /**
    * whenever a new `textarea` is added to any webpage, this method is called.
    * if we return non-null, then we become the handler for that text area.
    */
-  tryToEnhance(textarea: HTMLTextAreaElement): [OverType, T] | null
+  tryToEnhance(textarea: HTMLTextAreaElement): [OverType, Spot] | null
 
-  generateIcon(context: T): string
-  generateDisplayTitle(context: T): string
-  buildUrl(context: T, withDraft?: boolean): string
+  generateIcon(spot: Spot): string
+  generateDisplayTitle(spot: Spot): string
+  buildUrl(spot: Spot): string
 }

…src/datamodel/handlers/github-handler.ts …ension/src/datamodel/enhancers/github.tsbrowser-extension/src/datamodel/handlers/github-handler.ts renamed to browser-extension/src/datamodel/enhancers/github.ts browser-extension/src/datamodel/handlers/github-handler.ts renamed to browser-extension/src/datamodel/enhancers/github.ts

@@ -22,7 +22,7 @@ export interface GitHubSpot extends CommentSpot {
   number?: number | undefined // issue/PR number, undefined for new issues and PRs
 }
 
-export class GitHubHandler implements CommentEnhancer<GitHubSpot> {
+export class GitHubEnhancer implements CommentEnhancer<GitHubSpot> {
   forCommentTypes(): string[] {
     return [...GITHUB_COMMENT_TYPES]
   }

browser-extension/src/datamodel/registries.ts

@@ -1,6 +1,6 @@
 import type { OverType } from '../overtype/mock-overtype'
 import type { CommentEnhancer, CommentSpot } from './enhancer'
-import { GitHubHandler as GitHubEnhancer } from './handlers/github-handler'
+import { GitHubEnhancer } from './enhancers/github'
 
 export interface EnhancedTextarea<T extends CommentSpot = CommentSpot> {
   element: HTMLTextAreaElement