Same thing for ui

Author: nedtwigg

tests/corpus-fixture.ts

@@ -41,7 +41,7 @@ export const describe = baseDescribe
 export { expect }
 
 // Helper function for detection tests
-export function getDetectionResults(document: Document, window: Window) {
+export function getDetectionResults() {
   const enhancers = new EnhancerRegistry()
   const textareas = document.querySelectorAll('textarea')
   const location: StrippedLocation = {
@@ -60,6 +60,35 @@ export function getDetectionResults(document: Document, window: Window) {
   return detectionResults
 }
 
+// Helper function for UI tests
+export function getUIResults() {
+  const enhancers = new EnhancerRegistry()
+  const textareas = document.querySelectorAll('textarea')
+  const location: StrippedLocation = {
+    host: window.location.host,
+    pathname: window.location.pathname,
+  }
+  const uiResults = []
+  for (const textarea of textareas) {
+    const enhanced = enhancers.tryToEnhance(textarea, location)
+    const forValue = `id=${textarea.id} name=${textarea.name} className=${textarea.className}`
+    if (enhanced) {
+      uiResults.push({
+        for: forValue,
+        title: enhanced.enhancer.tableTitle(enhanced.spot),
+        upperDecoration: enhanced.enhancer.tableUpperDecoration(enhanced.spot),
+      })
+    } else {
+      uiResults.push({
+        for: forValue,
+        title: null,
+        upperDecoration: null,
+      })
+    }
+  }
+  return uiResults
+}
+
 // Fluent interface for any corpus type (HAR or HTML)
 export function withCorpus(corpusKey: keyof typeof CORPUS) {
   return {

tests/lib/enhancers/gh_detection.test.ts

@@ -7,7 +7,7 @@ const githubCorpusEntries = Object.keys(CORPUS).filter((key) => key.startsWith('
 describe('github detection', () => {
   for (const corpusKey of githubCorpusEntries) {
     withCorpus(corpusKey as keyof typeof CORPUS).it('should detect correct spots', async () => {
-      expect(getDetectionResults(document, window)).toMatchSnapshot()
+      expect(getDetectionResults()).toMatchSnapshot()
     })
   }
 })

tests/lib/enhancers/gh_ui.test.ts

@@ -1,40 +1,9 @@
-import { describe, expect, withCorpus } from '../../corpus-fixture'
+import { describe, expect, getUIResults, withCorpus } from '../../corpus-fixture'
 
 expect
 
-import type { StrippedLocation } from '@/lib/enhancer'
-import { EnhancerRegistry } from '../../../src/lib/registries'
 import { CORPUS } from '../../corpus/_corpus-index'
 
-const enhancers = new EnhancerRegistry()
-
-function getUIResults(document: Document, window: Window) {
-  const textareas = document.querySelectorAll('textarea')
-  const location: StrippedLocation = {
-    host: window.location.host,
-    pathname: window.location.pathname,
-  }
-  const uiResults = []
-  for (const textarea of textareas) {
-    const enhanced = enhancers.tryToEnhance(textarea, location)
-    const forValue = `id=${textarea.id} name=${textarea.name} className=${textarea.className}`
-    if (enhanced) {
-      uiResults.push({
-        for: forValue,
-        title: enhanced.enhancer.tableTitle(enhanced.spot),
-        upperDecoration: enhanced.enhancer.tableUpperDecoration(enhanced.spot),
-      })
-    } else {
-      uiResults.push({
-        for: forValue,
-        title: null,
-        upperDecoration: null,
-      })
-    }
-  }
-  return uiResults
-}
-
 // Get all corpus entries that start with 'gh_'
 const githubCorpusEntries = Object.keys(CORPUS).filter((key) => key.startsWith('gh_'))
 
@@ -43,7 +12,7 @@ describe('github ui', () => {
     withCorpus(
       corpusKey as keyof typeof CORPUS,
     ).it('should render correct UI elements', async () => {
-      expect(getUIResults(document, window)).toMatchSnapshot()
+      expect(getUIResults()).toMatchSnapshot()
     })
   }
 })