Move type from TextareaInfo into CommentContext.

Author: ntwigg

browser-extension/src/datamodel/textarea-handler.ts

@@ -1,11 +1,11 @@
 
 export interface CommentContext {
   unique_key: string;
+  type: string;
 }
 
 export interface TextareaInfo<T extends CommentContext = CommentContext> {
   element: HTMLTextAreaElement;
-  type: string;
   context: T;
 }
 
@@ -14,14 +14,10 @@ export interface TextareaHandler<T extends CommentContext = CommentContext> {
   forCommentTypes(): string[];
   // whenever a new `textarea` is added to any webpage, this method is called to try to find a handler for it
   identifyContextOf(textarea: HTMLTextAreaElement): TextareaInfo | null;
-    
-  // Context extraction
-  extractContext(textarea: HTMLTextAreaElement): T | null;
-  determineType(textarea: HTMLTextAreaElement): string | null;
 
   // Popup functionality helpers
   generateDisplayTitle(context: T): string;
-  generateIcon(type: string): string;
+  generateIcon(context: T): string;
   buildUrl(context: T, withDraft?: boolean): string;
 }
 

browser-extension/src/entrypoints/content.ts

@@ -51,7 +51,7 @@ function initializeMaybe(textarea: HTMLTextAreaElement) {
     // Use registry to identify and handle this specific textarea
     const textareaInfo = registry.identifyTextarea(textarea)
     if (textareaInfo) {
-      logger.debug('Identified textarea:', textareaInfo.type, textareaInfo.context.unique_key)
+      logger.debug('Identified textarea:', textareaInfo.context.type, textareaInfo.context.unique_key)
       // TODO: Set up textarea monitoring and draft saving
     } else {
       logger.debug('No handler found for textarea')

browser-extension/src/handlers/github-handler.ts

@@ -40,14 +40,14 @@ export class GitHubHandler implements TextareaHandler<GitHubContext> {
     const context = this.extractContext(textarea);
 
     if (type && context) {
-      return { element: textarea, type, context };
+      return { element: textarea, context: { ...context, type } };
     }
 
     return null;
   }
 
 
-  extractContext(textarea: HTMLTextAreaElement): GitHubContext | null {
+  private extractContext(textarea: HTMLTextAreaElement): GitHubContext | null {
     const pathname = window.location.pathname;
 
     // Parse GitHub URL structure: /owner/repo/issues/123 or /owner/repo/pull/456
@@ -74,14 +74,15 @@ export class GitHubHandler implements TextareaHandler<GitHubContext> {
 
     return {
       unique_key,
+      type: '', // Will be set by caller
       domain: window.location.hostname,
       slug,
       number,
       commentId: commentId || undefined
     };
   }
 
-  determineType(textarea: HTMLTextAreaElement): GitHubCommentType | null {
+  private determineType(textarea: HTMLTextAreaElement): GitHubCommentType | null {
     const pathname = window.location.pathname;
 
     // New issue
@@ -130,8 +131,8 @@ export class GitHubHandler implements TextareaHandler<GitHubContext> {
     return `New ${window.location.pathname.includes('/issues/') ? 'issue' : 'PR'} in ${slug}`;
   }
 
-  generateIcon(type: string): string {
-    switch (type) {
+  generateIcon(context: GitHubContext): string {
+    switch (context.type) {
       case 'GH_ISSUE_NEW':
       case 'GH_ISSUE_ADD_COMMENT':
       case 'GH_ISSUE_EDIT_COMMENT':

browser-extension/src/handlers/reddit-handler.ts

@@ -31,14 +31,14 @@ export class RedditHandler implements TextareaHandler<RedditContext> {
     const context = this.extractContext(textarea);
 
     if (type && context) {
-      return { element: textarea, type, context };
+      return { element: textarea, context: { ...context, type } };
     }
 
     return null;
   }
 
 
-  extractContext(textarea: HTMLTextAreaElement): RedditContext | null {
+  private extractContext(textarea: HTMLTextAreaElement): RedditContext | null {
     const pathname = window.location.pathname;
 
     // Parse Reddit URL structure: /r/subreddit/comments/postid/title/
@@ -77,13 +77,14 @@ export class RedditHandler implements TextareaHandler<RedditContext> {
 
     return {
       unique_key,
+      type: '', // Will be set by caller
       subreddit,
       postId,
       commentId: commentId || undefined
     };
   }
 
-  determineType(textarea: HTMLTextAreaElement): RedditCommentType | null {
+  private determineType(textarea: HTMLTextAreaElement): RedditCommentType | null {
     const pathname = window.location.pathname;
 
     // New post submission
@@ -114,8 +115,8 @@ export class RedditHandler implements TextareaHandler<RedditContext> {
     return `New post in r/${subreddit}`;
   }
 
-  generateIcon(type: string): string {
-    switch (type) {
+  generateIcon(context: RedditContext): string {
+    switch (context.type) {
       case 'REDDIT_POST_NEW':
         return '📝'; // Post icon
       case 'REDDIT_COMMENT_NEW':