More cleanup.

Author: ntwigg

browser-extension/src/datamodel/enhancer.ts

@@ -13,7 +13,7 @@ export interface CommentSpot {
 /** wraps the textareas of a given platform with Gitcasso's enhancements */
 export interface CommentEnhancer<Spot extends CommentSpot = CommentSpot> {
   /** guarantees to only return a type within this list */
-  forCommentTypes(): string[]
+  forSpotTypes(): string[]
   /**
    * whenever a new `textarea` is added to any webpage, this method is called.
    * if we return non-null, then we become the handler for that text area.

browser-extension/src/datamodel/enhancers/github.ts

@@ -23,7 +23,7 @@ export interface GitHubSpot extends CommentSpot {
 }
 
 export class GitHubEnhancer implements CommentEnhancer<GitHubSpot> {
-  forCommentTypes(): string[] {
+  forSpotTypes(): string[] {
     return [...GITHUB_COMMENT_TYPES]
   }
 

browser-extension/src/datamodel/registries.ts

@@ -21,15 +21,6 @@ export class EnhancerRegistry {
     this.enhancers.add(handler)
   }
 
-  getHandlerForType(type: string): CommentEnhancer<any> | null {
-    for (const handler of this.enhancers) {
-      if (handler.forCommentTypes().includes(type)) {
-        return handler
-      }
-    }
-    return null
-  }
-
   tryToEnhance(textarea: HTMLTextAreaElement): EnhancedTextarea<any> | null {
     for (const handler of this.enhancers) {
       try {
@@ -45,12 +36,8 @@ export class EnhancerRegistry {
     return null
   }
 
-  getAllHandlers(): CommentEnhancer<any>[] {
-    return Array.from(this.enhancers)
-  }
-
-  getCommentTypesForHandler(handler: CommentEnhancer<any>): string[] {
-    return handler.forCommentTypes()
+  getEnhancerCount(): number {
+    return this.enhancers.size
   }
 }
 

browser-extension/src/entrypoints/content.ts

@@ -16,7 +16,7 @@ export default defineContentScript({
       childList: true,
       subtree: true,
     })
-    logger.debug('Extension loaded with', enhancers.getAllHandlers().length, 'handlers')
+    logger.debug('Extension loaded with', enhancers.getEnhancerCount, 'handlers')
   },
   matches: ['<all_urls>'],
   runAt: 'document_end',