better har integration

Author: nedtwigg

browser-extension/tests/lib/enhancers/github.test.ts

@@ -1,6 +1,6 @@
 import { vi } from 'vitest'
 import { EnhancerRegistry } from '../../../src/lib/registries'
-import { describe, expect, it } from '../../test-fixtures'
+import { describe, expect, usingHar } from '../../test-fixtures'
 
 vi.stubGlobal('defineContentScript', vi.fn())
 vi.mock('../../../src/overtype/overtype', () => {
@@ -23,10 +23,7 @@ vi.mock('../../../src/overtype/overtype', () => {
 })
 
 describe('github', () => {
-  it('should identify gh_pr textarea and create proper spot object', async ({ harDOM }) => {
-    // Setup DOM from HAR snapshot
-    await harDOM('gh_pr')
-
+  usingHar('gh_pr').it('should identify gh_pr textarea and create proper spot object', async () => {
     const enhancers = new EnhancerRegistry()
     const textareas = document.querySelectorAll('textarea')
 

browser-extension/tests/test-fixtures.ts

@@ -51,3 +51,54 @@ export const it = test
 
 // Re-export expect from vitest
 export { expect }
+
+// Fluent interface for HAR-based tests
+export function usingHar(harKey: keyof typeof PAGES) {
+  // Create a test with auto-setup fixture for this HAR
+  const harTest = baseTest.extend<TestFixtures & { _harAutoSetup: undefined }>({
+    // Auto-setup fixture that runs the HAR setup automatically
+    _harAutoSetup: [
+      async ({ harDOM }, use) => {
+        await harDOM(harKey)
+        await use(undefined)
+      },
+      { auto: true },
+    ],
+    // Keep the original harDOM fixture
+    // biome-ignore lint/correctness/noEmptyPattern: Required by Vitest fixture API
+    harDOM: async ({}, use) => {
+      let currentDOM: TestDOMGlobals | null = null
+
+      const setupDOM = async (key: keyof typeof PAGES): Promise<TestDOMGlobals> => {
+        if (currentDOM) {
+          cleanupDOM()
+        }
+        const html = await loadHtmlFromHar(key)
+        const url = PAGES[key]
+        const domGlobals = createDOMFromHar(html, url)
+        setupDOMFromHar(domGlobals)
+        currentDOM = domGlobals
+        return domGlobals
+      }
+
+      await use(setupDOM)
+
+      if (currentDOM) {
+        cleanupDOM()
+        currentDOM = null
+      }
+    },
+  })
+
+  return {
+    describe: (name: string, fn: () => void) => {
+      return baseDescribe(name, fn)
+    },
+
+    it: (name: string, fn: () => void | Promise<void>) => {
+      return harTest(name, async () => {
+        return await fn()
+      })
+    },
+  }
+}