When editing an existing comment, the necessary padding is different for issues than for prs. Also we weren't editing non-root comments on PRs, now we are.

Author: nedtwigg

src/lib/enhancers/github/GitHubEditEnhancer.tsx

@@ -8,6 +8,7 @@ import { commonGitHubOptions, prepareGitHubHighlighter } from './github-common'
 const GH_EDIT = 'GH_EDIT' as const
 
 export interface GitHubEditSpot extends CommentSpot {
+  isIssue: boolean
   type: typeof GH_EDIT
 }
 
@@ -22,9 +23,10 @@ export class GitHubEditEnhancer implements CommentEnhancer<GitHubEditSpot> {
     }
 
     // Only enhance textareas that are for editing issue/PR body
-    const isIssueBodyEdit = textarea.closest('.react-issue-body')
+    const isIssueBodyEdit = textarea.closest('.react-issue-body') // this works for root and appended comments
     const isPRBodyEdit =
-      textarea.id?.match(/^issue-\d+-body$/) || textarea.name === 'pull_request[body]'
+      textarea.name === 'pull_request[body]' || textarea.name === 'issue_comment[body]'
+    //                   ^this is the root pr comment              ^this is the other pr comments (surprising!)
 
     if (!isIssueBodyEdit && !isPRBodyEdit) {
       return null
@@ -42,20 +44,23 @@ export class GitHubEditEnhancer implements CommentEnhancer<GitHubEditSpot> {
 
     logger.debug(`${this.constructor.name} enhanced issue/PR body textarea`, unique_key)
     return {
+      isIssue: !!isIssueBodyEdit,
       type: GH_EDIT,
       unique_key,
     }
   }
 
-  enhance(textArea: HTMLTextAreaElement, _spot: GitHubEditSpot): OverTypeInstance {
+  enhance(textArea: HTMLTextAreaElement, spot: GitHubEditSpot): OverTypeInstance {
     prepareGitHubHighlighter()
     const overtypeContainer = modifyDOM(textArea)
-    return new OverType(overtypeContainer, {
+    const overtype = new OverType(overtypeContainer, {
       ...commonGitHubOptions,
-      minHeight: '102px',
-      padding: 'var(--base-size-8)',
-      placeholder: 'Add your comment here...',
+      padding: spot.isIssue ? 'var(--base-size-16)' : 'var(--base-size-8)',
     })[0]!
+    if (!spot.isIssue) {
+      // TODO: autoheight not working
+    }
+    return overtype
   }
 
   tableUpperDecoration(_spot: GitHubEditSpot): React.ReactNode {

tests/lib/enhancers/__snapshots__/gh-detection.test.ts.snap

@@ -21,6 +21,7 @@ exports[`github detection > gh_issue_edit:should detect correct spots 1`] = `
   {
     "for": "id=:rc3: name=null className=prc-Textarea-TextArea-13q4j focus-visible overtype-input",
     "spot": {
+      "isIssue": true,
       "type": "GH_EDIT",
       "unique_key": "github.com:diffplug/gitcasso:56:edit-body",
     },
@@ -80,6 +81,7 @@ exports[`github detection > gh_pr_edit:should detect correct spots 1`] = `
   {
     "for": "id=issue-3429313834-body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit js-size-to-fit size-to-fit js-session-resumable CommentBox-input FormControl-textarea js-saved-reply-shortcut-comment-field focus-visible overtype-input",
     "spot": {
+      "isIssue": false,
       "type": "GH_EDIT",
       "unique_key": "github.com:diffplug/gitcasso:58:edit-body",
     },