Remove the infrastructure for prepareForFirstEnhancement()

Author: nedtwigg

src/lib/enhancer.ts

@@ -37,12 +37,8 @@ export interface CommentEnhancer<Spot extends CommentSpot = CommentSpot> {
    * If we return non-null, then we become the handler for that text area.
    */
   tryToEnhance(textarea: HTMLTextAreaElement, location: StrippedLocation): Spot | null
-  /** This gets called the first time that `tryToEnhance` returns non-null. */
-  prepareForFirstEnhancement(): void
   /**
    * If `tryToEnhance` returns non-null, then this gets called.
-   * It is guaranteed that `prepareForFirstEnhancement` has been called
-   * exactly once since pageload before this gets called.
    */
   enhance(textarea: HTMLTextAreaElement, spot: Spot): OverTypeInstance
   /** Returns a ReactNode which will be displayed in the table row. */

src/lib/enhancers/CommentEnhancerMissing.tsx

@@ -43,9 +43,6 @@ export class CommentEnhancerMissing implements CommentEnhancer {
   tryToEnhance(_textarea: HTMLTextAreaElement, _location: StrippedLocation): CommentSpot | null {
     throw new Error('Method not implemented.')
   }
-  prepareForFirstEnhancement(): void {
-    throw new Error('Method not implemented.')
-  }
   enhance(_textarea: HTMLTextAreaElement, _spot: CommentSpot): OverTypeInstance {
     throw new Error('Method not implemented.')
   }

src/lib/registries.ts

@@ -17,7 +17,6 @@ export interface EnhancedTextarea<T extends CommentSpot = CommentSpot> {
 
 export class EnhancerRegistry {
   private enhancers = new Set<CommentEnhancer>()
-  private preparedEnhancers = new Set<CommentEnhancer>()
   byType = new Map<string, CommentEnhancer>()
 
   constructor() {
@@ -66,11 +65,6 @@ export class EnhancerRegistry {
       try {
         const spot = enhancer.tryToEnhance(textarea, location)
         if (spot) {
-          // Prepare enhancer on first use
-          if (!this.preparedEnhancers.has(enhancer)) {
-            enhancer.prepareForFirstEnhancement()
-            this.preparedEnhancers.add(enhancer)
-          }
           const overtype = enhancer.enhance(textarea, spot)
           this.handleDelayedValueInjection(overtype)
           return { enhancer, overtype, spot, textarea }