Ask for help with pythong

Author: nedtwigg

python/example-pytest-selfie/tests/binary_test.py

@@ -41,7 +41,7 @@ def test_binary_file_duplicate_unequal():
             "tests/binary_test__test_binary_file_duplicate_unequal.bin"
         )
     expect_selfie(safify(str(exc_info.value))).to_be(
-        "Snapshot mismatch, TODO: string comparison"
+        "Snapshot mismatch (error msg could be better https://github.com/diffplug/selfie/issues/501)"
     )
 
 
@@ -65,7 +65,7 @@ def test_base64_mismatch():
     with pytest.raises(Exception) as exc_info:
         expect_selfie(b"test data").to_be_base64("AAAA")
     expect_selfie(safify(str(exc_info.value))).to_be(
-        "Snapshot mismatch, TODO: string comparison"
+        "Snapshot mismatch (error msg could be better https://github.com/diffplug/selfie/issues/501)"
     )
 
 

python/selfie-lib/selfie_lib/SnapshotSystem.py

@@ -125,7 +125,7 @@ def msg_snapshot_not_found_no_such_file(self, file) -> str:
         return self.msg(f"Snapshot not found: no such file {file}")
 
     def msg_snapshot_mismatch(self, expected: str, actual: str) -> str:  # noqa: ARG002
-        return self.msg("Snapshot mismatch, TODO: string comparison")
+        return self.msg("Snapshot mismatch (error msg could be better https://github.com/diffplug/selfie/issues/501)")
 
     def msg_snapshot_mismatch_binary(self, expected: bytes, actual: bytes) -> str:
         return self.msg_snapshot_mismatch(