Prefer a provider to access the CI environment variable

mches · mches · commit 0d3f519da4d9 · 2024-04-01T08:40:00.000-07:00
diff --git a/settings.gradle b/settings.gradle
@@ -60,12 +60,10 @@ if (System.env['CI'] != null) {
 }
 
 gradleEnterprise {
-	if (System.env['CI'] != null) {
-		buildScan {
-			termsOfServiceUrl = "https://gradle.com/terms-of-service"
-			termsOfServiceAgree = "yes"
-			publishAlways()
-		}
+	buildScan {
+		termsOfServiceUrl = "https://gradle.com/terms-of-service"
+		termsOfServiceAgree = "yes"
+		publishAlways(providers.environmentVariable('CI').present)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -60,12 +60,10 @@ if (System.env['CI'] != null) {`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`gradleEnterprise {`
`63`		`- if (System.env['CI'] != null) {`
`64`		`- buildScan {`
`65`		`- termsOfServiceUrl = "https://gradle.com/terms-of-service"`
`66`		`- termsOfServiceAgree = "yes"`
`67`		`- publishAlways()`
`68`		`- }`
	`63`	`+ buildScan {`
	`64`	`+ termsOfServiceUrl = "https://gradle.com/terms-of-service"`
	`65`	`+ termsOfServiceAgree = "yes"`
	`66`	`+ publishAlways(providers.environmentVariable('CI').present)`
`69`	`67`	`}`
`70`	`68`	`}`
`71`	`69`