1162: adding tests verifying issue

results in 'Couldn't resolve parser "php"' on gradle side and 'Couldn't resolve parser "java"' on maven side

Author: simschla

plugin-gradle/src/test/java/com/diffplug/gradle/spotless/PrettierIntegrationTest.java

@@ -183,6 +183,48 @@ void usePhpCommunityPlugin() throws IOException {
 		assertFile("php-example.php").sameAsResource("npm/prettier/plugins/php.clean");
 	}
 
+	/**
+	 * This test is to ensure that we can have multiple prettier instances in one spotless config.
+	 *
+	 * @see <a href="https://github.com/diffplug/spotless/issues/1162">Issue #1162 on github</a>
+	 */
+	@Test
+	void usePhpAndJavaCommunityPlugin() throws IOException {
+		setFile("build.gradle").toLines(
+				"plugins {",
+				"    id 'com.diffplug.spotless'",
+				"}",
+				"repositories { mavenCentral() }",
+				"def prettierConfigPhp = [:]",
+				"prettierConfigPhp['tabWidth'] = 3",
+				"prettierConfigPhp['parser'] = 'php'",
+				"def prettierPackagesPhp = [:]",
+				"prettierPackagesPhp['prettier'] = '2.0.5'",
+				"prettierPackagesPhp['@prettier/plugin-php'] = '0.14.2'",
+				"def prettierConfigJava = [:]",
+				"prettierConfigJava['tabWidth'] = 4",
+				"prettierConfigJava['parser'] = 'java'",
+				"def prettierPackagesJava = [:]",
+				"prettierPackagesJava['prettier'] = '2.0.5'",
+				"prettierPackagesJava['prettier-plugin-java'] = '0.8.0'",
+				"spotless {",
+				"    format 'php', {",
+				"        target 'php-example.php'",
+				"        prettier(prettierPackagesPhp).config(prettierConfigPhp)",
+				"    }",
+				"    java {",
+				"        target 'JavaTest.java'",
+				"        prettier(prettierPackagesJava).config(prettierConfigJava)",
+				"    }",
+				"}");
+		setFile("php-example.php").toResource("npm/prettier/plugins/php.dirty");
+		setFile("JavaTest.java").toResource("npm/prettier/plugins/java-test.dirty");
+		final BuildResult spotlessApply = gradleRunner().withArguments("--stacktrace", "spotlessApply").build();
+		Assertions.assertThat(spotlessApply.getOutput()).contains("BUILD SUCCESSFUL");
+		assertFile("php-example.php").sameAsResource("npm/prettier/plugins/php.clean");
+		assertFile("JavaTest.java").sameAsResource("npm/prettier/plugins/java-test.clean");
+	}
+
 	@Test
 	void autodetectNpmrcFileConfig() throws IOException {
 		setFile(".npmrc").toLines(

plugin-maven/src/test/java/com/diffplug/spotless/maven/MavenIntegrationHarness.java

@@ -285,7 +285,7 @@ private static String getSystemProperty(String name) {
 		return value;
 	}
 
-	private static String[] groupWithSteps(String group, String[] includes, String... steps) {
+	protected static String[] groupWithSteps(String group, String[] includes, String... steps) {
 		String[] result = new String[steps.length + includes.length + 2];
 		result[0] = "<" + group + ">";
 		System.arraycopy(includes, 0, result, 1, includes.length);
@@ -294,15 +294,22 @@ private static String[] groupWithSteps(String group, String[] includes, String..
 		return result;
 	}
 
-	private static String[] groupWithSteps(String group, String... steps) {
+	protected static String[] groupWithSteps(String group, String... steps) {
 		return groupWithSteps(group, new String[]{}, steps);
 	}
 
-	private static String[] including(String... includes) {
+	protected static String[] including(String... includes) {
 		return groupWithSteps("includes", groupWithSteps("include", includes));
 	}
 
-	private static String[] formats(String... formats) {
+	protected static String[] formats(String... formats) {
 		return groupWithSteps("formats", formats);
 	}
+
+	protected static String[] formats(String[]... formats) {
+		String[] formatsArray = Arrays.stream(formats)
+				.flatMap(Arrays::stream)
+				.toArray(String[]::new);
+		return formats(formatsArray);
+	}
 }

plugin-maven/src/test/java/com/diffplug/spotless/maven/prettier/PrettierFormatStepTest.java

@@ -106,6 +106,58 @@ void unique_dependency_config() throws Exception {
 		assertThat(result.stdOutUtf8()).contains(Prettier.ERROR_MESSAGE_ONLY_ONE_CONFIG);
 	}
 
+	/**
+	 * This test is to ensure that we can have multiple prettier instances in one spotless config.
+	 *
+	 * @see <a href="https://github.com/diffplug/spotless/issues/1162">Issue #1162 on github</a>
+	 */
+	@Test
+	void multiple_prettier_configs() throws Exception {
+		writePom(
+				formats(
+						groupWithSteps("format", including("php-example.php"),
+								"<prettier>",
+								"  <devDependencyProperties>",
+								"    <property>",
+								"      <name>prettier</name>",
+								"      <value>2.0.5</value>",
+								"    </property>",
+								"    <property>",
+								"      <name>@prettier/plugin-php</name>",
+								"      <value>0.14.2</value>",
+								"    </property>",
+								"  </devDependencyProperties>",
+								"  <config>",
+								"    <tabWidth>3</tabWidth>",
+								"    <parser>php</parser>",
+								"  </config>",
+								"</prettier>"),
+						groupWithSteps("java", including("JavaTest.java"),
+								"<prettier>",
+								"  <devDependencyProperties>",
+								"    <property>",
+								"      <name>prettier</name>",
+								"      <value>2.0.5</value>",
+								"    </property>",
+								"    <property>",
+								"      <name>prettier-plugin-java</name>",
+								"      <value>0.8.0</value>",
+								"    </property>",
+								"  </devDependencyProperties>",
+								"  <config>",
+								"    <tabWidth>4</tabWidth>",
+								"    <parser>java</parser>",
+								"  </config>",
+								"</prettier>")));
+
+		setFile("php-example.php").toResource("npm/prettier/plugins/php.dirty");
+		setFile("JavaTest.java").toResource("npm/prettier/plugins/java-test.dirty");
+		mavenRunner().withArguments("spotless:apply").runNoError();
+		assertFile("php-example.php").sameAsResource("npm/prettier/plugins/php.clean");
+		assertFile("JavaTest.java").sameAsResource("npm/prettier/plugins/java-test.clean");
+
+	}
+
 	@Test
 	void custom_plugin() throws Exception {
 		writePomWithFormatSteps(