An easier way to detect that we are running with configuration-cache is to check to see if transient fields are null.

Author: nedtwigg

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java

@@ -56,7 +56,7 @@ public void setEncoding(String encoding) {
 		this.encoding = Objects.requireNonNull(encoding);
 	}
 
-	protected LineEnding.Policy lineEndingsPolicy;
+	protected transient LineEnding.Policy lineEndingsPolicy;
 
 	@Input
 	public LineEnding.Policy getLineEndingsPolicy() {
@@ -69,15 +69,15 @@ public void setLineEndingsPolicy(LineEnding.Policy lineEndingsPolicy) {
 
 	/*** API which performs git up-to-date tasks. */
 	@Nullable
-	private GitRatchetGradle ratchet;
+	private transient GitRatchetGradle ratchet;
 	/** The sha of the tree at repository root, used for determining if an individual *file* is clean according to git. */
-	private ObjectId rootTreeSha;
+	private transient ObjectId rootTreeSha;
 	/**
 	 * The sha of the tree at the root of *this project*, used to determine if the git baseline has changed within this folder.
 	 * Using a more fine-grained tree (rather than the project root) allows Gradle to mark more subprojects as up-to-date
 	 * compared to using the project root.
 	 */
-	private ObjectId subtreeSha = ObjectId.zeroId();
+	private transient ObjectId subtreeSha = ObjectId.zeroId();
 
 	public void setupRatchet(GitRatchetGradle gitRatchet, String ratchetFrom) {
 		ratchet = gitRatchet;
@@ -139,7 +139,7 @@ public File getOutputDirectory() {
 		return outputDirectory;
 	}
 
-	protected List<FormatterStep> steps = new ArrayList<>();
+	protected transient List<FormatterStep> steps = new ArrayList<>();
 
 	@Input
 	public List<FormatterStep> getSteps() {

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskImpl.java

@@ -50,7 +50,6 @@ public abstract class SpotlessTaskImpl extends SpotlessTask {
 	void init(Provider<SpotlessTaskService> service) {
 		getTaskService().set(service);
 		getProjectDir().set(getProject().getProjectDir());
-		service.get().registerSourceCreated(this);
 	}
 
 	@Inject
@@ -69,7 +68,7 @@ public void performAction(InputChanges inputs) throws Exception {
 			Files.createDirectories(outputDirectory.toPath());
 		}
 
-		if (getTaskService().get().sourceWasCreatedThisBuild(this)) {
+		if (lineEndingsPolicy != null) {
 			try (Formatter formatter = buildFormatter()) {
 				for (FileChange fileChange : inputs.getFileChanges(target)) {
 					File input = fileChange.getFile();

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskService.java

@@ -42,7 +42,6 @@
  * apply already did).
  */
 public abstract class SpotlessTaskService implements BuildService<BuildServiceParameters.None> {
-	private final Map<String, SpotlessTask> sourceCreated = Collections.synchronizedMap(new HashMap<>());
 	private final Map<String, SpotlessApply> apply = Collections.synchronizedMap(new HashMap<>());
 	private final Map<String, SpotlessTask> source = Collections.synchronizedMap(new HashMap<>());
 	private final Map<String, Provisioner> provisioner = Collections.synchronizedMap(new HashMap<>());
@@ -53,14 +52,6 @@ Provisioner provisionerFor(Project project) {
 		});
 	}
 
-	void registerSourceCreated(SpotlessTask spotlessTask) {
-		sourceCreated.put(spotlessTask.getPath(), spotlessTask);
-	}
-
-	boolean sourceWasCreatedThisBuild(SpotlessTask spotlessTask) {
-		return sourceCreated.containsKey(spotlessTask.getPath());
-	}
-
 	void registerSourceAlreadyRan(SpotlessTask task) {
 		source.put(task.getPath(), task);
 	}