eslint: remove unneeded configuration

Author: simschla

lib/src/main/java/com/diffplug/spotless/npm/EslintFormatterStep.java

@@ -213,8 +213,6 @@ private void setConfigToCallOptions(Map<FormatOption, Object> eslintCallOptions)
 			if (eslintConfig.getEslintConfigJs() != null) {
 				eslintCallOptions.put(FormatOption.ESLINT_OVERRIDE_CONFIG, eslintConfig.getEslintConfigJs());
 			}
-			eslintCallOptions.put(FormatOption.NODE_MODULES_DIR, nodeModulesDir.getAbsolutePath());
-
 			if (eslintConfig instanceof EslintTypescriptConfig) {
 				// if we are a ts config, see if we need to use specific paths or use default projectDir
 				File tsConfigFilePath = ((EslintTypescriptConfig) eslintConfig).getTypescriptConfigPath();

lib/src/main/java/com/diffplug/spotless/npm/EslintRestService.java

@@ -35,7 +35,7 @@ public String format(String fileContent, Map<FormatOption, Object> formatOptions
 	}
 
 	enum FormatOption {
-		ESLINT_OVERRIDE_CONFIG("eslint_override_config"), ESLINT_OVERRIDE_CONFIG_FILE("eslint_override_config_file"), FILE_PATH("file_path"), NODE_MODULES_DIR("node_modules_dir"), TS_CONFIG_ROOT_DIR("ts_config_root_dir");
+		ESLINT_OVERRIDE_CONFIG("eslint_override_config"), ESLINT_OVERRIDE_CONFIG_FILE("eslint_override_config_file"), FILE_PATH("file_path"), TS_CONFIG_ROOT_DIR("ts_config_root_dir");
 
 		private final String backendName;
 

testlib/src/test/java/com/diffplug/spotless/npm/EslintFormatterStepTest.java

@@ -23,6 +23,7 @@
 import com.diffplug.spotless.tag.NpmTest;
 
 import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
@@ -33,6 +34,12 @@
 @NpmTest
 class EslintFormatterStepTest {
 
+	private final Map<String, String> combine(Map<String, String> m1, Map<String, String> m2) {
+		Map<String, String> combined = new TreeMap<>(m1);
+		combined.putAll(m2);
+		return combined;
+	}
+
 	@NpmTest
 	@Nested
 	class EslintTypescriptFormattingStepTest extends NpmFormatterStepCommonTests {
@@ -43,11 +50,7 @@ class EslintTypescriptFormattingStepTest extends NpmFormatterStepCommonTests {
 				"standard_rules_xo", combine(EslintFormatterStep.defaultDevDependenciesForTypescript(), EslintFormatterStep.PopularStyleGuide.XO_TYPESCRIPT.devDependencies())
 				);
 
-		private final Map<String, String> combine(Map<String, String> m1, Map<String, String> m2) {
-			Map<String, String> combined = new TreeMap<>(m1);
-			combined.putAll(m2);
-			return combined;
-		}
+
 
 		@ParameterizedTest(name = "{index}: eslint can be applied using ruleset {0}")
 		@ValueSource(strings = {"custom_rules", "standard_rules_standard_with_typescript", "standard_rules_xo"})