[prone] Apply UnusedMethod

Author: Vincent Potucek

gradle/error-prone.gradle

@@ -23,11 +23,6 @@ tasks.withType(JavaCompile).configureEach {
 				'NonStaticImport',
 				'Slf4jLoggerDeclaration', // logger -> log
 				'StaticImport',
-				// critical, finds lots of bugs... unused configs and stuff.
-				'Unused',
-				'UnusedMethod',
-				'UnusedParameters',
-				'UnusedVariable',
 				)
 		error(
 				'AmbiguousJsonCreator',
@@ -52,11 +47,15 @@ tasks.withType(JavaCompile).configureEach {
 				'SelfAssignment',
 				'StringJoin',
 				'StringJoining',
+				'Unused',
 				)
 		// fixme bug: this only happens when the file is dirty!
 		// up2date checking (caching) must consider file changes, as file is currently corrupt!
 		// fix SelfTest.java:L22 ForbidGradleInternal(import org.gradle.api.internal.project.ProjectInternal;)
 		errorproneArgs.add('-XepExcludedPaths:.*/SelfTest.java')
+		// bug https://github.com/google/error-prone/issues/5289
+		errorproneArgs.add('-XepExcludedPaths:.*/EclipseJdtFormatterStepTest.java')
+		errorproneArgs.add('-XepExcludedPaths:.*/JvmTest.java')
 		if (!getenv().containsKey('CI') && getenv('IN_PLACE')?.toBoolean()) {
 			errorproneArgs.addAll(
 					'-XepPatchLocation:IN_PLACE',
@@ -86,7 +85,10 @@ tasks.withType(JavaCompile).configureEach {
 					'Slf4jLogStatement,' +
 					'StringJoin,' +
 					'StringJoining,' +
-					'TimeZoneUsage,'
+					'TimeZoneUsage,' +
+					'UnusedMethod,' +
+					'UnusedParameters,' +
+					'UnusedVariable,'
 					)
 		}
 	}

lib-extra/src/test/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStepTest.java

@@ -36,7 +36,5 @@ void formatWithVersion(String version) throws Exception {
 				"#include <a.h>;\nint main(int argc, char *argv[]) {\n}\n");
 	}
 
-	private static Stream<String> formatWithVersion() {
-		return Stream.of("11.0", "11.6", EclipseCdtFormatterStep.defaultVersion());
-	}
+	
 }

lib-extra/src/test/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStepTest.java

@@ -24,8 +24,8 @@
 import com.diffplug.spotless.extra.eclipse.EquoResourceHarness;
 
 public class GrEclipseFormatterStepTest extends EquoResourceHarness {
-	private static final String INPUT = "class F{ def m(){} }";
-	private static final String EXPECTED = "class F{\n\tdef m(){}\n}";
+	
+	
 
 	public GrEclipseFormatterStepTest() {
 		super(GrEclipseFormatterStep.createBuilder(TestProvisioner.mavenCentral()));
@@ -38,7 +38,5 @@ void formatWithVersion(String version) throws Exception {
 				"class F{ def m(){} }", "class F{\n\tdef m(){}\n}");
 	}
 
-	private static Stream<String> formatWithVersion() {
-		return Stream.of("4.18", GrEclipseFormatterStep.defaultVersion());
-	}
+	
 }

lib-extra/src/test/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStepTest.java

@@ -43,9 +43,7 @@ void formatWithVersion(String version) throws Exception {
 				"package p;\nclass C {\n}");
 	}
 
-	private static Stream<String> formatWithVersion() {
-		return Stream.of("4.9", EclipseJdtFormatterStep.defaultVersion());
-	}
+	
 
 	/** New format interface requires source file information to distinguish module-info from compilation unit */
 	@Nested

lib-extra/src/test/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStepTest.java

@@ -52,9 +52,7 @@ void formatWithVersion(String version) throws Exception {
 			harnessFor(version).test("someFilename", unformatted, formatted);
 		}
 
-		private static Stream<String> formatWithVersion() {
-			return Stream.of(JVM_SUPPORT.getRecommendedFormatterVersion(), EclipseWtpFormatterStep.defaultVersion());
-		}
+		
 
 		/**
 		 * Check that configuration change is supported by all WTP formatters.

lib/src/compatKtLint0Dot49Dot0/java/com/diffplug/spotless/glue/ktlint/compat/KtLintCompat0Dot49Dot0Adapter.java

@@ -27,9 +27,6 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.pinterest.ktlint.cli.ruleset.core.api.RuleSetProviderV3;
 import com.pinterest.ktlint.rule.engine.api.Code;
 import com.pinterest.ktlint.rule.engine.api.EditorConfigDefaults;
@@ -55,8 +52,6 @@
 
 public class KtLintCompat0Dot49Dot0Adapter implements KtLintCompatAdapter {
 
-	private static final Logger LOGGER = LoggerFactory.getLogger(KtLintCompat0Dot49Dot0Adapter.class);
-
 	private static final List<EditorConfigProperty<?>> DEFAULT_EDITOR_CONFIG_PROPERTIES;
 
 	static {

lib/src/compatKtLint0Dot50Dot0/java/com/diffplug/spotless/glue/ktlint/compat/KtLintCompat0Dot50Dot0Adapter.java

@@ -25,9 +25,6 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.pinterest.ktlint.cli.ruleset.core.api.RuleSetProviderV3;
 import com.pinterest.ktlint.rule.engine.api.Code;
 import com.pinterest.ktlint.rule.engine.api.EditorConfigDefaults;
@@ -55,8 +52,6 @@
 
 public class KtLintCompat0Dot50Dot0Adapter implements KtLintCompatAdapter {
 
-	private static final Logger LOGGER = LoggerFactory.getLogger(KtLintCompat0Dot50Dot0Adapter.class);
-
 	private static final List<EditorConfigProperty<?>> DEFAULT_EDITOR_CONFIG_PROPERTIES;
 
 	static {

lib/src/compatKtLint1Dot0Dot0/java/com/diffplug/spotless/glue/ktlint/compat/KtLintCompat1Dot0Dot0Adapter.java

@@ -24,9 +24,6 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.pinterest.ktlint.cli.ruleset.core.api.RuleSetProviderV3;
 import com.pinterest.ktlint.rule.engine.api.Code;
 import com.pinterest.ktlint.rule.engine.api.EditorConfigDefaults;
@@ -54,8 +51,6 @@
 
 public class KtLintCompat1Dot0Dot0Adapter implements KtLintCompatAdapter {
 
-	private static final Logger LOGGER = LoggerFactory.getLogger(KtLintCompat1Dot0Dot0Adapter.class);
-
 	private static final List<EditorConfigProperty<?>> DEFAULT_EDITOR_CONFIG_PROPERTIES;
 
 	static {

lib/src/gherkin/java/com/diffplug/spotless/glue/gherkin/GherkinUtilsFormatterFunc.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 DiffPlug
+ * Copyright 2023-2025 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,9 +15,6 @@
  */
 package com.diffplug.spotless.glue.gherkin;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.diffplug.spotless.FormatterFunc;
 import com.diffplug.spotless.gherkin.GherkinUtilsConfig;
 
@@ -30,12 +27,9 @@
 import io.cucumber.messages.types.SourceMediaType;
 
 public class GherkinUtilsFormatterFunc implements FormatterFunc {
-	private static final Logger LOGGER = LoggerFactory.getLogger(GherkinUtilsFormatterFunc.class);
-
-	private final GherkinUtilsConfig gherkinSimpleConfig;
 
 	public GherkinUtilsFormatterFunc(GherkinUtilsConfig gherkinSimpleConfig) {
-		this.gherkinSimpleConfig = gherkinSimpleConfig;
+
 	}
 
 	// Follows https://github.com/cucumber/gherkin-utils/blob/main/java/src/test/java/io/cucumber/gherkin/utils/pretty/PrettyTest.java

lib/src/googleJavaFormat/java/com/diffplug/spotless/glue/java/GoogleJavaFormatRemoveUnusedImporterFormatterFunc.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 DiffPlug
+ * Copyright 2023-2025 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,8 +15,6 @@
  */
 package com.diffplug.spotless.glue.java;
 
-import java.util.Objects;
-
 import javax.annotation.Nonnull;
 
 import com.google.googlejavaformat.java.RemoveUnusedImports;
@@ -25,11 +23,8 @@
 
 public class GoogleJavaFormatRemoveUnusedImporterFormatterFunc implements FormatterFunc {
 
-	@Nonnull
-	private final String version;
-
 	public GoogleJavaFormatRemoveUnusedImporterFormatterFunc(@Nonnull String version) {
-		this.version = Objects.requireNonNull(version);
+
 	}
 
 	@Override