removeWildcardImports: throw new AssertionError instead of removing

Author: Vincent Potucek

plugin-maven/src/test/java/com/diffplug/spotless/maven/MavenIntegrationHarness.java

@@ -46,6 +46,8 @@
 import com.diffplug.spotless.ResourceHarness;
 
 public class MavenIntegrationHarness extends ResourceHarness {
+
+	protected static final String PATH = "src/main/java/test.java";
 	/**
 	 * To run tests in the IDE, run {@code gradlew :plugin-maven:changelogPrint}, then
 	 * put the last version it prints into {@code SPOTLESS_MAVEN_VERSION_IDE}.  From now

plugin-maven/src/test/java/com/diffplug/spotless/maven/java/RemoveWildcardImportsStepTest.java

@@ -15,19 +15,40 @@
  */
 package com.diffplug.spotless.maven.java;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import com.diffplug.spotless.maven.MavenIntegrationHarness;
 
 class RemoveWildcardImportsStepTest extends MavenIntegrationHarness {
 
+	private static final String ERROR = "Do not use wildcard imports. 'spotlessApply' cannot resolve this issue.";
+
+	@BeforeEach
+	void init() throws Exception {
+		writePomWithJavaSteps("<removeWildcardImports/>");
+	}
+
 	@Test
 	void testRemoveWildcardImports() throws Exception {
-		writePomWithJavaSteps("<removeWildcardImports/>");
+		setFile(PATH).toResource("java/removewildcardimports/JavaCodeWildcardsFormatted.test");
+		assertFile(PATH).sameAsResource("java/removewildcardimports/JavaCodeWildcardsFormatted.test");
+		assertThat(mavenRunner().withArguments("spotless:apply").runHasError().stdOutUtf8()).contains(ERROR);
+	}
 
-		String path = "src/main/java/test.java";
-		setFile(path).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+	@Test
+	void testRemoveStaticWildcardImports() throws Exception {
+		setFile(PATH).toResource("java/removewildcardimports/JavaCodeStaticWildcardsFormatted.test");
+		assertFile(PATH).sameAsResource("java/removewildcardimports/JavaCodeStaticWildcardsFormatted.test");
+		assertThat(mavenRunner().withArguments("spotless:apply").runHasError().stdOutUtf8()).contains(ERROR);
+	}
+
+	@Test
+	void testRemoveWildcardImportsNoError() throws Exception {
+		setFile(PATH).toResource("java/removewildcardimports/JavaCodeNoWildcardsUnformatted.test");
+		assertFile(PATH).sameAsResource("java/removewildcardimports/JavaCodeNoWildcardsUnformatted.test");
 		mavenRunner().withArguments("spotless:apply").runNoError();
-		assertFile(path).sameAsResource("java/removewildcardimports/JavaCodeWildcardsFormatted.test");
 	}
 }

testlib/src/main/resources/java/removewildcardimports/JavaCodeNoWildcardsFormatted.test

@@ -0,0 +1,4 @@
+import java.util.List;
+import mylib.Helper;
+
+public class Test {}

testlib/src/main/resources/java/removewildcardimports/JavaCodeNoWildcardsUnformatted.test

@@ -0,0 +1,4 @@
+import java.util.List;
+import mylib.Helper;
+
+public class Test {}

testlib/src/main/resources/java/removewildcardimports/JavaCodeStaticWildcardsFormatted.test

@@ -0,0 +1,9 @@
+import java.util.*;
+import static java.util.Collections.*;
+import java.util.List;
+import mylib.Helper;
+import io.quarkus.maven.dependency.*;
+import static io.quarkus.vertx.web.Route.HttpMethod.*;
+import static org.springframework.web.reactive.function.BodyInserters.*;
+
+public class Test {}

testlib/src/main/resources/java/removewildcardimports/JavaCodeStaticWildcardsUnformatted.test

@@ -0,0 +1,5 @@
+import java.util.List;
+import mylib.Helper;
+import static io.quarkus.vertx.web.Route.HttpMethod.*;
+
+public class Test {}

testlib/src/main/resources/java/removewildcardimports/JavaCodeWildcardsFormatted.test

@@ -1,4 +1,9 @@
+import java.util.*;
+import static java.util.Collections.*;
 import java.util.List;
 import mylib.Helper;
+import io.quarkus.maven.dependency.*;
+import static io.quarkus.vertx.web.Route.HttpMethod.*;
+import static org.springframework.web.reactive.function.BodyInserters.*;
 
 public class Test {}