fix Reports loops that can be replaced with a single String.repeat() method (available since Java 11).

Author: Vincent Potucek

lib/src/main/java/com/diffplug/spotless/generic/IndentStep.java

@@ -102,14 +102,10 @@ String format(String raw) {
 				if (numSpaces > 0) {
 					switch (state.type) {
 					case SPACE:
-						for (int i = 0; i < numSpaces; ++i) {
-							builder.append(' ');
-						}
+						builder.append(" ".repeat(numSpaces));
 						break;
 					case TAB:
-						for (int i = 0; i < numSpaces / state.numSpacesPerTab; ++i) {
-							builder.append('\t');
-						}
+						builder.append("\t".repeat(Math.max(0, numSpaces / state.numSpacesPerTab)));
 						if (mightBeMultiLineComment && (numSpaces % state.numSpacesPerTab == 1)) {
 							builder.append(' ');
 						}

lib/src/main/java/com/diffplug/spotless/sql/dbeaver/DBeaverSQLFormatterConfiguration.java

@@ -67,9 +67,7 @@ public DBeaverSQLFormatterConfiguration(Properties properties) {
 	private String getIndentString(String indentType, int indentSize) {
 		char indentChar = indentType.equals("space") ? ' ' : '\t';
 		StringBuilder stringBuilder = new StringBuilder();
-		for (int i = 0; i < indentSize; i++) {
-			stringBuilder.append(indentChar);
-		}
+		stringBuilder.append(String.valueOf(indentChar).repeat(Math.max(0, indentSize)));
 		return stringBuilder.toString();
 	}
 

lib/src/main/java/com/diffplug/spotless/sql/dbeaver/SQLTokenizedFormatter.java

@@ -398,9 +398,7 @@ private int insertReturnAndIndent(final List<FormatterToken> argList, final int
 		try {
 			final String defaultLineSeparator = getDefaultLineSeparator();
 			StringBuilder s = new StringBuilder(defaultLineSeparator);
-			for (int index = 0; index < argIndent; index++) {
-				s.append(formatterCfg.getIndentString());
-			}
+			s.append(String.valueOf(formatterCfg.getIndentString()).repeat(Math.max(0, argIndent)));
 			if (argIndex > 0) {
 				final FormatterToken token = argList.get(argIndex);
 				final FormatterToken prevToken = argList.get(argIndex - 1);