No reason for DirtyState.Calculation to be public API.

Author: nedtwigg

lib/src/main/java/com/diffplug/spotless/DirtyState.java

@@ -69,15 +69,15 @@ public static DirtyState clean() {
 	static final DirtyState didNotConverge = new DirtyState(null);
 	static final DirtyState isClean = new DirtyState(null);
 
-	public static Calculation of(Formatter formatter, File file) throws IOException {
+	public static DirtyState of(Formatter formatter, File file) throws IOException {
 		return of(formatter, file, Files.readAllBytes(file.toPath()));
 	}
 
-	public static Calculation of(Formatter formatter, File file, byte[] rawBytes) {
-		return new Calculation(formatter, file, rawBytes);
+	public static DirtyState of(Formatter formatter, File file, byte[] rawBytes) {
+		return new Calculation(formatter, file, rawBytes).calculateDirtyState();
 	}
 
-	public static class Calculation {
+	private static class Calculation {
 		private final Formatter formatter;
 		private final File file;
 		private final byte[] rawBytes;

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/IdeHook.java

@@ -55,7 +55,7 @@ static void performHook(SpotlessTaskImpl spotlessTask) {
 				} else {
 					bytes = Files.readAllBytes(file.toPath());
 				}
-				DirtyState dirty = DirtyState.of(formatter, file, bytes).calculateDirtyState();
+				DirtyState dirty = DirtyState.of(formatter, file, bytes);
 				if (dirty.isClean()) {
 					dumpIsClean();
 				} else if (dirty.didNotConverge()) {

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskImpl.java

@@ -102,7 +102,7 @@ void processInputFile(@Nullable GitRatchet ratchet, Formatter formatter, File in
 			dirtyState = DirtyState.clean();
 		} else {
 			try {
-				dirtyState = DirtyState.of(formatter, input).calculateDirtyState();
+				dirtyState = DirtyState.of(formatter, input);
 			} catch (IOException e) {
 				throw new IOException("Issue processing file: " + input, e);
 			} catch (RuntimeException e) {

plugin-maven/src/main/java/com/diffplug/spotless/maven/IdeHook.java

@@ -49,7 +49,7 @@ static void performHook(Iterable<File> projectFiles, Formatter formatter, String
 			} else {
 				bytes = Files.readAllBytes(file.toPath());
 			}
-			DirtyState dirty = DirtyState.of(formatter, file, bytes).calculateDirtyState();
+			DirtyState dirty = DirtyState.of(formatter, file, bytes);
 			if (dirty.isClean()) {
 				dumpIsClean();
 			} else if (dirty.didNotConverge()) {

plugin-maven/src/main/java/com/diffplug/spotless/maven/SpotlessApplyMojo.java

@@ -60,7 +60,7 @@ protected void process(String name, Iterable<File> files, Formatter formatter, U
 			}
 
 			try {
-				DirtyState dirtyState = DirtyState.of(formatter, file).calculateDirtyState();
+				DirtyState dirtyState = DirtyState.of(formatter, file);
 				if (!dirtyState.isClean() && !dirtyState.didNotConverge()) {
 					getLog().info(String.format("Writing clean file: %s", file));
 					dirtyState.writeCanonicalTo(file);

plugin-maven/src/main/java/com/diffplug/spotless/maven/SpotlessCheckMojo.java

@@ -78,7 +78,7 @@ protected void process(String name, Iterable<File> files, Formatter formatter, U
 			}
 			buildContext.removeMessages(file);
 			try {
-				DirtyState dirtyState = DirtyState.of(formatter, file).calculateDirtyState();
+				DirtyState dirtyState = DirtyState.of(formatter, file);
 				if (!dirtyState.isClean() && !dirtyState.didNotConverge()) {
 					problemFiles.add(file);
 					if (buildContext.isIncremental()) {