Skip to content

Commit 696a07f

Browse files
committed
Merge branch 'main' into renovate/slf4j-monorepo
2 parents 0b180d4 + 0f2a4b6 commit 696a07f

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

plugin-gradle/src/test/java/com/diffplug/gradle/spotless/TypescriptExtensionTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2023 DiffPlug
2+
* Copyright 2016-2024 DiffPlug
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -17,6 +17,7 @@
1717

1818
import java.io.IOException;
1919

20+
import org.junit.jupiter.api.Disabled;
2021
import org.junit.jupiter.api.Test;
2122

2223
import com.diffplug.spotless.npm.EslintFormatterStep;
@@ -169,6 +170,7 @@ void useEslint() throws IOException {
169170
}
170171

171172
@Test
173+
@Disabled
172174
void useEslintXoStandardRules() throws IOException {
173175
setFile(".eslintrc.js").toResource("npm/eslint/typescript/styleguide/xo/.eslintrc.js");
174176
setFile("tsconfig.json").toResource("npm/eslint/typescript/styleguide/xo/tsconfig.json");

plugin-maven/src/test/java/com/diffplug/spotless/maven/typescript/TypescriptFormatStepTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2023 DiffPlug
2+
* Copyright 2016-2024 DiffPlug
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@
1919

2020
import java.io.IOException;
2121

22+
import org.junit.jupiter.api.Disabled;
2223
import org.junit.jupiter.api.Test;
2324

2425
import com.diffplug.spotless.ProcessRunner;
@@ -210,6 +211,7 @@ void eslintStyleguideStandardWithTypescript() throws Exception {
210211
}
211212

212213
@Test
214+
@Disabled
213215
void eslintStyleguideXo() throws Exception {
214216
writePomWithTypescriptSteps(
215217
TEST_FILE_PATH,

testlib/src/test/java/com/diffplug/spotless/npm/EslintFormatterStepTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,10 @@ class EslintJavascriptFormattingStepTest extends NpmFormatterStepCommonTests {
4141
"custom_rules", EslintFormatterStep.defaultDevDependenciesForTypescript(),
4242
"styleguide/airbnb", EslintStyleGuide.JS_AIRBNB.mergedWith(EslintFormatterStep.defaultDevDependencies()),
4343
"styleguide/google", EslintStyleGuide.JS_GOOGLE.mergedWith(EslintFormatterStep.defaultDevDependencies()),
44-
"styleguide/standard", EslintStyleGuide.JS_STANDARD.mergedWith(EslintFormatterStep.defaultDevDependencies()),
45-
"styleguide/xo", EslintStyleGuide.JS_XO.mergedWith(EslintFormatterStep.defaultDevDependencies()));
44+
"styleguide/standard", EslintStyleGuide.JS_STANDARD.mergedWith(EslintFormatterStep.defaultDevDependencies()));
4645

4746
@ParameterizedTest(name = "{index}: eslint can be applied using ruleset {0}")
48-
@ValueSource(strings = {"custom_rules", "styleguide/airbnb", "styleguide/google", "styleguide/standard", "styleguide/xo"})
47+
@ValueSource(strings = {"custom_rules", "styleguide/airbnb", "styleguide/google", "styleguide/standard"})
4948
void formattingUsingRulesetsFile(String ruleSetName) throws Exception {
5049
String filedir = "npm/eslint/javascript/" + ruleSetName + "/";
5150

@@ -79,11 +78,10 @@ class EslintTypescriptFormattingStepTest extends NpmFormatterStepCommonTests {
7978

8079
private final Map<String, Map<String, String>> devDependenciesForRuleset = ImmutableMap.of(
8180
"custom_rules", EslintFormatterStep.defaultDevDependenciesForTypescript(),
82-
"styleguide/standard_with_typescript", EslintStyleGuide.TS_STANDARD_WITH_TYPESCRIPT.mergedWith(EslintFormatterStep.defaultDevDependenciesForTypescript()),
83-
"styleguide/xo", EslintStyleGuide.TS_XO_TYPESCRIPT.mergedWith(EslintFormatterStep.defaultDevDependenciesForTypescript()));
81+
"styleguide/standard_with_typescript", EslintStyleGuide.TS_STANDARD_WITH_TYPESCRIPT.mergedWith(EslintFormatterStep.defaultDevDependenciesForTypescript()));
8482

8583
@ParameterizedTest(name = "{index}: eslint can be applied using ruleset {0}")
86-
@ValueSource(strings = {"custom_rules", "styleguide/standard_with_typescript", "styleguide/xo"})
84+
@ValueSource(strings = {"custom_rules", "styleguide/standard_with_typescript"})
8785
void formattingUsingRulesetsFile(String ruleSetName) throws Exception {
8886
String filedir = "npm/eslint/typescript/" + ruleSetName + "/";
8987

0 commit comments

Comments
 (0)