fix: add support for ktfmt's TrailingCommaManagementStrategy (WIP)

NOTE: also updated JVM version to 17

Author: greyhairredbear

gradle.properties

@@ -21,7 +21,7 @@ artifactIdMaven=spotless-maven-plugin
 artifactIdGradle=spotless-plugin-gradle
 
 # Build requirements
-VER_JAVA=11
+VER_JAVA=17
 VER_JSR_305=3.0.2
 
 # Dependencies provided by Spotless plugin

gradle/java-publish.gradle

@@ -77,7 +77,7 @@ javadoc {
 	//
 	// Thus, no javadoc warnings.
 	options.addStringOption('Xdoclint:none', '-quiet')
-	options.addStringOption('source', '11')
+	options.addStringOption('source', '17')
 	// setup the header
 	options.header javadocInfo
 	// setup links

lib/build.gradle

@@ -104,7 +104,7 @@ dependencies {
 	jacksonCompileOnly "com.fasterxml.jackson.core:jackson-databind:$VER_JACKSON"
 	jacksonCompileOnly "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:$VER_JACKSON"
 	// ktfmt
-	ktfmtCompileOnly "com.facebook:ktfmt:0.53"
+	ktfmtCompileOnly "com.facebook:ktfmt:0.58"
 	ktfmtCompileOnly("com.google.googlejavaformat:google-java-format") {
 		version {
 			strictly '1.7' // for JDK 8 compatibility

lib/src/ktfmt/java/com/diffplug/spotless/glue/ktfmt/KtfmtFormatterFunc.java

@@ -55,29 +55,23 @@ public String apply(@Nonnull String input) throws Exception {
 	}
 
 	private FormattingOptions createFormattingOptions() throws Exception {
-		FormattingOptions formattingOptions;
-		switch (style) {
-		case META:
-			formattingOptions = Formatter.META_FORMAT;
-			break;
-		case GOOGLE:
-			formattingOptions = Formatter.GOOGLE_FORMAT;
-			break;
-		case KOTLIN_LANG:
-			formattingOptions = Formatter.KOTLINLANG_FORMAT;
-			break;
-		default:
-			throw new IllegalStateException("Unknown formatting option " + style);
-		}
+		FormattingOptions formattingOptions = switch (style) {
+			case META -> Formatter.META_FORMAT;
+			case GOOGLE -> Formatter.GOOGLE_FORMAT;
+			case KOTLIN_LANG -> Formatter.KOTLINLANG_FORMAT;
+			default -> throw new IllegalStateException("Unknown formatting option " + style);
+		};
 
 		if (ktfmtFormattingOptions != null) {
 			formattingOptions = formattingOptions.copy(
-					ktfmtFormattingOptions.getMaxWidth().orElse(formattingOptions.getMaxWidth()),
-					ktfmtFormattingOptions.getBlockIndent().orElse(formattingOptions.getBlockIndent()),
-					ktfmtFormattingOptions.getContinuationIndent().orElse(formattingOptions.getContinuationIndent()),
-					ktfmtFormattingOptions.getManageTrailingCommas().orElse(formattingOptions.getManageTrailingCommas()),
-					ktfmtFormattingOptions.getRemoveUnusedImports().orElse(formattingOptions.getRemoveUnusedImports()),
-					formattingOptions.getDebuggingPrintOpsAfterFormatting());
+				ktfmtFormattingOptions.getMaxWidth().orElse(formattingOptions.getMaxWidth()),
+				ktfmtFormattingOptions.getBlockIndent().orElse(formattingOptions.getBlockIndent()),
+				ktfmtFormattingOptions.getContinuationIndent().orElse(formattingOptions.getContinuationIndent()),
+				ktfmtFormattingOptions.getTrailingCommaManagementStrategy()
+					.map(KtfmtTrailingCommaManagementStrategy::toFormatterTrailingCommaManagementStrategy)
+					.orElse(formattingOptions.getTrailingCommaManagementStrategy()),
+				ktfmtFormattingOptions.getRemoveUnusedImports().orElse(formattingOptions.getRemoveUnusedImports()),
+				formattingOptions.getDebuggingPrintOpsAfterFormatting());
 		}
 
 		return formattingOptions;

lib/src/ktfmt/java/com/diffplug/spotless/glue/ktfmt/KtfmtFormattingOptions.java

@@ -35,19 +35,19 @@ public final class KtfmtFormattingOptions {
 	private Boolean removeUnusedImports;
 
 	@Nullable
-	private Boolean manageTrailingCommas;
+	private KtfmtTrailingCommaManagementStrategy trailingCommaManagementStrategy;
 
 	public KtfmtFormattingOptions(
-			@Nullable Integer maxWidth,
-			@Nullable Integer blockIndent,
-			@Nullable Integer continuationIndent,
-			@Nullable Boolean removeUnusedImports,
-			@Nullable Boolean manageTrailingCommas) {
+		@Nullable Integer maxWidth,
+		@Nullable Integer blockIndent,
+		@Nullable Integer continuationIndent,
+		@Nullable Boolean removeUnusedImports,
+		@Nullable KtfmtTrailingCommaManagementStrategy trailingCommaManagementStrategy) {
 		this.maxWidth = maxWidth;
 		this.blockIndent = blockIndent;
 		this.continuationIndent = continuationIndent;
 		this.removeUnusedImports = removeUnusedImports;
-		this.manageTrailingCommas = manageTrailingCommas;
+		this.trailingCommaManagementStrategy = trailingCommaManagementStrategy;
 	}
 
 	@Nonnull
@@ -71,8 +71,8 @@ public Optional<Boolean> getRemoveUnusedImports() {
 	}
 
 	@Nonnull
-	public Optional<Boolean> getManageTrailingCommas() {
-		return Optional.ofNullable(manageTrailingCommas);
+	public Optional<KtfmtTrailingCommaManagementStrategy> getTrailingCommaManagementStrategy() {
+		return Optional.ofNullable(trailingCommaManagementStrategy);
 	}
 
 	public void setMaxWidth(int maxWidth) {
@@ -100,7 +100,7 @@ public void setRemoveUnusedImports(boolean removeUnusedImports) {
 		this.removeUnusedImports = removeUnusedImports;
 	}
 
-	public void setManageTrailingCommas(boolean manageTrailingCommas) {
-		this.manageTrailingCommas = manageTrailingCommas;
+	public void setTrailingCommaManagementStrategy(@Nullable KtfmtTrailingCommaManagementStrategy trailingCommaManagementStrategy) {
+		this.trailingCommaManagementStrategy = trailingCommaManagementStrategy;
 	}
 }

lib/src/ktfmt/java/com/diffplug/spotless/glue/ktfmt/KtfmtTrailingCommaManagementStrategy.java

@@ -0,0 +1,17 @@
+package com.diffplug.spotless.glue.ktfmt;
+
+import com.facebook.ktfmt.format.TrailingCommaManagementStrategy;
+
+public enum KtfmtTrailingCommaManagementStrategy {
+	NONE,
+	ONLY_ADD,
+	COMPLETE;
+
+	public TrailingCommaManagementStrategy toFormatterTrailingCommaManagementStrategy() {
+		return switch (this) {
+			case NONE -> TrailingCommaManagementStrategy.NONE;
+			case ONLY_ADD -> TrailingCommaManagementStrategy.ONLY_ADD;
+			case COMPLETE -> TrailingCommaManagementStrategy.COMPLETE;
+		};
+	}
+}