Apply suggestions

Author: blacelle

lib/src/main/java/com/diffplug/spotless/Formatter.java

@@ -113,7 +113,7 @@ public static Formatter.Builder builder() {
 
 	public static class Builder {
 		// optional parameters
-		private String name = "misc";
+		private String name = "unnamed";
 		// required parameters
 		private LineEnding.Policy lineEndingsPolicy;
 		private Charset encoding;

plugin-maven/src/main/java/com/diffplug/spotless/maven/ImpactedFilesTracker.java

@@ -15,41 +15,39 @@
  */
 package com.diffplug.spotless.maven;
 
-import java.util.concurrent.atomic.AtomicInteger;
-
 /**
  * Tracks the number of processed files, typically by a single Formatter for a whole repository
  */
-public class ImpactedFilesTracker {
-	protected final AtomicInteger nbSkipped = new AtomicInteger();
-	protected final AtomicInteger nbChecked = new AtomicInteger();
-	protected final AtomicInteger nbCleaned = new AtomicInteger();
+class ImpactedFilesTracker {
+	protected int nbskippedAsCleanCache = 0;
+	protected int nbCheckedButAlreadyClean = 0;
+	protected int nbCleaned = 0;
 
 	/**
 	 * Some cache mechanism may indicate some content is clean, without having to execute the cleaning process
 	 */
 	public void skippedAsCleanCache() {
-		nbSkipped.incrementAndGet();
+		nbskippedAsCleanCache++;
 	}
 
-	public int getSkipped() {
-		return nbSkipped.get();
+	public int getSkippedAsCleanCache() {
+		return nbskippedAsCleanCache;
 	}
 
-	public void checked() {
-		nbChecked.incrementAndGet();
+	public void checkedButAlreadyClean() {
+		nbCheckedButAlreadyClean++;
 	}
 
-	public int getChecked() {
-		return nbChecked.get();
+	public int getCheckedButAlreadyClean() {
+		return nbCheckedButAlreadyClean;
 	}
 
 	public void cleaned() {
-		nbCleaned.incrementAndGet();
+		nbCleaned++;
 	}
 
 	public int getCleaned() {
-		return nbCleaned.get();
+		return nbCleaned;
 	}
 
 }

plugin-maven/src/main/java/com/diffplug/spotless/maven/SpotlessApplyMojo.java

@@ -45,13 +45,14 @@ protected void process(Iterable<File> files, Formatter formatter, UpToDateChecke
 			}
 
 			try {
-				impactedFilesTracker.checked();
 				PaddedCell.DirtyState dirtyState = PaddedCell.calculateDirtyState(formatter, file);
 				if (!dirtyState.isClean() && !dirtyState.didNotConverge()) {
 					getLog().info(String.format("Writing clean file: %s", file));
 					dirtyState.writeCanonicalTo(file);
 					buildContext.refresh(file);
 					impactedFilesTracker.cleaned();
+				} else {
+					impactedFilesTracker.checkedButAlreadyClean();
 				}
 			} catch (IOException e) {
 				throw new MojoExecutionException("Unable to format file " + file, e);
@@ -61,11 +62,11 @@ protected void process(Iterable<File> files, Formatter formatter, UpToDateChecke
 		}
 
 		// We print the number of considered files which is useful when ratchetFrom is setup
-		int nbSkipped = impactedFilesTracker.getSkipped();
-		int nbChecked = impactedFilesTracker.getChecked();
-		int nbCleaned = impactedFilesTracker.getCleaned();
-		int totalProcessed = nbSkipped + nbChecked + nbCleaned;
+		int skippedAsCleanCache = impactedFilesTracker.getSkippedAsCleanCache();
+		int checkedButAlreadyClean = impactedFilesTracker.getCheckedButAlreadyClean();
+		int cleaned = impactedFilesTracker.getCleaned();
+		int totalProcessed = skippedAsCleanCache + checkedButAlreadyClean + cleaned;
 		getLog().info(String.format("Spotless.%s is keeping %s files clean - %s were changed to be clean, %s were already clean, %s were skipped because caching determined they were already clean",
-				formatter.getName(), totalProcessed, nbCleaned, nbChecked, nbSkipped));
+				formatter.getName(), totalProcessed, cleaned, checkedButAlreadyClean, skippedAsCleanCache));
 	}
 }