Fix spotbugs issues

Author: blutorange

lib/src/main/java/com/diffplug/spotless/rome/RomeExecutableDownloader.java

@@ -117,7 +117,10 @@ public Path download(String version) throws IOException, InterruptedException {
 		var url = getDownloadUrl(version, platform);
 		var executablePath = getExecutablePath(version, platform);
 		var checksumPath = getChecksumPath(executablePath);
-		Files.createDirectories(executablePath.getParent());
+		var executableDir = executablePath.getParent();
+		if (executableDir != null) {
+			Files.createDirectories(executableDir);
+		}
 		logger.info("Attempting to download Rome from '{}' to '{}'", url, executablePath);
 		var request = HttpRequest.newBuilder(URI.create(url)).GET().build();
 		var handler = BodyHandlers.ofFile(executablePath, WRITE_OPTIONS);
@@ -270,7 +273,11 @@ private String getArchitectureCodeName(Architecture architecture) throws IOExcep
 	 * @return The path with the checksum for the given file.
 	 */
 	private Path getChecksumPath(Path file) {
-		return file.getParent().resolve(file.getFileName().toString() + ".md5");
+		var parent = file.getParent();
+		var base = parent != null ? parent : file;
+		var fileName = file.getFileName();
+		var checksumName = fileName != null ? fileName.toString() + ".md5" : "checksum.md5";
+		return base.resolve(checksumName);
 	}
 
 	/**

lib/src/main/java/com/diffplug/spotless/rome/RomeStep.java

@@ -134,7 +134,9 @@ private static void attemptToAddPosixPermission(Path file, PosixFilePermission p
 			var newPermissions = new HashSet<>(Files.getPosixFilePermissions(file));
 			newPermissions.add(permission);
 			Files.setPosixFilePermissions(file, newPermissions);
-		} catch (final Exception ignore) {}
+		} catch (final Exception ignore) {
+			logger.debug("Unable to add POSIX permission '{}' to file '{}'", permission, file);
+		}
 	}
 
 	/**
@@ -440,7 +442,7 @@ private String resolveFileName(File file) {
 				return "jsx".equals(ext) || "js".equals(ext) || "mjs".equals(ext) || "cjs".equals(ext) ? name
 						: "file.js";
 			case "ts?":
-				return "tsx".equals(ext) || "ts".equals(ext) || "tjs".equals(ext) || "tjs".equals(ext) ? name
+				return "tsx".equals(ext) || "ts".equals(ext) || "mts".equals(ext) || "cts".equals(ext) ? name
 						: "file.js";
 			case "js":
 				return "js".equals(ext) || "mjs".equals(ext) || "cjs".equals(ext) ? name : "file.js";

plugin-maven/src/main/java/com/diffplug/spotless/maven/FileLocator.java

@@ -24,6 +24,7 @@
 import java.security.NoSuchAlgorithmException;
 import java.util.Base64;
 import java.util.Objects;
+import java.util.Optional;
 
 import org.codehaus.plexus.resource.ResourceManager;
 import org.codehaus.plexus.resource.loader.FileResourceCreationException;
@@ -121,10 +122,22 @@ private static byte[] hash(String value) {
 	}
 
 	private static File findDataDir() {
-		// E.g. ~/.m2/repository/com/diffplug/spotless/spotless-plugin-maven/1.2.3/spotless-plugin-maven-1.2.3.jar
-		final var jarPath = Paths.get(AbstractRome.class.getProtectionDomain().getCodeSource().getLocation().getPath());
-		final var base = jarPath.getParent().getParent().getParent();
-		final var sub = base.resolve("spotless-data");
-		return sub.toAbsolutePath().toFile();
+		// JAR path is e.g.
+		// ~/.m2/repository/com/diffplug/spotless/spotless-plugin-maven/1.2.3/spotless-plugin-maven-1.2.3.jar
+		var codeSource = FileLocator.class.getProtectionDomain().getCodeSource();
+		var location = codeSource != null ? codeSource.getLocation() : null;
+		var path = location != null ? location.getPath() : null;
+		var jarPath = path != null && !path.isBlank() ? Paths.get(path) : null;
+		var parent1 = jarPath != null ? jarPath.getParent() : null;
+		var parent2 = parent1 != null ? parent1.getParent() : null;
+		var base = parent2 != null ? parent2.getParent() : null;
+		var sub = base != null ? base.resolve("spotless-data") : null;
+		if (sub != null) {
+			return sub.toAbsolutePath().toFile();
+		}
+		else {
+			var home = Paths.get(System.getenv("user.home"));
+			return home.resolve(".rome").toAbsolutePath().toFile();
+		}
 	}
 }