Spotless dependencies are now resolved from the normal repositories of the root project.

Author: nedtwigg

plugin-gradle/CHANGES.md

@@ -3,6 +3,8 @@
 We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (starting after version `3.27.0`).
 
 ## [Unreleased]
+### Changed
+* **BREAKING** Previously, many projects required `buildscript { repositories { mavenCentral() }}` at the top of their root project, because Spotless resolved its dependencies using the buildscript repositories. Spotless now resolves its dependencies from the normal project repositories of the root project, which means that you can remove the `buildscript {}` block, but you still need `repositories { mavenCentral() }` (or similar) in the root project.
 
 ## [5.17.1] - 2021-10-26
 ### Changed

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/GradleProvisioner.java

@@ -73,7 +73,7 @@ static Provisioner fromRootBuildscript(Project project) {
 		Objects.requireNonNull(project);
 		return (withTransitives, mavenCoords) -> {
 			try {
-				Configuration config = project.getRootProject().getBuildscript().getConfigurations().create("spotless"
+				Configuration config = project.getRootProject().getConfigurations().create("spotless"
 						+ new Request(withTransitives, mavenCoords).hashCode());
 				mavenCoords.stream()
 						.map(project.getBuildscript().getDependencies()::create)
@@ -85,7 +85,7 @@ static Provisioner fromRootBuildscript(Project project) {
 				logger.log(
 						Level.SEVERE,
 						"You probably need to add a repository containing the '" + mavenCoords + "' artifact in the 'build.gradle' of your root project.\n" +
-								"E.g.: 'buildscript { repositories { mavenCentral() }}'",
+								"E.g.: 'repositories { mavenCentral() }'",
 						e);
 				throw e;
 			}
@@ -125,7 +125,7 @@ public boolean equals(Object obj) {
 		public String toString() {
 			String coords = mavenCoords.toString();
 			StringBuilder builder = new StringBuilder();
-			builder.append(coords.substring(1, coords.length() - 1)); // strip off []
+			builder.append(coords, 1, coords.length() - 1); // strip off []
 			if (withTransitives) {
 				builder.append(" with transitives");
 			} else {