refactor test for removeWildCardImports to forbidWildcardImports

Author: Plunts

plugin-gradle/src/test/java/com/diffplug/gradle/spotless/JavaDefaultTargetTest.java

@@ -82,7 +82,7 @@ void removeUnusedImportsWithCleanthat() throws IOException {
 	}
 
 	@Test
-	void removeWildCardImports() throws IOException {
+	void forbidWildcardImports() throws IOException {
 		setFile("build.gradle").toLines(
 				"plugins {",
 				"    id 'com.diffplug.spotless'",
@@ -92,17 +92,17 @@ void removeWildCardImports() throws IOException {
 				"spotless {",
 				"    java {",
 				"        target file('test.java')",
-				"        removeWildcardImports()",
+				"        forbidWildcardImports()",
 				"    }",
 				"}");
 
-		setFile("test.java").toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile("test.java").toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 		gradleRunner().withArguments("spotlessApply").buildAndFail();
-		assertFile("test.java").sameAsResource("java/removewildcardimports/JavaCodeWildcardsFormatted.test");
+		assertFile("test.java").sameAsResource("java/forbidwildcardimports/JavaCodeWildcardsFormatted.test");
 	}
 
 	@Test
-	void removeModuleImports() throws IOException {
+	void forbidModuleImports() throws IOException {
 		setFile("build.gradle").toLines(
 				"plugins {",
 				"    id 'com.diffplug.spotless'",

plugin-maven/src/test/java/com/diffplug/spotless/maven/java/ForbidWildcardImportsStepTest.java

@@ -26,9 +26,9 @@ void testForbidWildcardImports() throws Exception {
 		writePomWithJavaSteps("<forbidWildcardImports/>");
 
 		String path = "src/main/java/test.java";
-		setFile(path).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(path).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 		var selfie = expectSelfieErrorMsg(mavenRunner().withArguments("spotless:apply").runHasError());
-		assertFile(path).sameAsResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		assertFile(path).sameAsResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 		selfie.toBe("""
 				Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:VERSION:apply (default-cli) on project spotless-maven-plugin-tests: There were 5 lint error(s), they must be fixed or suppressed.
 				src/main/java/test.java:L1 forbidWildcardImports(import java.util.*;) Do not use wildcard imports (e.g. java.util.*) - replace with specific class imports (e.g. java.util.List) as 'spotlessApply' cannot auto-fix this

plugin-maven/src/test/java/com/diffplug/spotless/maven/java/LintSuppressionTest.java

@@ -30,7 +30,7 @@ void testNoSuppressionFailsOnWildcardImports() throws Exception {
 		writePomWithJavaSteps("<forbidWildcardImports/>");
 
 		String path = "src/main/java/TestFile.java";
-		setFile(path).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(path).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 
 		expectSelfieErrorMsg(mavenRunner().withArguments("spotless:check").runHasError()).toBe("""
 				Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:VERSION:check (default-cli) on project spotless-maven-plugin-tests: Unable to format file ${PROJECT_DIR}/src/main/java/TestFile.java
@@ -58,8 +58,8 @@ void testSuppressByFilePath() throws Exception {
 		String suppressedFile = "src/main/java/TestFile1.java";
 		String unsuppressedFile = "src/main/java/TestFile2.java";
 
-		setFile(suppressedFile).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
-		setFile(unsuppressedFile).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(suppressedFile).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(unsuppressedFile).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 
 		var result = mavenRunner().withArguments("spotless:check").runHasError();
 		assertThat(result.stdOutUtf8()).contains("TestFile2.java");
@@ -79,7 +79,7 @@ void testSuppressByStep() throws Exception {
 				"</lintSuppressions>");
 
 		String path = "src/main/java/TestFile.java";
-		setFile(path).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(path).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 
 		// Should succeed because we suppressed the entire step
 		mavenRunner().withArguments("spotless:check").runNoError();
@@ -99,7 +99,7 @@ void testSuppressByShortCode() throws Exception {
 				"</lintSuppressions>");
 
 		String path = "src/main/java/TestFile.java";
-		setFile(path).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(path).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 
 		// Should succeed because we suppressed all error codes
 		mavenRunner().withArguments("spotless:check").runNoError();
@@ -126,9 +126,9 @@ void testMultipleSuppressionsWork() throws Exception {
 		String file2 = "src/main/java/TestFile2.java";
 		String file3 = "src/main/java/TestFile3.java";
 
-		setFile(file1).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
-		setFile(file2).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
-		setFile(file3).toResource("java/removewildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(file1).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(file2).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
+		setFile(file3).toResource("java/forbidwildcardimports/JavaCodeWildcardsUnformatted.test");
 
 		var result = mavenRunner().withArguments("spotless:check").runHasError();
 		assertThat(result.stdOutUtf8()).contains("TestFile3.java");