DirtyState now uses LintPolicy.legacyBehavior unless you passed in the ValuePerStep explicitly. That's enough to bring most of our tests back to life.

Author: nedtwigg

lib/src/main/java/com/diffplug/spotless/DirtyState.java

@@ -78,7 +78,10 @@ public static DirtyState of(Formatter formatter, File file, byte[] rawBytes) {
 	}
 
 	public static DirtyState of(Formatter formatter, File file, byte[] rawBytes, String raw) {
-		return of(formatter, file, rawBytes, raw, new ValuePerStep<>(formatter));
+		var valuePerStep = new ValuePerStep<Throwable>(formatter);
+		DirtyState state = of(formatter, file, rawBytes, raw, valuePerStep);
+		LintPolicy.legacyBehavior(formatter, file, valuePerStep);
+		return state;
 	}
 
 	public static DirtyState of(Formatter formatter, File file, byte[] rawBytes, String raw, ValuePerStep<Throwable> exceptionPerStep) {

plugin-gradle/src/test/java/com/diffplug/gradle/spotless/BiomeIntegrationTest.java

@@ -19,12 +19,9 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.owasp.encoder.Encode;
 
-import com.diffplug.spotless.tag.ForLintRefactor;
-
 class BiomeIntegrationTest extends GradleIntegrationHarness {
 	/**
 	 * Tests that biome can be used as a JSON formatting step, using biome 1.8.3
@@ -376,8 +373,6 @@ void failureWhenExeNotFound() throws Exception {
 	 * @throws Exception When a test failure occurs.
 	 */
 	@Test
-	@Disabled
-	@ForLintRefactor
 	void failureWhenNotParseable() throws Exception {
 		setFile("build.gradle").toLines(
 				"plugins {",

plugin-gradle/src/test/java/com/diffplug/gradle/spotless/KotlinExtensionTest.java

@@ -20,11 +20,8 @@
 import java.io.File;
 import java.io.IOException;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
-import com.diffplug.spotless.tag.ForLintRefactor;
-
 class KotlinExtensionTest extends GradleIntegrationHarness {
 	private static final String HEADER = "// License Header";
 	private static final String HEADER_WITH_YEAR = "// License Header $YEAR";
@@ -170,8 +167,6 @@ void testSetEditorConfigCanOverrideEditorConfigFile() throws IOException {
 	}
 
 	@Test
-	@Disabled
-	@ForLintRefactor
 	void withCustomRuleSetApply() throws IOException {
 		setFile("build.gradle.kts").toLines(
 				"plugins {",

plugin-maven/src/test/java/com/diffplug/spotless/maven/biome/BiomeMavenTest.java

@@ -20,11 +20,9 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.owasp.encoder.Encode.forXml;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import com.diffplug.spotless.maven.MavenIntegrationHarness;
-import com.diffplug.spotless.tag.ForLintRefactor;
 
 /**
  * Tests for the Biome formatter used via the Maven spotless plugin.
@@ -225,8 +223,6 @@ void failureWhenExeNotFound() throws Exception {
 	 * @throws Exception When a test failure occurs.
 	 */
 	@Test
-	@Disabled
-	@ForLintRefactor
 	void failureWhenNotParseable() throws Exception {
 		writePomWithBiomeSteps("**/*.js", "<biome><version>1.2.0</version><language>json</language></biome>");
 		setFile("biome_test.js").toResource("biome/js/fileBefore.js");

plugin-maven/src/test/java/com/diffplug/spotless/maven/kotlin/KtlintTest.java

@@ -17,12 +17,10 @@
 
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import com.diffplug.spotless.ProcessRunner;
 import com.diffplug.spotless.maven.MavenIntegrationHarness;
-import com.diffplug.spotless.tag.ForLintRefactor;
 
 class KtlintTest extends MavenIntegrationHarness {
 	@Test
@@ -80,8 +78,6 @@ void testSetEditorConfigCanOverrideEditorConfigFile() throws Exception {
 	}
 
 	@Test
-	@Disabled
-	@ForLintRefactor
 	void testWithCustomRuleSetApply() throws Exception {
 		writePomWithKotlinSteps("<ktlint>\n" +
 				"  <customRuleSets>\n" +