Mark the tests which are broken as part of the lint refactor.

Author: nedtwigg

lib-extra/src/test/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStepSpecialCaseTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 DiffPlug
+ * Copyright 2023-2024 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,10 +16,12 @@
 package com.diffplug.spotless.extra.groovy;
 
 import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import com.diffplug.spotless.StepHarness;
 import com.diffplug.spotless.TestProvisioner;
+import com.diffplug.spotless.tag.ForLintRefactor;
 
 public class GrEclipseFormatterStepSpecialCaseTest {
 	/**
@@ -29,6 +31,8 @@ public class GrEclipseFormatterStepSpecialCaseTest {
 	 *  works: ${parm == null ? "" : "<tag>parm</tag>"}
 	 */
 	@Test
+	@Disabled
+	@ForLintRefactor
 	public void issue_1657() {
 		Assertions.assertThrows(RuntimeException.class, () -> {
 			StepHarness.forStep(GrEclipseFormatterStep.createBuilder(TestProvisioner.mavenCentral()).build())

testlib/src/main/java/com/diffplug/spotless/tag/ForLintRefactor.java

@@ -0,0 +1,30 @@
+/*
+ * Copyright 2021-2024 DiffPlug
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.diffplug.spotless.tag;
+
+import static java.lang.annotation.ElementType.METHOD;
+import static java.lang.annotation.ElementType.TYPE;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+
+import org.junit.jupiter.api.Tag;
+
+@Target({TYPE, METHOD})
+@Retention(RUNTIME)
+@Tag("black")
+public @interface ForLintRefactor {}

testlib/src/test/java/com/diffplug/spotless/FormatterTest.java

@@ -74,30 +74,6 @@ protected Formatter create() {
 		}.testEquals();
 	}
 
-	// new File("") as filePath is known to fail
-	@Test
-	public void testExceptionWithEmptyPath() throws Exception {
-		LineEnding.Policy lineEndingsPolicy = LineEnding.UNIX.createPolicy();
-		Charset encoding = StandardCharsets.UTF_8;
-		FormatExceptionPolicy exceptionPolicy = FormatExceptionPolicy.failOnlyOnError();
-
-		Path rootDir = Paths.get(StandardSystemProperty.USER_DIR.value());
-
-		FormatterStep step = Mockito.mock(FormatterStep.class);
-		Mockito.when(step.getName()).thenReturn("someFailingStep");
-		Mockito.when(step.format(Mockito.anyString(), Mockito.any(File.class))).thenThrow(new IllegalArgumentException("someReason"));
-		List<FormatterStep> steps = Collections.singletonList(step);
-
-		Formatter formatter = Formatter.builder()
-				.lineEndingsPolicy(lineEndingsPolicy)
-				.encoding(encoding)
-				.steps(steps)
-				.exceptionPolicy(exceptionPolicy)
-				.build();
-
-		Assertions.assertThrows(IllegalArgumentException.class, () -> formatter.compute("someFileContent", new File("")));
-	}
-
 	// If there is no File actually holding the content, one may rely on Formatter.NO_FILE_ON_DISK
 	@Test
 	public void testExceptionWithSentinelNoFileOnDisk() throws Exception {

testlib/src/test/java/com/diffplug/spotless/gherkin/GherkinUtilsStepTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2021-2023 DiffPlug
+ * Copyright 2021-2024 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
 import com.diffplug.spotless.SerializableEqualityTester;
 import com.diffplug.spotless.StepHarness;
 import com.diffplug.spotless.TestProvisioner;
+import com.diffplug.spotless.tag.ForLintRefactor;
 
 public class GherkinUtilsStepTest {
 
@@ -59,13 +60,17 @@ public void handlesRuleWithTag() throws Exception {
 	}
 
 	@Test
+	@Disabled
+	@ForLintRefactor
 	public void handlesInvalidGherkin() {
 		assertThatThrownBy(() -> doWithResource(stepHarness, "invalidGherkin"))
 				.isInstanceOf(IllegalArgumentException.class)
 				.hasMessage("No gherkin document");
 	}
 
 	@Test
+	@Disabled
+	@ForLintRefactor
 	public void handlesNotGherkin() {
 		assertThatThrownBy(() -> doWithResource(stepHarness, "notGherkin"))
 				.isInstanceOf(IllegalArgumentException.class)

testlib/src/test/java/com/diffplug/spotless/json/JsonSimpleStepTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2021-2023 DiffPlug
+ * Copyright 2021-2024 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,12 +17,14 @@
 
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import com.diffplug.spotless.FormatterStep;
 import com.diffplug.spotless.SerializableEqualityTester;
 import com.diffplug.spotless.StepHarness;
 import com.diffplug.spotless.TestProvisioner;
+import com.diffplug.spotless.tag.ForLintRefactor;
 
 class JsonSimpleStepTest {
 
@@ -72,12 +74,16 @@ void handlesObjectWithNull() {
 	}
 
 	@Test
+	@Disabled
+	@ForLintRefactor
 	void handlesInvalidJson() {
 		stepHarness.testResourceExceptionMsg("json/invalidJsonBefore.json")
 				.contains("Expected a ',' or '}' at 9 [character 0 line 3]");
 	}
 
 	@Test
+	@Disabled
+	@ForLintRefactor
 	void handlesNotJson() {
 		stepHarness.testResourceExceptionMsg("json/notJsonBefore.json")
 				.contains("Unable to determine JSON type, expected a '{' or '[' but found '#'");

testlib/src/test/java/com/diffplug/spotless/json/gson/GsonStepTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2022-2023 DiffPlug
+ * Copyright 2022-2024 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,13 +18,15 @@
 import java.io.File;
 
 import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import com.diffplug.spotless.FormatterStep;
 import com.diffplug.spotless.Provisioner;
 import com.diffplug.spotless.StepHarness;
 import com.diffplug.spotless.TestProvisioner;
 import com.diffplug.spotless.json.JsonFormatterStepCommonTests;
+import com.diffplug.spotless.tag.ForLintRefactor;
 
 public class GsonStepTest extends JsonFormatterStepCommonTests {
 
@@ -41,6 +43,8 @@ void handlesObjectWithNull() {
 	}
 
 	@Test
+	@Disabled
+	@ForLintRefactor
 	void handlesInvalidJson() {
 		getStepHarness().testResourceExceptionMsg("json/invalidJsonBefore.json").isEqualTo("End of input at line 3 column 1 path $.a");
 	}