1480: improve logging

Author: simschla

lib/src/main/java/com/diffplug/spotless/npm/NodeModulesCachingNpmProcessFactory.java

@@ -84,7 +84,8 @@ public Result waitFor() {
 						.run(() -> shadowCopy.copyEntryInto(entryName(), NodeServerLayout.NODE_MODULES, nodeServerLayout.nodeModulesDir()));
 				return new CachedResult();
 			} else {
-				Result result = actualNpmInstallProcess.waitFor();
+				Result result = timedLogger.withInfo("calling actual npm install {}", actualNpmInstallProcess.describe())
+						.call(actualNpmInstallProcess::waitFor);
 				assert result.exitCode() == 0;
 				// TODO: maybe spawn a thread to do this in the background?
 				timedLogger.withInfo("Caching node_modules for {} in {}", entryName, cacheDir)

lib/src/main/java/com/diffplug/spotless/npm/ShadowCopy.java

@@ -146,10 +146,10 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IO
 					Files.createLink(target.toPath().resolve(orig.toPath().relativize(file)), file);
 					return super.visitFile(file, attrs);
 				} catch (UnsupportedOperationException | SecurityException | FileSystemException e) {
-					logger.debug("Shadow copy entry does not support hard links: {}", file, e);
+					logger.info("Shadow copy entry does not support hard links: {}. Switching to copy.", file, e);
 					tryHardLink = false; // remember that hard links are not supported
 				} catch (IOException e) {
-					logger.debug("Shadow copy entry failed to create hard link: {}", file, e);
+					logger.info("Shadow copy entry failed to create hard link: {}. Switching to copy.", file, e);
 					tryHardLink = false; // remember that hard links are not supported
 				}
 			}

plugin-gradle/src/test/java/com/diffplug/gradle/spotless/JavascriptExtensionTest.java

@@ -178,7 +178,7 @@ void formattingUsingStyleguide(String styleguide) throws Exception {
 					"    }",
 					"}");
 			setFile("test.js").toResource(styleguidePath + "javascript-es6.dirty");
-			gradleRunner().withArguments("--stacktrace", "spotlessApply").build();
+			gradleRunner().forwardOutput().withArguments("--info", "--stacktrace", "spotlessApply").build();
 			assertFile("test.js").sameAsResource(styleguidePath + "javascript-es6.clean");
 		}
 	}