Skip to content

Commit 852b633

Browse files
author
ntwigg
committed
Fix caching for Gradle 9 standards.
1 parent 7f2c9a0 commit 852b633

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/main/java/com/diffplug/webtools/node/NodePlugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@
3030
import org.gradle.api.*;
3131
import org.gradle.api.file.DirectoryProperty;
3232
import org.gradle.api.provider.Property;
33-
import org.gradle.api.tasks.CacheableTask;
3433
import org.gradle.api.tasks.Input;
3534
import org.gradle.api.tasks.Internal;
3635
import org.gradle.api.tasks.PathSensitivity;
3736
import org.gradle.api.tasks.TaskAction;
3837
import org.gradle.api.tasks.TaskProvider;
38+
import org.gradle.work.DisableCachingByDefault;
3939

4040
/**
4141
* Installs a specific version of node.js and npm,
@@ -74,7 +74,7 @@ public TaskProvider<?> npm_run(String name, Action<NpmRunTask> taskConfig) {
7474
}
7575
}
7676

77-
@CacheableTask
77+
@DisableCachingByDefault(because = "Runs external 'npm run' and produces undeclared outputs; not safely cacheable")
7878
public abstract static class NpmRunTask extends DefaultTask {
7979
public String npmTaskName;
8080
private TreeMap<String, String> environment = new TreeMap<>();

src/main/java/com/diffplug/webtools/serve/StaticServerTask.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@
2727
import org.eclipse.jetty.servlet.ServletContextHandler;
2828
import org.gradle.api.DefaultTask;
2929
import org.gradle.api.tasks.TaskAction;
30+
import org.gradle.work.DisableCachingByDefault;
3031

3132
/** Serves a collection of folders using URLs. */
33+
@DisableCachingByDefault(because = "Dev server task; long-running with no reproducible outputs")
3234
public class StaticServerTask extends DefaultTask {
3335
private int port = 8080;
3436

0 commit comments

Comments
 (0)