fixed bug

Author: Matze99

playground/main.ts

@@ -32,13 +32,15 @@ const image = await composition.add(
   })
 );
 
-const audioTrack = composition.createTrack('audio').stacked();
+const audioTrack = composition.createTrack('audio').stacked(true);
+const audioSource = await core.AudioSource.from('/harvard.MP3');
 await audioTrack.add(
-  await new core.AudioClip(
-    await core.AudioSource.from('/harvard.MP3')
-  )
+  await new core.AudioClip(audioSource)
 );
-await audioTrack.removeSilences();
+await audioTrack.removeSilences({
+  minDuration: 300,
+  windowSize: 1,
+});
 
 image.animate()
   .rotation(-16).to(14, 5).to(-7, 10).to(24, 7).to(-3, 9).to(19, 7).to(-14, 12).to(5, 9).to(-30, 13)

src/sources/audio.spec.ts

@@ -29,27 +29,24 @@ vi.stubGlobal('OfflineAudioContext', MockOfflineAudioContext); // Stub the globa
 
 describe('AudioUtils', () => {
 	it('all silent', () => {
-		const silences = findSilences(new Float32Array(100).fill(1), -50, 100, 100);
+		const silences = findSilences(new Float32Array(100).fill(0), -50, 100, 100);
 		expect(silences).toEqual([{
 			start: new Timestamp(0),
 			stop: new Timestamp(100),
 		}]);
 	});
 
 	it('no silences', () => {
-		const silences = findSilences(new Float32Array(100).fill(0), -50, 100, 100);
+		const silences = findSilences(new Float32Array(100).fill(1), -50, 100, 100);
 		expect(silences).toEqual([]);
 	});
 
 	it('find silences correctly', () => {
 		const samples = Array.from({ length: 500 }, (_, index) => index > 300 ? (index < 400 ? 0 : 1) : -1);
 		const silences = findSilences(new Float32Array(samples), -50, 100, 5000);
 		expect(silences).toEqual([{
-			start: new Timestamp(0),
-			stop: new Timestamp(3010),
-		}, {
-			start: new Timestamp(4000),
-			stop: new Timestamp(5000),
+			start: new Timestamp(3010),
+			stop: new Timestamp(4000),
 		}]);
 	});
 });
@@ -63,18 +60,32 @@ describe('AudioSource', () => {
 	});
 
 	it('find silences correctly', async () => {
+		const audioBuffer = {
+			duration: 16,
+			sampleRate: 1000,
+			length: 16000,
+			getChannelData: () => new Float32Array(16000).fill(0), // Return a dummy Float32Array
+		} as any as AudioBuffer;
+		audioSource.audioBuffer = audioBuffer;
 		const silences = await audioSource.silences({});
 		expect(silences).toEqual([{
 			start: new Timestamp(0),
-			stop: new Timestamp(5000),
+			stop: new Timestamp(16000),
 		}]);
 	});
 
 	it('find silences correctly with too high minDuration', async () => {
+		const audioBuffer = {
+			duration: 16,
+			sampleRate: 1000,
+			length: 16000,
+			getChannelData: () => new Float32Array(16000).fill(0), // Return a dummy Float32Array
+		} as any as AudioBuffer;
+		audioSource.audioBuffer = audioBuffer;
 		const silences = await audioSource.silences({minDuration: 1e10});
 		expect(silences).toEqual([{
 			start: new Timestamp(0),
-			stop: new Timestamp(5000),
+			stop: new Timestamp(16000),
 		}]);
 	});
 

src/sources/audio.ts

@@ -139,7 +139,7 @@ export class AudioSource<T extends Object = {}> extends Source<T> {
 	 */
 	public async silences({
 		threshold = -50,
-		minDuration = 5,
+		minDuration = 100,
 		windowSize = 50,
 	}: SilenceOptions = {}): Promise<{ start: Timestamp; stop: Timestamp }[]> {
 		if (this._silences) return this._silences;

src/sources/audio.utils.ts

@@ -21,7 +21,7 @@ export function findSilences(
 	let silenceStart: number | null = null;
 
 	for (let i = 0; i < decibelValues.length; i++) {
-		if (decibelValues[i] > threshold) {
+		if (decibelValues[i] < threshold) {
 			if (silenceStart === null) {
 				silenceStart = i;
 			}

src/tracks/media/media.ts

@@ -9,7 +9,7 @@ import { Track } from '../track';
 
 import type { MediaClip } from '../../clips';
 import { Timestamp } from '../../models';
-import { StackInsertStrategy } from '../track/track.strategies';
+import { SilenceOptions } from '../../sources';
 
 export class MediaTrack<Clip extends MediaClip> extends Track<MediaClip> {
 	public clips: Clip[] = [];
@@ -26,15 +26,16 @@ export class MediaTrack<Clip extends MediaClip> extends Track<MediaClip> {
 	 *
 	 * @returns Array of silence periods with start and stop times in seconds
 	 */
-	public async removeSilences() {
-
+	public async removeSilences(options: SilenceOptions = {}) {
+		const numClips = this.clips.length;
 		// Process each clip
-		for (const clip of this.clips) {
+		for (let i = 0; i < numClips; i++) {
+			const clip = this.clips[i];
 			if (!clip.element) {
 				continue;
 			}
 
-			const silences = await clip.source.silences({});
+			const silences = await clip.source.silences(options);
 			if (silences.length === 0) {
 				continue;
 			}
@@ -54,21 +55,22 @@ export class MediaTrack<Clip extends MediaClip> extends Track<MediaClip> {
             let currentClip = clip;
 
 			for (const silence of applicableSilences) {
-                if (silence.start.millis < start.millis) {
+                if (silence.start.millis <= start.millis) {
                     const newClip = await currentClip.split(silence.stop.add(currentClip.offset));
                     currentClip.detach();
                     start = silence.stop;
                     currentClip = newClip;
                     continue;
                 }
 
-                if (silence.stop.millis > currentClip.range[1].millis) {
+                if (silence.stop.millis >= currentClip.range[1].millis) {
                     currentClip = await currentClip.split(silence.start.add(currentClip.offset));
                     currentClip.detach();
                     continue;
                 }
 
                 const middleClip = await currentClip.split(silence.start.add(currentClip.offset));
+				
                 currentClip = await middleClip.split(silence.stop.add(middleClip.offset));
                 middleClip.detach();
 			}