optimized for processing stack twice

Author: Matze99

src/tracks/media/media.spec.ts

@@ -90,6 +90,35 @@ describe('The Media Track Object', () => {
 		expect(track.clips.at(1)?.state).toBe('ATTACHED');
 	});
 
+	it('removes silences twice', async () => {
+		const clip = new MockMediaClip([new Timestamp(10000), new Timestamp(20000)], [
+			{
+				start: new Timestamp(0),
+				stop: new Timestamp(500),
+			},
+			{
+				start: new Timestamp(11000),
+				stop: new Timestamp(15000),
+			},
+			{
+				start: new Timestamp(19000),
+				stop: new Timestamp(30500),
+			},
+		], new Audio());
+		await track.add(clip);
+		expect(clip.source).toBeDefined();
+		await track.removeSilences();
+		await track.removeSilences();
+		expect(track.clips.length).toBe(2);
+		expect(track.clips.at(0)?.id).not.toBe(clip.id);
+		expect(track.clips.at(0)?.range[0].millis).toBe(10000);
+		expect(track.clips.at(0)?.range[1].millis).toBe(11000);
+		expect(track.clips.at(1)?.range[0].millis).toBe(15000);
+		expect(track.clips.at(1)?.range[1].millis).toBe(19000);
+		expect(track.clips.at(0)?.state).toBe('ATTACHED');
+		expect(track.clips.at(1)?.state).toBe('ATTACHED');
+	});
+
 	it('should propagate a seek call', async () => {
 		const clip = new MediaClip();
 		clip.element = new Audio();

src/tracks/media/media.ts

@@ -30,17 +30,16 @@ export class MediaTrack<Clip extends MediaClip> extends Track<MediaClip> {
 		const numClips = this.clips.length;
 
 		let newClips: MediaClip<MediaClipProps>[] = [];
+		let clipsToDetach: MediaClip<MediaClipProps>[] = [];
 		// Process each clip
 		for (let i = 0; i < numClips; i++) {
 			const clip = this.clips[i];
 			if (!clip.element) {
-				newClips.push(clip);
 				continue;
 			}
 
 			const silences = await clip.source.silences(options);
 			if (silences.length === 0) {
-				newClips.push(clip);
 				continue;
 			}
 
@@ -52,11 +51,10 @@ export class MediaTrack<Clip extends MediaClip> extends Track<MediaClip> {
 						silence.stop.millis > clip.range[0].millis),
 			);
 			if (applicableSilences.length === 0) {
-				newClips.push(clip);
 				continue;
 			}
 
-			clip.detach();
+			clipsToDetach.push(clip);
 			let start = clip.range[0];
             let currentClip = clip.copy();
 
@@ -85,7 +83,7 @@ export class MediaTrack<Clip extends MediaClip> extends Track<MediaClip> {
 				newClips.push(currentClip);
 			}
 		}
-
+		clipsToDetach.forEach((clip) => clip.detach());
 		const promises = newClips.map((clip) => this.add(clip));
 		await Promise.all(promises);
 	}