fixed clip detach bug

Author: k9p5

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@diffusionstudio/core",
   "private": false,
-  "version": "1.4.2",
+  "version": "1.4.3",
   "type": "module",
   "description": "Build bleeding edge video processing applications",
   "files": [

src/clips/clip/clip.spec.ts

@@ -84,6 +84,40 @@ describe('The Clip Object', () => {
 		expect(clip.track?.id).toBe(track.id);
 	});
 
+	it('should remove event listeners on detach', async () => {
+		const clip0 = new Clip({ start: 0, stop: 20 });
+		const clip1 = new Clip({ stop: 60, start: 30 });
+
+		const composition = new Composition();
+		const track0 = composition.createTrack('base');
+		const track1 = composition.createTrack('base');
+
+		await track0.add(clip0);
+		await track0.add(clip1);
+
+		expect(track0.clips.length).toBe(2);
+		expect(track0.clips[0].start.frames).toBe(0);
+		expect(track0.clips[0].stop.frames).toBe(20);
+
+		expect(track0.clips[1].start.frames).toBe(30);
+		expect(track0.clips[1].stop.frames).toBe(60);
+
+		clip1.detach();
+
+		expect(track0.clips.length).toBe(1);
+
+		await track1.add(clip1);
+
+		expect(track1.clips.length).toBe(1);
+		expect(track1.clips[0].start.frames).toBe(30);
+		expect(track1.clips[0].stop.frames).toBe(60);
+
+		clip1.start = 10;
+
+		expect(track1.clips[0].start.frames).toBe(10);
+		expect(track1.clips[0].stop.frames).toBe(60);
+	});
+
 	it('should be removable from the track', async () => {
 		const clip1 = new Clip({ stop: 900, start: 570 });
 

src/composition/composition.ts

@@ -490,6 +490,7 @@ export class Composition extends EventEmitterMixin<CompositionEvents, typeof Ser
 		if (index != undefined && index >= 0) {
 			this.tracks.splice(index, 1);
 			this.trigger('detach', undefined);
+			track.off('*');
 			return track;
 		}
 	}

src/mixins/event.ts

@@ -36,9 +36,14 @@ export function EventEmitterMixin<Events = {}, T extends Constructor = Construct
 			return id;
 		}
 
-		public off(id?: string, ...ids: string[]) {
+		public off(id?: string | '*', ...ids: string[]) {
 			if (!id) return;
 
+			if (id === '*') {
+				this._handlers = {};
+				return;
+			}
+
 			for (const obj of Object.values(this._handlers)) {
 				if (id in obj) {
 					delete obj[id];

src/tracks/track/track.ts

@@ -233,6 +233,7 @@ export class Track<Clp extends Clip> extends EventEmitterMixin<Events, typeof Se
 			this.clips.splice(index, 1);
 			this.strategy.update(clip, this);
 			this.trigger('detach', undefined);
+			clip.off('*');
 
 			return clip;
 		}