Added migrations files

Author: breardon2011

.github/workflows/test-migrations.yml

@@ -216,95 +216,11 @@ jobs:
           echo "Checking if key tables exist..."
           sqlite3 test.db ".tables" | grep -E "units|organizations|users|rules"
 
-  test-sqlserver:
-    name: Test SQL Server Migrations
-    runs-on: ubuntu-latest
-    
-    services:
-      sqlserver:
-        image: mcr.microsoft.com/mssql/server:2022-latest
-        env:
-          ACCEPT_EULA: Y
-          SA_PASSWORD: YourStrong@Passw0rd
-          MSSQL_PID: Developer
-        ports:
-          - 1433:1433
-        options: >-
-          --health-cmd "/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P YourStrong@Passw0rd -Q 'SELECT 1'"
-          --health-interval 10s
-          --health-timeout 5s
-          --health-retries 10
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Setup Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: '1.22'
-          cache-dependency-path: |
-            taco/go.sum
-            go.work.sum
-
-      - name: Install Atlas CLI
-        run: |
-          curl -sSf https://atlasgo.sh | sh
-          atlas version
-
-      - name: Create test database
-        run: |
-          # Wait for SQL Server to be fully ready
-          sleep 10
-          docker exec $(docker ps -q --filter ancestor=mcr.microsoft.com/mssql/server:2022-latest) \
-            /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'YourStrong@Passw0rd' \
-            -Q 'CREATE DATABASE opentaco_test'
-
-      - name: Build statesman binary
-        working-directory: taco
-        run: |
-          go build -o statesman ./cmd/statesman
-
-      - name: Test migrations with binary
-        working-directory: taco
-        env:
-          OPENTACO_BACKEND: mssql
-          OPENTACO_MSSQL_HOST: localhost
-          OPENTACO_MSSQL_PORT: 1433
-          OPENTACO_MSSQL_USER: sa
-          OPENTACO_MSSQL_PASSWORD: YourStrong@Passw0rd
-          OPENTACO_MSSQL_DATABASE: opentaco_test
-          OPENTACO_AUTH_DISABLE: true
-          OPENTACO_JWT_SECRET: test-secret-key-for-ci
-        run: |
-          # Run binary in background (it will apply migrations on startup)
-          timeout 30s ./statesman --port 8080 --auth-disable --storage memory || true
-          
-          # Give it time to apply migrations
-          sleep 5
-
-      - name: Verify migrations applied
-        run: |
-          echo "Checking if atlas_schema_revisions table exists..."
-          docker exec $(docker ps -q --filter ancestor=mcr.microsoft.com/mssql/server:2022-latest) \
-            /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'YourStrong@Passw0rd' -d opentaco_test \
-            -Q "SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 'atlas_schema_revisions'"
-          
-          echo "Checking applied migrations..."
-          docker exec $(docker ps -q --filter ancestor=mcr.microsoft.com/mssql/server:2022-latest) \
-            /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'YourStrong@Passw0rd' -d opentaco_test \
-            -Q "SELECT version FROM atlas_schema_revisions ORDER BY version"
-          
-          echo "Checking if key tables exist..."
-          docker exec $(docker ps -q --filter ancestor=mcr.microsoft.com/mssql/server:2022-latest) \
-            /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'YourStrong@Passw0rd' -d opentaco_test \
-            -Q "SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_TYPE = 'BASE TABLE' ORDER BY TABLE_NAME"
-
   # Summary job that requires all database tests to pass
   all-migrations-passed:
     name: All Migrations Passed
     runs-on: ubuntu-latest
-    needs: [test-postgres, test-mysql, test-sqlite, test-sqlserver]
+    needs: [test-postgres, test-mysql, test-sqlite]
     steps:
       - name: All tests passed
         run: echo "✅ All database migrations tested successfully!"

go.work.sum

@@ -104,18 +104,17 @@ atlas-install: ## Install Atlas CLI and GORM provider
 	@go install ariga.io/atlas-provider-gorm@latest
 	@echo "✅ Atlas tools installed successfully"
 
-# Generate migrations for all database dialects
+# Generate migrations for all database dialects (Postgres, MySQL, SQLite)
 atlas-diff-all: ## Generate migrations for all databases (use: make atlas-diff-all name=my_change)
 	@echo "Generating migrations for all databases..."
 	@if [ -z "$(filter-out $(NAME),$(shell date +%Y%m%d%H%M%S))" ]; then \
 		echo "⚠️  Using auto-generated name: $(NAME)"; \
 		echo "💡 Tip: Use 'make atlas-diff-all name=descriptive_name' for better naming"; \
 	fi
-	@mkdir -p migrations/postgres migrations/mysql migrations/sqlite migrations/sqlserver
+	@mkdir -p migrations/postgres migrations/mysql migrations/sqlite
 	@echo "\n📊 PostgreSQL..." && atlas migrate diff $(NAME) --env postgres
 	@echo "\n📊 MySQL..." && atlas migrate diff $(NAME) --env mysql
 	@echo "\n📊 SQLite..." && atlas migrate diff $(NAME) --env sqlite
-	@echo "\n📊 SQL Server..." && atlas migrate diff $(NAME) --env sqlserver
 	@$(MAKE) atlas-hash-all
 	@echo "\n✅ All migrations generated successfully!"
 
@@ -126,12 +125,10 @@ atlas-lint-all: ## Validate and lint all migration files
 	@echo "PostgreSQL..." && atlas migrate validate --env postgres
 	@echo "MySQL..." && atlas migrate validate --env mysql
 	@echo "SQLite..." && atlas migrate validate --env sqlite
-	@echo "SQL Server..." && atlas migrate validate --env sqlserver
 	@echo "✅ All migrations validated successfully"
 
 # Update migration directory hashes (called automatically by atlas-diff-all)
 atlas-hash-all:
 	@atlas migrate hash --dir file://migrations/postgres 2>/dev/null || true
 	@atlas migrate hash --dir file://migrations/mysql 2>/dev/null || true
-	@atlas migrate hash --dir file://migrations/sqlite 2>/dev/null || true
-	@atlas migrate hash --dir file://migrations/sqlserver 2>/dev/null || true
+	@atlas migrate hash --dir file://migrations/sqlite 2>/dev/null || true

taco/Makefile

@@ -1,26 +1,23 @@
-# SQLite configuration
-data "external_schema" "gorm_sqlite" {
-  program = [
-    "sh",
-    "-c",
-    "cd internal && go run ./atlas_loader.go sqlite",
-  ]
+variable "DB_URL" {
+  type    = string
+  default = "postgres://postgres:postgres@localhost:5432/devdb?sslmode=disable"
 }
 
-env "sqlite" {
-  src = data.external_schema.gorm_sqlite.url
-  dev = "sqlite://file?mode=memory"
-  migration {
-    dir = "file://internal/query/migration/atlas/migrations/sqlite"
-  }
-  format {
-    migrate {
-      diff = "{{ sql . \"  \" }}"
-    }
-  }
+variable "POSTGRES_MIGRATIONS_DIR" {
+  type    = string
+  default = "file://migrations/postgres"
+}
+
+variable "MYSQL_MIGRATIONS_DIR" {
+  type    = string
+  default = "file://migrations/mysql"
+}
+
+variable "SQLITE_MIGRATIONS_DIR" {
+  type    = string
+  default = "file://migrations/sqlite"
 }
 
-# PostgreSQL configuration
 data "external_schema" "gorm_postgres" {
   program = [
     "sh",
@@ -31,10 +28,23 @@ data "external_schema" "gorm_postgres" {
 
 env "postgres" {
   src = data.external_schema.gorm_postgres.url
-  dev = "docker://postgres/16.1"
+  url = var.DB_URL
+
+  # IMPORTANT: no env=… params here; keep 5m timeout.
+  # If your build wants fully-qualified, use docker://docker.io/library/postgres/16
+  dev = "docker://postgres/16?timeout=5m"
+
+  schemas = ["public"]
+
   migration {
-    dir = "file://internal/query/migration/atlas/migrations/postgres"
+    dir    = var.POSTGRES_MIGRATIONS_DIR
+    format = "atlas"
+  }
+
+  lint {
+    destructive { error = true }
   }
+
   format {
     migrate {
       diff = "{{ sql . \"  \" }}"
@@ -53,32 +63,49 @@ data "external_schema" "gorm_mysql" {
 
 env "mysql" {
   src = data.external_schema.gorm_mysql.url
-  dev = "docker://mysql/8"
+  
+  dev = "docker://mysql/8/devdb?timeout=5m"
+  
   migration {
-    dir = "file://internal/query/migration/atlas/migrations/mysql"
+    dir    = var.MYSQL_MIGRATIONS_DIR
+    format = "atlas"
   }
+  
+  lint {
+    destructive { error = true }
+  }
+  
   format {
     migrate {
       diff = "{{ sql . \"  \" }}"
     }
   }
 }
 
-# SQL Server configuration
-data "external_schema" "gorm_sqlserver" {
+# SQLite configuration
+data "external_schema" "gorm_sqlite" {
   program = [
     "sh",
     "-c",
-    "cd internal && go run ./atlas_loader.go sqlserver",
+    "cd internal && go run ./atlas_loader.go sqlite",
   ]
 }
 
-env "sqlserver" {
-  src = data.external_schema.gorm_sqlserver.url
-  dev = "docker://sqlserver/2022-latest"
+env "sqlite" {
+  src = data.external_schema.gorm_sqlite.url
+  
+  # SQLite uses in-memory dev database, no Docker needed
+  dev = "sqlite://file?mode=memory"
+  
   migration {
-    dir = "file://internal/query/migration/atlas/migrations/sqlserver"
+    dir    = var.SQLITE_MIGRATIONS_DIR
+    format = "atlas"
+  }
+  
+  lint {
+    destructive { error = true }
   }
+  
   format {
     migrate {
       diff = "{{ sql . \"  \" }}"

taco/atlas.hcl

@@ -23,17 +23,16 @@ type SQLStore struct {
 }
 
 // NewSQLStore creates a new SQLStore.
+// Note: Schema migrations are now handled by Atlas in queryfactory.NewQueryStore()
 func NewSQLStore(db *gorm.DB) (*SQLStore, error) {
 	store := &SQLStore{db: db}
-
-	if err := store.migrate(); err != nil {
-		return nil, fmt.Errorf("failed to migrate common sql schema: %w", err)
-	}
 
+	// Create org-scoped indexes (not handled by Atlas migrations)
 	if err := CreateOrgScopedIndexes(db); err != nil {
 		return nil, fmt.Errorf("failed to create org-scoped indexes: %w", err)
 	}
 
+	// Create database views (not handled by Atlas migrations)
 	if err := store.createViews(); err != nil {
 		return nil, fmt.Errorf("failed to create views: %w", err)
 	}

taco/internal/query/common/sql_store.go

@@ -50,7 +50,7 @@ type Rule struct {
 	Effect           string `gorm:"size:8;not null;default:allow"`
 	WildcardAction   bool   `gorm:"not null;default:false"`
 	WildcardResource bool   `gorm:"not null;default:false"`
-	ResourcePatterns string `gorm:"type:text;default:''"`
+	ResourcePatterns string `gorm:"type:text;"`
 	Actions          []RuleAction  `gorm:"constraint:OnDelete:CASCADE"`
 	UnitTargets      []RuleUnit    `gorm:"constraint:OnDelete:CASCADE"`
 	TagTargets       []RuleUnitTag `gorm:"constraint:OnDelete:CASCADE"`