fix(client): Avoid division by zero in pagination (ktrysmt#188)

maxbrunet · web-flow · commit 14975f6d3ff6 · 2022-03-12T13:14:52.000+09:00
diff --git a/client.go b/client.go
@@ -320,7 +320,7 @@ func (c *Client) doRequest(req *http.Request, emptyResponse bool) (interface{},
 		var values []interface{}
 		for {
 			values = append(values, responsePaginated.Values...)
-			if responsePaginated.Size/responsePaginated.Pagelen <= responsePaginated.Page {
+			if responsePaginated.Pagelen == 0 || responsePaginated.Size/responsePaginated.Pagelen <= responsePaginated.Page {
 				break
 			}
 			newReq, err := http.NewRequest(req.Method, responsePaginated.Next, nil)

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,7 @@ func (c Client) doRequest(req http.Request, emptyResponse bool) (interface{},`
`320`	`320`	`var values []interface{}`
`321`	`321`	`for {`
`322`	`322`	`values = append(values, responsePaginated.Values...)`
`323`		`- if responsePaginated.Size/responsePaginated.Pagelen <= responsePaginated.Page {`
	`323`	`+ if responsePaginated.Pagelen == 0 \|\| responsePaginated.Size/responsePaginated.Pagelen <= responsePaginated.Page {`
`324`	`324`	`break`
`325`	`325`	`}`
`326`	`326`	`newReq, err := http.NewRequest(req.Method, responsePaginated.Next, nil)`