Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
motatoes
approved these changes
Mar 13, 2026
Preview Environment DestroyedThe preview environment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiUrlwhenconnectURLis empty)Architecture
Auth flow: SDK authenticates with API key → control plane validates → proxy mints a short-lived JWT (5 min) → worker validates JWT.
Changes
New:
internal/proxy/sandbox_api_proxy.goGeneric HTTP/WebSocket proxy that forwards data-plane requests to the worker that owns the sandbox. Handles:
/api/sandboxes/...→/sandboxes/...)Modified:
internal/api/router.goData-plane routes (exec, files, pty, agent, timeout, token refresh) are now conditionally registered:
SandboxAPIProxy→ forwarded to workersModified:
internal/api/sandbox.goconnectURLremoved from all server-mode API responses (createSandboxRemote,getSandboxRemote,listSandboxesRemote)connectURLis empty, the SDK automatically usesapiUrl(the control plane through ALB)setTimeout(proxy handles routing now)Modified:
internal/worker/http_server.go/caddy/checkendpoint (Caddy on-demand TLS validation no longer needed)Modified:
deploy/ec2/setup-instance.shOPENSANDBOX_HTTP_ADDR(was public IP)Deleted:
deploy/ec2/Caddyfile,deploy/ec2/caddy.serviceModified:
cmd/server/main.goSandboxAPIProxywhen worker registry, DB store, and JWT issuer are availableWhat doesn't change
apiUrlwhenconnectURLis empty🤖 Generated with Claude Code